DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rami Rosen <ramirose@gmail.com>
To: John McNamara <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] doc: fix spelling errors reported by aspell
Date: Sat, 27 Apr 2019 21:53:07 +0300	[thread overview]
Message-ID: <CAHLOa7Qnyu6Gutb3D=htqSkVGKVFnmBeZj6Ra0amPVSyetr8sw@mail.gmail.com> (raw)
In-Reply-To: <1556291662-16595-1-git-send-email-john.mcnamara@intel.com>

Hi John,

Thanks for this patch set, it really makes DPDK documentation more refined.

> -(for example the collectd plugin) should be run to begin querying the
API.
> +(for example the CollectD plugin) should be run to begin querying the
API.


I am not sure about this change to "CollectD". Actually from what I know,
in official
collectd/service assurance documenration, it always appear as "collectd
plugin" or "Collectd plugin" (this is the usual semantics for unix/linux
daemons).

For example,

https://blog.dbrgn.ch/2017/3/10/write-a-collectd-python-plugin/
https://wiki.opnfv.org/display/fastpath/Collectd+how+to+implement+a+simple+plugin
https://collectd.org/documentation/manpages/collectd.conf.5.shtml

If it  agreed that change to CollectD should be reverted, not sure that a
new V3 should be sent, this is a huge patch; if reverting can be done via
merge, it will be better.

Other than that,
Acked-by: Rami Rosen <ramirose@gmail.com>

>
>

  parent reply	other threads:[~2019-04-27 18:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 15:14 John McNamara
2019-04-26 15:14 ` John McNamara
2019-04-26 15:14 ` [dpdk-dev] [PATCH v2 2/2] " John McNamara
2019-04-26 15:14   ` John McNamara
2019-04-27 18:53 ` Rami Rosen [this message]
2019-04-27 18:53   ` [dpdk-dev] [PATCH v2 1/2] " Rami Rosen
2019-04-30 11:26   ` Mcnamara, John
2019-04-30 11:26     ` Mcnamara, John
2019-05-02 22:36     ` Thomas Monjalon
2019-05-02 22:36       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHLOa7Qnyu6Gutb3D=htqSkVGKVFnmBeZj6Ra0amPVSyetr8sw@mail.gmail.com' \
    --to=ramirose@gmail.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).