From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ramirose@gmail.com>
Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com
 [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id A8D0927D
 for <dev@dpdk.org>; Mon, 25 Feb 2019 07:26:33 +0100 (CET)
Received: by mail-ed1-f66.google.com with SMTP id g9so6575456eds.3
 for <dev@dpdk.org>; Sun, 24 Feb 2019 22:26:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=rmb5JxaS0mW2jOmlDVmKdJCya6tmPkewJ/FNPZuCRvk=;
 b=BMYcfts14yGSzCfobuuerx5vQ56vNSZqbS7RTKFNrostjIlAK5jru2S9gosvj+U5bo
 722eMMtZgaFT5fB0cxs3RPMhIHPeskVME6c6lR2N+cwCPAVhwXOQqyiFWgnRYcVxP+q3
 8+xaRcRQz8lmskI9Rhw2V7UUmdeRxUUkqkTiwZLTInpyJeJWuUer2AB1y/ILRIvKX9Tt
 l0W+SWLnSkpBooGCPQWU2s7i08+UgBbR7u0O/z9cJrpM2CDdEq0miQdGVh3G6jvBSuo9
 0NXEVXhMXLm6sd/E/cNKmufVll9YbCiEKTi0IbNzbaavxWLby6W3+joQ+aQrMOBROPzo
 4cJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=rmb5JxaS0mW2jOmlDVmKdJCya6tmPkewJ/FNPZuCRvk=;
 b=MZiu9PgS7lajbLn52f55jPCB2LPm+Asie9/ENj31DSm5RehB8T+PMwqjYJyoTDu++p
 RsfQjWlnzBql0lWWA0eTg7FhDUww10pHKV2CTWWOBhDalE+2rCeuANOfxfuPhAn9mp4Y
 ue1HZiJuV+zJ0p6ts1dc1oWNOf1o6HnaY1x5CrlVuEw9ow2D/FpkhTm9KYvGlu6ceAda
 x8nfoHa6yBlWipUw6c+g4wh3vi49Cdds5bABhq26KVxOpt/9olmu/JtmWybv7EJ0Cos1
 qPL9rxaiFn2c/Sq+CwZK4+pMVF9OTAJzGcLOow/tPDAiCH0KHsy6gxv3Eexq5UFLyOCj
 uGSQ==
X-Gm-Message-State: AHQUAuanwvhtHGpCEa+pYl87Ri3hMZHAbd5njIaRQ/0yIPD2+vYZ34//
 YCN5HR0eB+MicJb1Y/iuYGzvlIk91KFnQ2HeE1U=
X-Google-Smtp-Source: AHgI3IYsmVMffPj0w8UN/naNV467k4qe/+D+SOCXy0WJlBcHwfF5IVd0FvK0tVEj7vglql46OKo22qsZQ58WRfUXU3I=
X-Received: by 2002:a50:a3d5:: with SMTP id t21mr13112730edb.87.1551075993229; 
 Sun, 24 Feb 2019 22:26:33 -0800 (PST)
MIME-Version: 1.0
References: <20190224224240.26361-1-thomas@monjalon.net>
In-Reply-To: <20190224224240.26361-1-thomas@monjalon.net>
From: Rami Rosen <ramirose@gmail.com>
Date: Mon, 25 Feb 2019 08:26:22 +0200
Message-ID: <CAHLOa7SAfEWJn3LoKwOVAEbdhHYEe-3xvOac6ZJOSWFxHSyC-g@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>,
 dev <dev@dpdk.org>, ophirmu@mellanox.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2019 06:26:33 -0000

Checked on Fedora 28

Reviewed-by: Rami Rosen <ramirose at gmail.com>


On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net>
wrote:

> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/mlx5/mlx5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index df71707ccb..bda909eaa5 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>         }
>         /* Build device name. */
>         if (!switch_info->representor)
> -               rte_strlcpy(name, dpdk_dev->name, sizeof(name));
> +               strlcpy(name, dpdk_dev->name, sizeof(name));
>         else
>                 snprintf(name, sizeof(name), "%s_representor_%u",
>                          dpdk_dev->name, switch_info->port_name);
> --
> 2.20.1
>
>

-- 
regards,
Rami Rosen