From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id E5C5A1B3BB; Thu, 21 Mar 2019 07:20:03 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id a25so4023849edc.8; Wed, 20 Mar 2019 23:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UtOll8HWnIC0Ng9TBowiqb1SPwnvVtctqZMtxC8IR1A=; b=J4WbR1eEXmfTfuiMmGmfBKTL80Zzbosc62qium8dNpWUVMNhTtBP/sSRYdNT2Ek0lj gSCwSWlZeaapt90fXc03KssLWO12mCoZR8Av5LckJw1GM+9qhJ/fL8P8wuita424nI44 /863Q0AqoxeFtw/prT09l7jzjhmzpWn2CItPSWO4r5XtyU4jt8DGIAV2y6wIwLhtrp0N +CoviY0LYAdPT1WHsAi2qP/IcTHCBNDvW2oloROk8aVmPFIZOFOWVGBeKzbMOi7cblVL wFTH2Mm1VxF+3c/ozvFtG38bstXtVL0juiXUFOwIuO3fy0eWy/oNP7HzTD13QAMyq4cX RCWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UtOll8HWnIC0Ng9TBowiqb1SPwnvVtctqZMtxC8IR1A=; b=cGZSUcB8UmANGW3pOYCiSIXpXjTQlzKVSSnh4eZoa2H4+D4JnnG9O5uGzTtjghJln3 q6b5tTgYMiCXrwARQ2tOKiBg3tuOhHMBXhB35U4C1DLKJ8UxSe/k/N4YK3YB/zu38lMs MFp8iMkrGRErj7fsJwWnop8HCHSqIUMtl/BvV8AIYobVX2oL+BxlryZ7CzwFqbnHnafW O68xHqY4gGLVcaI7DAGClhDu4mjVcMS6saMTi3QXLJpZDN+1B2z4y/aUIlE1mm+m0ys6 2Kd7R7OboDsGmPb/Mmcm53SEbyljHzSdrnoO09MuP+1+xTojjgYazOfKExpKAhVfTsqf X9mw== X-Gm-Message-State: APjAAAVjBK+iGmFHwf1LmcrmRinOitRaWVXoiGZr9Bhei+PFu7dS7oOX Z99TZ2m87v26ckDYsjHfmg6FCpdbCd78Ck0TuLg= X-Google-Smtp-Source: APXvYqxMsXGIc4LaB+SMWkpZtngwv7FlGaobJiYxCt3dE0RTLC2uYXvyBVE66AycZTon+Zyv24iFojRzzNCFuH6F91Y= X-Received: by 2002:a50:8997:: with SMTP id g23mr1330430edg.80.1553149203564; Wed, 20 Mar 2019 23:20:03 -0700 (PDT) MIME-Version: 1.0 References: <1553090259-30893-1-git-send-email-andrius.sirvys@intel.com> In-Reply-To: <1553090259-30893-1-git-send-email-andrius.sirvys@intel.com> From: Rami Rosen Date: Thu, 21 Mar 2019 08:19:52 +0200 Message-ID: To: Andrius Sirvys Cc: dev , Maxime Coquelin , Tiwei Bie , Zhihong Wang , stable@dpdk.org, jianfeng.tan@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] drivers/virtio: fix duplicate naming of include guard X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 06:20:04 -0000 On Wed, Mar 20, 2019 at 3:58 PM Andrius Sirvys wrote: > The LGTM static code analysis tool is reporting > > "The macro name '_VHOST_NET_USER_H' of this include guard is used > in 2 different header files." > > lib/librte_vhost/vhost_user.h has the same include guard. > Renamed the include guard in vhost.h to differentiate. > > Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer") > Cc: jianfeng.tan@intel.com > Signed-off-by: Andrius Sirvys > --- > > Acked-by: Rami Rosen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F0D37A00E6 for ; Thu, 21 Mar 2019 07:20:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E5A31B3DA; Thu, 21 Mar 2019 07:20:04 +0100 (CET) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id E5C5A1B3BB; Thu, 21 Mar 2019 07:20:03 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id a25so4023849edc.8; Wed, 20 Mar 2019 23:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UtOll8HWnIC0Ng9TBowiqb1SPwnvVtctqZMtxC8IR1A=; b=J4WbR1eEXmfTfuiMmGmfBKTL80Zzbosc62qium8dNpWUVMNhTtBP/sSRYdNT2Ek0lj gSCwSWlZeaapt90fXc03KssLWO12mCoZR8Av5LckJw1GM+9qhJ/fL8P8wuita424nI44 /863Q0AqoxeFtw/prT09l7jzjhmzpWn2CItPSWO4r5XtyU4jt8DGIAV2y6wIwLhtrp0N +CoviY0LYAdPT1WHsAi2qP/IcTHCBNDvW2oloROk8aVmPFIZOFOWVGBeKzbMOi7cblVL wFTH2Mm1VxF+3c/ozvFtG38bstXtVL0juiXUFOwIuO3fy0eWy/oNP7HzTD13QAMyq4cX RCWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UtOll8HWnIC0Ng9TBowiqb1SPwnvVtctqZMtxC8IR1A=; b=cGZSUcB8UmANGW3pOYCiSIXpXjTQlzKVSSnh4eZoa2H4+D4JnnG9O5uGzTtjghJln3 q6b5tTgYMiCXrwARQ2tOKiBg3tuOhHMBXhB35U4C1DLKJ8UxSe/k/N4YK3YB/zu38lMs MFp8iMkrGRErj7fsJwWnop8HCHSqIUMtl/BvV8AIYobVX2oL+BxlryZ7CzwFqbnHnafW O68xHqY4gGLVcaI7DAGClhDu4mjVcMS6saMTi3QXLJpZDN+1B2z4y/aUIlE1mm+m0ys6 2Kd7R7OboDsGmPb/Mmcm53SEbyljHzSdrnoO09MuP+1+xTojjgYazOfKExpKAhVfTsqf X9mw== X-Gm-Message-State: APjAAAVjBK+iGmFHwf1LmcrmRinOitRaWVXoiGZr9Bhei+PFu7dS7oOX Z99TZ2m87v26ckDYsjHfmg6FCpdbCd78Ck0TuLg= X-Google-Smtp-Source: APXvYqxMsXGIc4LaB+SMWkpZtngwv7FlGaobJiYxCt3dE0RTLC2uYXvyBVE66AycZTon+Zyv24iFojRzzNCFuH6F91Y= X-Received: by 2002:a50:8997:: with SMTP id g23mr1330430edg.80.1553149203564; Wed, 20 Mar 2019 23:20:03 -0700 (PDT) MIME-Version: 1.0 References: <1553090259-30893-1-git-send-email-andrius.sirvys@intel.com> In-Reply-To: <1553090259-30893-1-git-send-email-andrius.sirvys@intel.com> From: Rami Rosen Date: Thu, 21 Mar 2019 08:19:52 +0200 Message-ID: To: Andrius Sirvys Cc: dev , Maxime Coquelin , Tiwei Bie , Zhihong Wang , stable@dpdk.org, jianfeng.tan@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] drivers/virtio: fix duplicate naming of include guard X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321061952.lMaJS8FyH14SWxl1b4dXplUSlB2yyDNj4lh8gy6S_mc@z> On Wed, Mar 20, 2019 at 3:58 PM Andrius Sirvys wrote: > The LGTM static code analysis tool is reporting > > "The macro name '_VHOST_NET_USER_H' of this include guard is used > in 2 different header files." > > lib/librte_vhost/vhost_user.h has the same include guard. > Renamed the include guard in vhost.h to differentiate. > > Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer") > Cc: jianfeng.tan@intel.com > Signed-off-by: Andrius Sirvys > --- > > Acked-by: Rami Rosen