From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by dpdk.org (Postfix) with ESMTP id A538756A1 for ; Tue, 19 Feb 2019 06:48:40 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id y185so1316465wmd.1 for ; Mon, 18 Feb 2019 21:48:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qH4DnJ1kkR7OnxEWcBf9nsoNSIh9H0z4qovKVBa+nYE=; b=KHzFRkAHFVw2Eb0TqhRSPEq+40MpHT/40rl/aLbtBixHHgC1vLi8ElocffDPVsTWyM ORoRav3XYecPyxmp0+AnEgSvC0oF1LM2LWh1UsWXLnY2Fvzz80I0LeoL4BNjAZbdEOUs dyXVqTm46HlZmlk6Xht3VJQvh2xxmfXn9Bjxsc1zR3oFMfinvH1pTbI4Y0qFfr2HFyo2 yX7WiZrsKtxxIzl20r/ci3ZJ5N/HQB6a9if4lgX6DWBEm7mBDXNnOwj3JILLFLPr/x6p 21ezGNzX0vwqGIT+jszBORa5m7/rF4ulshtdTnk1TOLBt67S3pDj+klxEs4H1GqGHP3G 7ayQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qH4DnJ1kkR7OnxEWcBf9nsoNSIh9H0z4qovKVBa+nYE=; b=V67sXz7v7CCrY8ayTIcIfnIhQMl+DXDcEYwPAgMx1xVkr9754vQ8mSD/52q6ICCAfE QdFiRUdZwSgzfU+KlCK1yreluz1QPi0ZPn57v9prxFpQfZJSDzxCxyjxBH07AevoQZNm 8zRrTedm/fD7D4HyjJJH+ebQE/uv4zal47TLSSYBP3iVMsYKQzl5B+uk1hSKkzeiCOtK oCs+tg60KVNdXzTy7QMkYlOgBkQeTg5SMFbpAmaIz5GxrCjMFkHtuwlFMsiR8bakNScF 4GxrWzDAn+UH+90dPsHRjyyhh1wlXyEwBulqbcJGtCyDmeZO0rWHryK4T73xwRWzr2Qm r7Yw== X-Gm-Message-State: AHQUAuaJTdCy/Ti6/gRY/tJQCGIZj5SFB9ceDizRUySPFDXhGtSKp1Sv BReufddSWM/BzFhLLEdm2Khbm6BR3n7sCgdBIIM= X-Google-Smtp-Source: AHgI3Iaw/jNH+3dmSBlQTyNs3WEnsgvaClwKmoTQWhejiof+e7hmnNWxjKMU5ekTSaHEFy2USQiHE8QZ7AM1tI6KfWY= X-Received: by 2002:a7b:c017:: with SMTP id c23mr1437975wmb.50.1550555320090; Mon, 18 Feb 2019 21:48:40 -0800 (PST) MIME-Version: 1.0 References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com> <1550158972-21895-3-git-send-email-david.marchand@redhat.com> In-Reply-To: <1550158972-21895-3-git-send-email-david.marchand@redhat.com> From: Rami Rosen Date: Tue, 19 Feb 2019 07:48:30 +0200 Message-ID: To: David Marchand Cc: dev , wenzhuo.lu@intel.com, jingjing.wu@intel.com, "Iremonger, Bernard" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/5] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2019 05:48:40 -0000 +1 Reviewed-by: Rami Rosen On Thu, Feb 14, 2019 at 5:43 PM David Marchand wrote: > Having the standard stats and the rx burst stats on the same line gives a > really long line and is not consistent with the rest. > > Before: > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 > RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > After: > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > Signed-off-by: David Marchand > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 98c1baa..984155a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1459,7 +1459,7 @@ struct extmem_param { > "TX Port=%2d/Queue=%2d %s\n", > fwd_top_stats_border, fs->rx_port, fs->rx_queue, > fs->tx_port, fs->tx_queue, fwd_top_stats_border); > - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u", > + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n", > fs->rx_packets, fs->tx_packets, fs->fwd_dropped); > > /* if checksum mode */ > -- > 1.8.3.1 > > -- regards, Rami Rosen