From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id DF2C32BCE; Tue, 9 Apr 2019 19:59:20 +0200 (CEST) Received: by mail-ed1-f66.google.com with SMTP id d13so5769506edr.5; Tue, 09 Apr 2019 10:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4kKfs7EgQbhJXTCznkFbgMzJgykPhJq+HhrfPKM+eMA=; b=NGe4Aa+dqJxSk0MDphprMIYEn+cNbHix/WYNSWjq1IJSgGJ9+EJc8j0bIHc7DChD56 LZmbPHLsT+wKFIfA5D5qZqqJ/l6KzQ8ukLf/RZep/DKSRv1pcy9IdtvrUZkDDKGz2EM8 fxIJcC0RYSQwcVE1F0kCFxnJcMvMosRvnCrgZwJWLDklHQqN9D+wHUW/6LE6V1pQqnZd R71eqTY2Kb3XIgQ/kQ6aL5J6XxY7VpL78obJAUIEEm9vf9EPlNlLpywTR++jfz5Kz6l1 oi5xUzOy/Ng9fKQwdQGvYvSs5M+nGybQrffQrKoK//C857qjWwCGjA4Fk+HvWDL1KQ+M ra4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4kKfs7EgQbhJXTCznkFbgMzJgykPhJq+HhrfPKM+eMA=; b=S6LzkaL2nLs/dWK6Nmp5NeL+djjW50WGEP9ZRbBCQ28gUlUiiKHUWeOaxClakkWcyv gRzYiY3OfwGzCvt2DhDMG8ddkiE6P9t9/VrfCCuX6xVLvfL/r5Tt1D0il4gOOMkElZeg JrVI8hoZ49LaHVYWsvc0KeWUSBuvP2n23RkOnrLVpoqD0zyOD0iP0BKjCgCdJrTT/eLa lcQYrWsh9r8s2atE54B5dnrmaNdgEwA9hwsG30qMel3dYvAZKBF54eHABm8odzqcBmat Zw0CtGKCYVff8gPrZFZ8enGdybpLHGb4LBuPVrgqUzjrUBI+Tlpx5OC1DSaY1/7WOkqM nKAA== X-Gm-Message-State: APjAAAWTZf1QGKuiiEZCW1hjv/QlfByv1MNSRBBGaqxZ68bafmXAoBUR Vyq2r0Fd/CsMZes7MzzKYxZaynDzg56IXfa/CBs= X-Google-Smtp-Source: APXvYqy+uWGHvSXGIkkbTva+K2+ywvT6LLjpoGrOt590nxN+L2yWB5LbcDmyaAFGBVbwEcKWLxRDdHRCHdubt7VN9Lc= X-Received: by 2002:a17:906:7c10:: with SMTP id t16mr5139437ejo.44.1554832760299; Tue, 09 Apr 2019 10:59:20 -0700 (PDT) MIME-Version: 1.0 References: <20190408142226.88179-1-ferruh.yigit@intel.com> <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> From: Rami Rosen Date: Tue, 9 Apr 2019 20:59:09 +0300 Message-ID: To: Bruce Richardson Cc: Ferruh Yigit , dev , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 17:59:21 -0000 On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote: > Build error seen with Linux kernel 5.1 and > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > Build error: > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: > error: initialization of ... from incompatible pointer type ... > [-Werror=incompatible-pointer-types] > .ndo_fdb_add = igb_ndo_fdb_add, > ^~~~~~~~~~~~~~~ > > ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires > a new parameter, 'struct netlink_ext_ack *extack': > Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()") > > ndo_fdb_add() parameter updated with compile time Linux kernel version > check. > > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- Tested-by: Bruce Richardson Thanks. Checked build with CONFIG_RTE_KNI_KMOD_ETHTOOL=y after applying the patch, build was done against the bleeding edge of net-next of today (kernel 5.1-rc4). Build of the kni kernel module completed successfully. Reviewed-by: Rami Rosen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A001BA0096 for ; Tue, 9 Apr 2019 19:59:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D0BB4F91; Tue, 9 Apr 2019 19:59:22 +0200 (CEST) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id DF2C32BCE; Tue, 9 Apr 2019 19:59:20 +0200 (CEST) Received: by mail-ed1-f66.google.com with SMTP id d13so5769506edr.5; Tue, 09 Apr 2019 10:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4kKfs7EgQbhJXTCznkFbgMzJgykPhJq+HhrfPKM+eMA=; b=NGe4Aa+dqJxSk0MDphprMIYEn+cNbHix/WYNSWjq1IJSgGJ9+EJc8j0bIHc7DChD56 LZmbPHLsT+wKFIfA5D5qZqqJ/l6KzQ8ukLf/RZep/DKSRv1pcy9IdtvrUZkDDKGz2EM8 fxIJcC0RYSQwcVE1F0kCFxnJcMvMosRvnCrgZwJWLDklHQqN9D+wHUW/6LE6V1pQqnZd R71eqTY2Kb3XIgQ/kQ6aL5J6XxY7VpL78obJAUIEEm9vf9EPlNlLpywTR++jfz5Kz6l1 oi5xUzOy/Ng9fKQwdQGvYvSs5M+nGybQrffQrKoK//C857qjWwCGjA4Fk+HvWDL1KQ+M ra4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4kKfs7EgQbhJXTCznkFbgMzJgykPhJq+HhrfPKM+eMA=; b=S6LzkaL2nLs/dWK6Nmp5NeL+djjW50WGEP9ZRbBCQ28gUlUiiKHUWeOaxClakkWcyv gRzYiY3OfwGzCvt2DhDMG8ddkiE6P9t9/VrfCCuX6xVLvfL/r5Tt1D0il4gOOMkElZeg JrVI8hoZ49LaHVYWsvc0KeWUSBuvP2n23RkOnrLVpoqD0zyOD0iP0BKjCgCdJrTT/eLa lcQYrWsh9r8s2atE54B5dnrmaNdgEwA9hwsG30qMel3dYvAZKBF54eHABm8odzqcBmat Zw0CtGKCYVff8gPrZFZ8enGdybpLHGb4LBuPVrgqUzjrUBI+Tlpx5OC1DSaY1/7WOkqM nKAA== X-Gm-Message-State: APjAAAWTZf1QGKuiiEZCW1hjv/QlfByv1MNSRBBGaqxZ68bafmXAoBUR Vyq2r0Fd/CsMZes7MzzKYxZaynDzg56IXfa/CBs= X-Google-Smtp-Source: APXvYqy+uWGHvSXGIkkbTva+K2+ywvT6LLjpoGrOt590nxN+L2yWB5LbcDmyaAFGBVbwEcKWLxRDdHRCHdubt7VN9Lc= X-Received: by 2002:a17:906:7c10:: with SMTP id t16mr5139437ejo.44.1554832760299; Tue, 09 Apr 2019 10:59:20 -0700 (PDT) MIME-Version: 1.0 References: <20190408142226.88179-1-ferruh.yigit@intel.com> <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> From: Rami Rosen Date: Tue, 9 Apr 2019 20:59:09 +0300 Message-ID: To: Bruce Richardson Cc: Ferruh Yigit , dev , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409175909.QjqthTzT2wrd45DNtGL2PZO94APGy6aMQiGXEQCDEMY@z> On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote: > Build error seen with Linux kernel 5.1 and > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > Build error: > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: > error: initialization of ... from incompatible pointer type ... > [-Werror=incompatible-pointer-types] > .ndo_fdb_add = igb_ndo_fdb_add, > ^~~~~~~~~~~~~~~ > > ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires > a new parameter, 'struct netlink_ext_ack *extack': > Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()") > > ndo_fdb_add() parameter updated with compile time Linux kernel version > check. > > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- Tested-by: Bruce Richardson Thanks. Checked build with CONFIG_RTE_KNI_KMOD_ETHTOOL=y after applying the patch, build was done against the bleeding edge of net-next of today (kernel 5.1-rc4). Build of the kni kernel module completed successfully. Reviewed-by: Rami Rosen