From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <mirqus@gmail.com>
Received: from mail-io0-f194.google.com (mail-io0-f194.google.com
[209.85.223.194]) by dpdk.org (Postfix) with ESMTP id F1AEE2C39
for <dev@dpdk.org>; Sat, 3 Dec 2016 09:28:49 +0100 (CET)
Received: by mail-io0-f194.google.com with SMTP id r94so12434481ioe.1
for <dev@dpdk.org>; Sat, 03 Dec 2016 00:28:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to
:cc:content-transfer-encoding;
bh=wt1dCUxLPyaEhmtUagXgU1wfYRBg0wOBEHUH08tOPQI=;
b=k/ABeUW6lqfpzCZtSDTzX8c0J3zlxqdLtTh4+CEvl5iNb980DR2fj978VWSpbLx5VA
6Px+DJjWIHAQ9fkvSQF7l4NEebfH6PBAyClmS/Qk6GCaBVepNM7O4HFcNAH5rZYt1Lpu
VSc+46lWEVndG+FonTiERlNAIt03Yzh+MgUdzEMvQu+F2NU0IwxV2iBBbIKxTbyFT8XS
dnPnZypcsx2lxl2vGi1+eEppf9RYA62EHparrwDO8On5UYOW+Uore2V385mherGIZZe8
zmHhHvLBt+w8FpBWQ5Qj6vQeG/Kri4UW1sx6D75TrtAdR3dDXqLKBjppl490bV5p9CcK
Mlig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc:content-transfer-encoding;
bh=wt1dCUxLPyaEhmtUagXgU1wfYRBg0wOBEHUH08tOPQI=;
b=LSoRKkMZhaN+OBkk+VSlmxNX2W9FnNWvX/crCWEPtkKwp4CFYZ6+kZJBD85ahT7fVv
CarbrLb8xlx58+Pyxa8o8L1+fnuAJ5V9dV0iK8quynBNY4zyAngnV/O4+yN+fj3ljj3S
gnKpjSv0xcmySv6f3uYf8laKdzEFz2jyzRDBIx0srV1qveuPWcNo1uD/1ZG9Av6HUzgU
1J7D2XNN1Yc26bVYp8rIM+wq5qjzIlqvrbKBdtNci4Fm1PGOAJDNsoZlUrNZgC4kWdTA
ufoP8362La8x6rgp8u4UdTzRexaSrrqqpJNeU17bN6Gk1QaAM98q/6gv8sFuP+q4sauy
MAxQ==
X-Gm-Message-State: AKaTC023/UHsw6aqvE2miLYrHpVbtpZOj5PfGOEDkOk28THv9Rqe9Ta+cHPvTgYApQi8DREvW1+oeM9hbY/PlA==
X-Received: by 10.107.11.161 with SMTP id 33mr42141966iol.210.1480753729106;
Sat, 03 Dec 2016 00:28:49 -0800 (PST)
MIME-Version: 1.0
Received: by 10.64.148.40 with HTTP; Sat, 3 Dec 2016 00:28:28 -0800 (PST)
In-Reply-To: <1480698466-17620-4-git-send-email-tomaszx.kulasek@intel.com>
References: <1480698466-17620-1-git-send-email-tomaszx.kulasek@intel.com>
<1480698466-17620-4-git-send-email-tomaszx.kulasek@intel.com>
From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirqus@gmail.com>
Date: Sat, 3 Dec 2016 09:28:28 +0100
Message-ID: <CAHXqBFKvvV5JjScuoVH=6dE1YUw39RwwwSEQ4sRA=1aGHMQ9QQ@mail.gmail.com>
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Cc: dev@dpdk.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH 3/4] crypto: add sgl support for sw PMDs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Dec 2016 08:28:50 -0000
2016-12-02 18:07 GMT+01:00 Tomasz Kulasek <tomaszx.kulasek@intel.com>:
> This patch introduces RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER feature flag
> informing that selected crypto device supports segmented mbufs natively
> and doesn't need to be coalesced before crypto operation.
>
> While using segmented buffers in crypto devices may have unpredictable
> results, for PMDs which doesn't support it natively, additional check is
> made for debug compilation.
>
[...]
> +#ifdef RTE_LIBRTE_PMD_AESNI_GCM_DEBUG
> + if (!rte_pktmbuf_is_contiguous(ops[i]->sym->m_src) ||
> + (ops[i]->sym->m_dst !=3D NULL &&
> + !rte_pktmbuf_is_contiguous(
> + ops[i]->sym->m_dst))) {
> + ops[i]->status =3D RTE_CRYPTO_OP_STATUS_INVALID_A=
RGS;
> + GCM_LOG_ERR("PMD supports only contiguous mbufs, =
"
> + "op (%p) provides noncontiguous mbuf as "
> + "source/destination buffer.\n", ops[i]);
> + qp->qp_stats.enqueue_err_count++;
> + break;
> + }
> +#endif
[...]
Why are there so many copies of this code?
Best Regards,
Micha=C5=82 Miros=C5=82aw