From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A999CA04FF; Thu, 31 Mar 2022 14:59:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BF7C428F1; Thu, 31 Mar 2022 14:59:17 +0200 (CEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by mails.dpdk.org (Postfix) with ESMTP id 30EA9410FA for ; Thu, 31 Mar 2022 14:59:15 +0200 (CEST) Received: by mail-ed1-f42.google.com with SMTP id a17so28083220edm.9 for ; Thu, 31 Mar 2022 05:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RqxCocDYC2zuds2V8J598GzXDylCqIBW/rqlvindYNs=; b=NnkEB7Y5GjoHF6fx74C4RFSsiC/Vtxqqz0F/Wsjfd9IhfQfB6gw+nD5iHsLqjAFGU0 RdW2L4HjK9OWAi/BFC1MKHGAVpVOOh2fhNNfggensDVWTWmdVcCj9H9sl1R9z4qg/I3U mBFi9oI96CACY0npbknBH0hTf8XgEa5vDA+QazyGdfPVM6DBSEaLU6s5Dn3So+hqqHPo S1KteHg4cQT22etNSWxuFQcYkhzds3tdGrMvB1Ir+J0xbwSbcHLORpu6PJhMgD+nF1Gb QLxi6SYEFkRtQI7H5ysC6m85b9wkvjZlR1a1X5tIfm8j8ZcYoW+R5RJL6v8jDVf8LVd6 GYrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RqxCocDYC2zuds2V8J598GzXDylCqIBW/rqlvindYNs=; b=CJm3/eYa++hwg3nX59QUPJVctPNH7/2Ij7A2zLWDbNm/4+ttkHMOxBScYYuS/665A7 PSMLxR4v+wIu3hBO1wwKR/ex8hnVakDmJtrruK65IBWeG2CfqsdTV9uXCpN4ei6+GlEq B/3uZr0RteAR4z3x0AZwT+cBhzDrcBteRBuYm8DbN+Lbc5KuQttu2q5tEhYGqzGVYN43 kwLnhN2TDFvvO5c+QWR6SqgiCdss9GJp8GtOGWkq9TSxMvrUFkHoo7hspudw4Q3m3iZp HOlGy7C+x3X3q9pDIqwwgE+A/OF3VpcOOyInMN3NoWIhrdZ8hhqIqAZLRb3AYHj7Iuyu elwQ== X-Gm-Message-State: AOAM531YYh4yMvL3z4CO3Nf30oxKJ6DBF4la7heHdl5AuoO3p2M3BV5b Pgj4TuP5MHoSu3n5rXlwLSris1X+2mz/51Xb7tBZIw== X-Google-Smtp-Source: ABdhPJyeE6wCmR7wRJuXo2PrD34z/JXIdCwXfQCHVKtMXiZJZ4qW9STntNJvNqEzPWtYwBkfevoo9LUK+v2z8laSM/M= X-Received: by 2002:a05:6402:3689:b0:419:d380:ddbc with SMTP id ej9-20020a056402368900b00419d380ddbcmr16299051edb.230.1648731554952; Thu, 31 Mar 2022 05:59:14 -0700 (PDT) MIME-Version: 1.0 References: <20220302092614.5164-1-usman.tanveer@emumba.com> <20220302085225.117b8570@hermes.local> In-Reply-To: <20220302085225.117b8570@hermes.local> From: Usman Tanveer Date: Thu, 31 Mar 2022 17:59:03 +0500 Message-ID: Subject: Re: [PATCH] app/pdump: close program if --pdump argument is missing To: Stephen Hemminger Cc: reshma.pattan@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The 20.11 release is not coming out till August, in the meantime, this patch can be applied to print help if mandatory argument is not passed. On Wed, Mar 2, 2022 at 9:52 PM Stephen Hemminger wrote: > > On Wed, 2 Mar 2022 14:26:14 +0500 > "usman.tanveer" wrote: > > > --pdump is a mandatory argument in pdump application. > > It should print usage and exit if --pdump argument > > is missing. The application is not closing and getting > > stuck. Made the change to print usage and exit when > > this argument is missing. > > > > Signed-off-by: usman.tanveer > > Maybe pdump could just do something sane with no arguments. > That is one of the issues I tried to address by rewriting it. > > Ideally, existing pdump can be deprecated and removed in 22.11?