From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8345C42999; Thu, 20 Apr 2023 19:11:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0E7B40EE3; Thu, 20 Apr 2023 19:11:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7E4E440697 for ; Thu, 20 Apr 2023 19:11:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682010714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zuKJffGptAC4UqngbLAqU7rST4IlmQuc5SOuzCw6t9o=; b=N0UGCz3lmDTkMVkxCXUuqiWEydGQzjZQyFFeQYX0WI8HATGevb2QIAUY00lOP1VDerpt54 c9wgezfWtxsMBqTMP7UK6nyRJ7WvdH5RWTJE9QTI/5bUHxHyG1jyEk+DxKv9DwNekQzOef WatoS1eMMlJxF4uafoVeEk/b8PiFFhw= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-XGwe97nPOYKZa5ZZfcNM_A-1; Thu, 20 Apr 2023 13:11:52 -0400 X-MC-Unique: XGwe97nPOYKZa5ZZfcNM_A-1 Received: by mail-ej1-f69.google.com with SMTP id tg11-20020a1709078dcb00b0093460dfa569so1540772ejc.13 for ; Thu, 20 Apr 2023 10:11:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682010711; x=1684602711; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zuKJffGptAC4UqngbLAqU7rST4IlmQuc5SOuzCw6t9o=; b=A7jft7tBrhDklYTmbaaCLqh1P6FyudsjzLTf46X3B+h1yPGcKwlngKr3SBW7TE9k5l 6ySyPVHZtytJvx+ICkOGsgfbaJDVT+kR6d20xCmIGgYU7wXtumQiGb7nTmrGVJIXPrPY Jb1pfHaA20fkdjbVHmsmqFTSQiF23VCdTPoKuugyGLcKHRt2i6VSvzGIG4KSzV/lytw6 1FNzzwkeejrEaS2Bwwc/zdYabfPdEmQIc3tDjdtKxl+Xr3fDfZffAWl+UmonQRrkeu1U KTob1EDPYptjycqb6gcimcNfTcHGNzC59oon1swWYRLysch8PfE4PaIKGFszVD0oDrgG ZfCw== X-Gm-Message-State: AAQBX9eTl0QuCNTCyg5mgMdp0XCrLVbQE21VESs6+HMrKBr5epxcAVax rGXO/La8JHHeVpM+eCaHGGoY3cqsVp/52SxXjC52Kd30iq1Idx5q1CDGuRswakBq78AJ2rNLVWT oiyssiYZtyNYReqgfdzo= X-Received: by 2002:a17:906:64cd:b0:94e:c142:dfb1 with SMTP id p13-20020a17090664cd00b0094ec142dfb1mr2273193ejn.61.1682010711358; Thu, 20 Apr 2023 10:11:51 -0700 (PDT) X-Google-Smtp-Source: AKy350Yf2Xwknc7vMloRh/XQ5MTttIWsHh9Ruvhn/59QowZdedtfMMgYUOsPBK26emgvfxV5X+xfmM8QIHfT1FiqT5s= X-Received: by 2002:a17:906:64cd:b0:94e:c142:dfb1 with SMTP id p13-20020a17090664cd00b0094ec142dfb1mr2273170ejn.61.1682010711040; Thu, 20 Apr 2023 10:11:51 -0700 (PDT) MIME-Version: 1.0 References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-7-maxime.coquelin@redhat.com> In-Reply-To: <20230331154259.1447831-7-maxime.coquelin@redhat.com> From: Mike Pattrick Date: Thu, 20 Apr 2023 13:11:39 -0400 Message-ID: Subject: Re: [RFC 06/27] vhost: don't dump unneeded pages with IOTLB To: Maxime Coquelin Cc: dev@dpdk.org, david.marchand@redhat.com, chenbo.xia@intel.com, fbl@redhat.com, jasowang@redhat.com, cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com, eperezma@redhat.com, amorenoz@redhat.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 31, 2023 at 11:43=E2=80=AFAM Maxime Coquelin wrote: > > On IOTLB entry removal, previous fixes took care of not > marking pages shared with other IOTLB entries as DONTDUMP. > > However, if an IOTLB entry is spanned on multiple pages, > the other pages were kept as DODUMP while they might not > have been shared with other entries, increasing needlessly > the coredump size. > > This patch addresses this issue by excluding only the > shared pages from madvise's DONTDUMP. > > Fixes: dea092d0addb ("vhost: fix madvise arguments alignment") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin Looks good to me. Acked-by: Mike Pattrick