From: Li Feng <fengli@smartx.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] vhost: add sanity check for resubmiting reqs in split ring
Date: Wed, 1 Sep 2021 13:01:16 +0800 [thread overview]
Message-ID: <CAHckoCy0=y=mqwU4L-Oc6JH6VEgrEL3oDmWRe+bYqUpgJs_nww@mail.gmail.com> (raw)
In-Reply-To: <20210827051241.2448098-1-fengli@smartx.com>
ping...
BTW, how could I retrigger the failure CI? The failure is not about this patch.
Thanks,
Feng Li
Li Feng <fengli@smartx.com> 于2021年8月27日周五 下午1:16写道：
>
> When getting reqs from the avail ring, the id may exceed inflight
> queue size. Then the dpdk will crash forever.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> lib/vhost/vhost_user.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 29a4c9af60..f09d0f6a48 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1823,8 +1823,14 @@ vhost_check_queue_inflights_split(struct virtio_net *dev,
> last_io = inflight_split->last_inflight_io;
>
> if (inflight_split->used_idx != used->idx) {
> - inflight_split->desc[last_io].inflight = 0;
> - rte_atomic_thread_fence(__ATOMIC_SEQ_CST);
> + if (unlikely(last_io >= inflight_split->desc_num)) {
> + VHOST_LOG_CONFIG(ERR, "last_inflight_io '%"PRIu16"' exceeds inflight "
> + "queue size (%"PRIu16").\n", last_io,
> + inflight_split->desc_num);
> + } else {
> + inflight_split->desc[last_io].inflight = 0;
> + rte_atomic_thread_fence(__ATOMIC_SEQ_CST);
> + }
> inflight_split->used_idx = used->idx;
> }
>
> --
> 2.31.1
>
Li Feng <fengli@smartx.com> 于2021年8月27日周五 下午1:16写道：
>
> When getting reqs from the avail ring, the id may exceed inflight
> queue size. Then the dpdk will crash forever.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> lib/vhost/vhost_user.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 29a4c9af60..f09d0f6a48 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1823,8 +1823,14 @@ vhost_check_queue_inflights_split(struct virtio_net *dev,
> last_io = inflight_split->last_inflight_io;
>
> if (inflight_split->used_idx != used->idx) {
> - inflight_split->desc[last_io].inflight = 0;
> - rte_atomic_thread_fence(__ATOMIC_SEQ_CST);
> + if (unlikely(last_io >= inflight_split->desc_num)) {
> + VHOST_LOG_CONFIG(ERR, "last_inflight_io '%"PRIu16"' exceeds inflight "
> + "queue size (%"PRIu16").\n", last_io,
> + inflight_split->desc_num);
> + } else {
> + inflight_split->desc[last_io].inflight = 0;
> + rte_atomic_thread_fence(__ATOMIC_SEQ_CST);
> + }
> inflight_split->used_idx = used->idx;
> }
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-09-01 5:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 5:12 Li Feng
2021-09-01 5:01 ` Li Feng [this message]
2021-10-14 8:17 ` Maxime Coquelin
2021-10-14 8:25 ` Maxime Coquelin
2021-10-14 8:28 ` Xia, Chenbo
2021-10-18 1:01 ` Liu, Changpeng
2021-10-14 11:25 ` Li Feng
2021-10-14 11:38 ` Maxime Coquelin
2021-10-14 11:54 ` Li Feng
2021-10-14 12:40 ` [dpdk-dev] [PATCH v2] vhost: add sanity check when operating the " Li Feng
2021-10-15 8:51 ` Maxime Coquelin
2021-10-15 9:25 ` Li Feng
2021-10-21 12:32 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHckoCy0=y=mqwU4L-Oc6JH6VEgrEL3oDmWRe+bYqUpgJs_nww@mail.gmail.com' \
--to=fengli@smartx.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).