Re: [dpdk-dev] [PATCH] eal: add madvise to avoid dump memory

[Li Feng <fengli@smartx.com>]

Add cc dev@dpdk.org

Thanks,

Feng Li

Li Feng <fengli@smartx.com> 于2020年4月20日周一 下午3:04写道：
>
> Avoid dump all mmapped memory to coredump file when crash.
> Otherwise it will very large and it's hard to analyze with gdb.
>
> In my test, it will dump 128GiB memory to coredump file when integrated
> to spdk with default configuration.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
>  lib/librte_eal/common/eal_common_memory.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
> index cc7d54e0c..cc6743d56 100644
> --- a/lib/librte_eal/common/eal_common_memory.c
> +++ b/lib/librte_eal/common/eal_common_memory.c
> @@ -102,6 +102,13 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
>                 if (mapped_addr == MAP_FAILED && allow_shrink)
>                         *size -= page_sz;
>
> +               if (mapped_addr != MAP_FAILED) {
> +                       if (madvise(mapped_addr, map_sz, MADV_DONTDUMP) != 0)
> +                               RTE_LOG(INFO, EAL, "MADV_DONTDUMP advice setting failed.\n");
> +                       RTE_LOG(DEBUG, EAL, "madvise with MADV_DONTDUMP, addr: %p size: %ld\n",
> +                               mapped_addr, (size_t)map_sz);
> +               }
> +
>                 if (mapped_addr != MAP_FAILED && addr_is_hint &&
>                     mapped_addr != requested_addr) {
>                         try++;
> --
> 2.11.0
>

-- 
The SmartX email address is only for business purpose. Any sent message 
that is not related to the business is not authorized or permitted by 
SmartX.
本邮箱为北京志凌海纳科技有限公司（SmartX）工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.