DPDK patches and discussions
 help / color / Atom feed
From: Li Feng <fengli@smartx.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Zhihong Wang <zhihong.wang@intel.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vhost: add config change slave msg support
Date: Thu, 5 Dec 2019 12:01:55 +0800
Message-ID: <CAHckoCyf9k666Ef8fq4QHi-L2gi7Oh9LyAGZsqj7k+mB4qyspQ@mail.gmail.com> (raw)
In-Reply-To: <20191205020703.GA481044@___>

Tiwei Bie <tiwei.bie@intel.com> 于2019年12月5日周四 上午10:06写道:
>
> On Wed, Dec 04, 2019 at 05:43:50PM +0800, Li Feng wrote:
> > Hi Tiwei,
> > Thanks for your reply.
> > Yes, this new API currently is for vhost-user-blk in the SPDK project.
>
> I see. Thanks for the clarification.
> In this case, it should be declared in rte_vhost.h instead
> of vhost_user.h which is an internal header. And the symbol
> should be added to rte_vhost_version.map as well.
>
OK,  one more question, should I add `__rte_experimental` tag before
the declare?

> >
> > There is a patch in SPDK to use this API.
>
> Could you share the link to the SPDK patch?
>
The patch is here:
https://review.gerrithub.io/c/spdk/spdk/+/476704

Thanks.
Feng Li

> Thanks,
> Tiwei
>
> >
> > Thanks,
> >
> > Feng Li
> >
> > Tiwei Bie <tiwei.bie@intel.com> 于2019年12月4日周三 下午5:30写道:
> > >
> > > On Wed, Dec 04, 2019 at 01:13:20PM +0800, Li Feng wrote:
> > > > This msg is used to notify qemu that should get the config of backend.
> > > >
> > > > For example, vhost-user-blk uses this msg to notify guest os the
> > > > compacity of backend has changed.
> > > >
> > > > Signed-off-by: Li Feng <fengli@smartx.com>
> > > > ---
> > > > v2:
> > > > * Fix a little log typo.
> > > >
> > > >  lib/librte_vhost/vhost_user.c | 31 +++++++++++++++++++++++++++++++
> > > >  lib/librte_vhost/vhost_user.h |  2 ++
> > > >  2 files changed, 33 insertions(+)
> > > >
> > > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> > > > index 0cfb8b792..10f2e47d5 100644
> > > > --- a/lib/librte_vhost/vhost_user.c
> > > > +++ b/lib/librte_vhost/vhost_user.c
> > > > @@ -2840,6 +2840,37 @@ vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm)
> > > >       return 0;
> > > >  }
> > > >
> > > > +static int
> > > > +vhost_user_slave_config_change(struct virtio_net *dev)
> > > > +{
> > > > +     int ret;
> > > > +     struct VhostUserMsg msg = {
> > > > +             .request.slave = VHOST_USER_SLAVE_CONFIG_CHANGE_MSG,
> > > > +             .flags = VHOST_USER_VERSION,
> > > > +             .size = 0,
> > > > +     };
> > > > +
> > > > +     ret = send_vhost_message(dev->slave_req_fd, &msg);
> > > > +     if (ret < 0) {
> > > > +             RTE_LOG(ERR, VHOST_CONFIG,
> > > > +                             "Failed to send config change (%d)\n",
> > > > +                             ret);
> > > > +             return ret;
> > > > +     }
> > > > +
> > > > +     return 0;
> > > > +}
> > > > +
> > > > +int
> > > > +rte_vhost_user_slave_config_change(int vid)
> > > > +{
> > > > +     struct virtio_net *dev;
> > > > +     dev = get_device(vid);
> > > > +     if (!dev)
> > > > +             return -ENODEV;
> > > > +     return vhost_user_slave_config_change(dev);
> > > > +}
> > > > +
> > > >  static int vhost_user_slave_set_vring_host_notifier(struct virtio_net *dev,
> > > >                                                   int index, int fd,
> > > >                                                   uint64_t offset,
> > > > diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
> > > > index 6563f7315..5c1bb2138 100644
> > > > --- a/lib/librte_vhost/vhost_user.h
> > > > +++ b/lib/librte_vhost/vhost_user.h
> > > > @@ -62,6 +62,7 @@ typedef enum VhostUserRequest {
> > > >  typedef enum VhostUserSlaveRequest {
> > > >       VHOST_USER_SLAVE_NONE = 0,
> > > >       VHOST_USER_SLAVE_IOTLB_MSG = 1,
> > > > +     VHOST_USER_SLAVE_CONFIG_CHANGE_MSG = 2,
> > > >       VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG = 3,
> > > >       VHOST_USER_SLAVE_MAX
> > > >  } VhostUserSlaveRequest;
> > > > @@ -158,6 +159,7 @@ typedef struct VhostUserMsg {
> > > >  /* vhost_user.c */
> > > >  int vhost_user_msg_handler(int vid, int fd);
> > > >  int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
> > > > +int rte_vhost_user_slave_config_change(int vid);
> > >
> > > This is supposed to be an API for external backends?
> > >
> > > Thanks,
> > > Tiwei
> > >
> > > >
> > > >  /* socket.c */
> > > >  int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
> > > > --
> > > > 2.11.0
> > > >
> > > >
> > > > --
> > > > The SmartX email address is only for business purpose. Any sent message
> > > > that is not related to the business is not authorized or permitted by
> > > > SmartX.
> > > > 本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.
> > > >
> > > >
> >
> > --
> > The SmartX email address is only for business purpose. Any sent message
> > that is not related to the business is not authorized or permitted by
> > SmartX.
> > 本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.
> >
> >

-- 
The SmartX email address is only for business purpose. Any sent message 
that is not related to the business is not authorized or permitted by 
SmartX.
本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.



  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 14:57 [dpdk-dev] [PATCH] " Li Feng
2019-12-04  5:13 ` [dpdk-dev] [PATCH v2] " Li Feng
2019-12-04  9:30   ` Tiwei Bie
2019-12-04  9:43     ` Li Feng
2019-12-05  2:07       ` Tiwei Bie
2019-12-05  4:01         ` Li Feng [this message]
2019-12-05  4:57           ` Tiwei Bie
2019-12-05  5:38 ` [dpdk-dev] [PATCH v3] " Li Feng
2019-12-11  2:58   ` Li Feng
2019-12-16  5:06   ` Tiwei Bie
2019-12-18  6:34     ` Li Feng
2019-12-19  8:54 ` [dpdk-dev] [PATCH v4] " Li Feng
2019-12-20  8:04   ` Tiwei Bie
2019-12-20  8:22 ` [dpdk-dev] [PATCH v5] " Li Feng
2020-01-14 14:57   ` Maxime Coquelin
2020-01-15 11:18   ` Maxime Coquelin
2019-12-04  5:01 [dpdk-dev] [PATCH v2] " Li Feng

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHckoCyf9k666Ef8fq4QHi-L2gi7Oh9LyAGZsqj7k+mB4qyspQ@mail.gmail.com \
    --to=fengli@smartx.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox