From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sbaranoff@gmail.com>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 1FEB81BB23
 for <dev@dpdk.org>; Thu, 26 Oct 2017 19:44:59 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id m72so9484438wmc.1
 for <dev@dpdk.org>; Thu, 26 Oct 2017 10:44:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to;
 bh=5vt5y6NkIY0d1oNTz7Hyr5Of58MUAp7FlA2R1Qe96o8=;
 b=FLIQoxRLMeB2TiWpgMkP7CExufu8KR3f6w5bD0a2DBMzoNEOPKga7zgziEXJihMBbv
 5FS3dO3dn/e/jX3M2sKKdoR9Mr5ZFOYvM+3GmaIyRYvInSxUZE4pjxoOzYX7H+CZ/R5v
 UikVBWASKhyPiSgR9HifKk0gRSPiF7BcttC3YcXHSXmoWGx0A93CXbTrtZFxKfRYgkf1
 kaR+mx/nIibleLXa6eo7TewK4w7OxT08ol0xWQlqG3KZircnmi3uIRXvde9SbDnoQlaa
 szXCcZAceUbynE4Hq0qRSABMBO4jGtIYbLmhSHhr7GvnGaDXFNbEZPj9n8LrLbVdBcMt
 kyHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to;
 bh=5vt5y6NkIY0d1oNTz7Hyr5Of58MUAp7FlA2R1Qe96o8=;
 b=R3bI+3jz8jhARrujWpakuUnuMlHA6N/7schwlJV5QrgoeyEX6bV9biXXQU3QeSjn3x
 8ZoYvFEzjopgw96HWDQuaMGrTUBwj+UmMZPgd4GFlTFM9ZkKe9fnS3rkEnMmpwTu4/N6
 jda+2Ys0uruDQRgettbi3+oCt9VF1UZAzBbgNX+3/ODfDr+a+PxY6JRck0gcDjKlBmUw
 Np9dAJS5pLpMm97BmD4RZrf+EzXvW7nzBSyHf2jwg7o3houo7RO2xw20SwqPt9bG3qe8
 SAO9GOFZmxHRSDlYlSA/QBN+13Do2w0J0gdKH1vkTJzICN8xTYVCD70TEdOvGaJNeFZB
 L8Zg==
X-Gm-Message-State: AMCzsaUzezPIhfTiu452TKI6EVp5Mhzax4t/5fy/9kLTvzQIHbgHj9aT
 A0gQ0kEb7pZ1ADmwPGT6kVqVt45WFzU/Az+faWo=
X-Google-Smtp-Source: ABhQp+SLDkysmoXcuUHF3gJL9cqyaHpT0arLhf73XHfrE9wuyqcN563pAz0MYXW215NORU8ZeLruL9nzw/WxFM5de1Y=
X-Received: by 10.28.144.140 with SMTP id s134mr2403783wmd.82.1509039898534;
 Thu, 26 Oct 2017 10:44:58 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.175.204 with HTTP; Thu, 26 Oct 2017 10:44:58 -0700 (PDT)
In-Reply-To: <CAHzKxpb-d-naP+qJdG6DGa84z+DfcLSJkorH5K-j_+ebquOrDQ@mail.gmail.com>
References: <CAHzKxpb-d-naP+qJdG6DGa84z+DfcLSJkorH5K-j_+ebquOrDQ@mail.gmail.com>
From: Stefan Baranoff <sbaranoff@gmail.com>
Date: Thu, 26 Oct 2017 13:44:58 -0400
Message-ID: <CAHzKxpbykU5YfUbdkjt6s7N9a0d_4tpQJij0ek-yh-TNfVPqSA@mail.gmail.com>
To: dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: [dpdk-dev] Fwd: Memory Leak: PCAP TX to File
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Oct 2017 17:44:59 -0000

All,

I think I've found a (very minor) memory leak in writing to a PCAP file. In
drivers/net/pcap/rte_eth_pcap.c in open_single_tx_pcap around line 405 a
pcap_t is allocated by pcap_open_dead but is never freed.

I see two obvious fixes:
  1) Free the pcap_t immediately after either on pcap_dump_open success or
failure
  2) Set the pcap_t pointer internals->tx_queue[i]->tx->pcap so when the
eth_dev_stop callback happens the pcap_t is freed.

I believe the first is safe but am not a libpcap guru. Can someone please
confirm this?


Thanks,
Stefan