From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 195A3A0562; Tue, 31 Mar 2020 04:13:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C49211C045; Tue, 31 Mar 2020 04:13:04 +0200 (CEST) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by dpdk.org (Postfix) with ESMTP id 1EEBC1C02A for ; Tue, 31 Mar 2020 04:13:03 +0200 (CEST) Received: by mail-oi1-f193.google.com with SMTP id d3so13069920oic.1 for ; Mon, 30 Mar 2020 19:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rB02s+7iJV57QYcDqaim20SkRM1OwNH+vAUBskCDjec=; b=rPoHSTcSogcmeGCnXPesGWABYPYjBdkLj2JmmuHB/vdT1rURg24Czfrf7AJsSxKTek WVcetzwxnOopGlDod5NT5cuhRYlpswaSRxKesH2npUimw+URO6b4LJXo/7ZnG26wp6z5 gvdyzeshWixHxX9EqZB6LeXaH7DGD62CIebx84MXmA/GepVzQqlIYjhLzU0hZqNkGUPV Wkq+Tgi++uHgt1F604rMLWqN+iZT55NUw2BRzHxE2Ip0CiRVbBz8iE8nQ5BFEw/7KLJo iQOHqmZnP1fOnLfxV4+vubrUOI+HOwK8DeKG2vF2HVK52r/PZE+OxO0wv7pEJAeIEw7I spug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rB02s+7iJV57QYcDqaim20SkRM1OwNH+vAUBskCDjec=; b=MVDWb0sL8TgScQJNFWk9vBeyIEAXAXJg1laUyKkOKiHpeK6LWl4cYRYaUHsDZviXJG dz4ocniPy/nrK88ca4eOaCQzpLfHBYx4mqYbeeUWh554ysDYU2lHsndahKL+cdBB5WNL cm1ZYcfnpUnPHMKORFNuE7ExbV0L/tRN0OifmGF0snHd0+TKOvOOu2IohEyWpF7rhaZZ DWeWfIeSH5AmVjB1ZJhpmZltTMG9F9JEvABeU1sCZDLUrJJl8uKkcDEfds/rCXikvDqR PcJnXYIOgGw/ze/sy5Bo97lz5h90hKN1WfwnjS0l6+brJUK6HDeuSlhhfRiTqqJIMh6F OCUA== X-Gm-Message-State: ANhLgQ0Ce+/+4LDbvsFLNZwt1Va1GJ9rvkm+LkkK8YxhX4c1wwgXam1b m36EtArhDz3rgJjjZ5fLL7CDm1zogYJHjhLNy0k= X-Google-Smtp-Source: ADFU+vvvd1w8Wzzj4RTN0tD7nqi/PF1D9D4qLgScEQLJMjA4bsc03Skdj02qdiY7jlS9Qhafo07rLGfnq4incNyvnCY= X-Received: by 2002:aca:4a55:: with SMTP id x82mr730292oia.28.1585620782267; Mon, 30 Mar 2020 19:13:02 -0700 (PDT) MIME-Version: 1.0 References: <1583452940-346826-1-git-send-email-vijay1054@gmail.com> <2216574.9XhxPE3A7Q@xps> In-Reply-To: <2216574.9XhxPE3A7Q@xps> From: vijay mohan Date: Mon, 30 Mar 2020 19:12:51 -0700 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, "Trahe, Fiona" , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/pci: pcidev access from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, As long as pmd or application doesn't access dev->mem_resource[i].addr, secondary process works with igb_uio. But for pci devices like crypto_qat, pmd checks for dev->mem_resource[i].addr and bails out if the address is null. Root cause is, not initializing the mapped address in rte_pcidev when device is exposed through igb_uio. Thanks, Vijay On Mon, 30 Mar 2020 at 18:54, Thomas Monjalon wrote: > > 06/03/2020 13:28, Ferruh Yigit: > > On 3/6/2020 12:02 AM, Vijaya Mohan Guvva wrote: > > > For pci devices presented through igb_uio, pcidev->mem_resource[] is > > > not populated when the device is initialized for secondary process. > > > > > > Initialize pcidev->mem_resource[] with pci-bar mapped addresses. > > > > > > Signed-off-by: Vijaya Mohan Guvva > > > > Reviewed-by: Ferruh Yigit > > Do you mean secondary process never worked with igb_uio? > Or is there a specific case? > What is the root cause? > Should it be backported to stable? > >