From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f53.google.com (mail-vk0-f53.google.com [209.85.213.53]) by dpdk.org (Postfix) with ESMTP id EE675200 for ; Wed, 22 Nov 2017 00:17:51 +0100 (CET) Received: by mail-vk0-f53.google.com with SMTP id l201so8009253vkd.1 for ; Tue, 21 Nov 2017 15:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=il2pzwYqCcjx22XtgT/uG4C1ruvutRGx8cvzdav/5d4=; b=KxTYeEqZFchqFUsgTpvSChY59Jxc7sHdwpqm35Ie6Q6oxqNUP+G4esr+O70YziYyvy WUjlxOLLkUp5S++Kbu0wtrrSBpBa9jkLTPpGM/dZJHX9CciA2V/RuR6CA6D3skNDlE4k j/R/AsXQoaAdaKK1F4gO9vSxHhbbARooOXqFkjEUZs0KaRN17J1m4xmWlU5aCJbVxA3q plG9rI+WwZzX2A0SiNRRjV40dyhOsS2qyY+NTH2yTKrPy5GENvFiwfm9Wp8THxYLRF67 zEQYn+BBknDuP0CmdoJWV+pfs6jF/aM4KsBPHQeoWpFwQAg8j5i9uorMoog35d6L8d8a XCuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=il2pzwYqCcjx22XtgT/uG4C1ruvutRGx8cvzdav/5d4=; b=rU0GOO0fa3sbcMDDcy78ym6ez3br9CZgCU/tYdEvrCtfYZvrDBd6XD+zo/qnXtV3ZN IUn9Yvlo2TfkgCdOFxdbpxeertu8MdGr6MW5qj1CQyLIyem1I8V6Kxa3l7rwBwFRYAdp O1tVyh15mJWK/hw7YNAdre3SWwMiVGrqE94gYD5SWJKUHsif4T/niamSyAunZacvK+Xn q3i9Pv80PTaH1zowx05nLwYaEyd/uvwksF5/gtS206QE4YQD55U3qVW/6Fz5aZOGMZNh yK0BFtHGvfvOFLob23dS1ZzvZnl3HeeQP89dnJ4DaW9YSBVgGUOjrCd/YxMUnxBa9ypG zmqw== X-Gm-Message-State: AJaThX7Dt9bzZ2ZLSQZ6Tp2JjCMdgF2vlT0i3e1da6AXj6v7LwaIkuGZ IRL6kZgwym64v00+DTA8y1+9Em9xiKCknFEEeQY= X-Google-Smtp-Source: AGs4zMaKMx3yJvQikJb7TadOgiy09QkvtICUCT+BgOpx/szoyHAj8udAbzBuh+757XTqXmfAUHYfl5acVH63tCax2AA= X-Received: by 10.31.140.75 with SMTP id o72mr14298585vkd.173.1511306270918; Tue, 21 Nov 2017 15:17:50 -0800 (PST) MIME-Version: 1.0 Sender: keshonok@gmail.com Received: by 10.31.162.85 with HTTP; Tue, 21 Nov 2017 15:17:50 -0800 (PST) In-Reply-To: <20171121223917.21560-1-ferruh.yigit@intel.com> References: <20171121223917.21560-1-ferruh.yigit@intel.com> From: Aleksey Baulin Date: Wed, 22 Nov 2017 02:17:50 +0300 X-Google-Sender-Auth: kTjQlJuUaCinn7Elif7bNJmn_Kw Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] config: sort PMD config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 23:17:52 -0000 Hi Ferruh, Not that it really mattered much, but I couldn't help but notice several irregularities in the order of options that could have been avoided. In particular, I believe it would make sense to put all xxx_DEBUG_xxx options after the real control options, thus making it two classes of options within each group. In the end, I think the regular order of options will be broken sooner or later anyway, as it's something that's highly difficult to enforce. Not everyone has the same feel of the "correct" order. Please see the comments below in the middle of the patch. Thanks, Aleksey. On Wed, Nov 22, 2017 at 1:39 AM, Ferruh Yigit wrote: > No config option changed, added or removed. > Only reshuffle PMD config options mostly to help new PMDs where to put > their new config option. > > Ordered as physical, paravirtual and virtual groups. Alphabetical order > within a group. > > Also tried to group vendor devices together which breaks alphabetical > order in some places. > > Signed-off-by: Ferruh Yigit > --- > config/common_base | 214 ++++++++++++++++++++++++++---- > ----------------------- > 1 file changed, 107 insertions(+), 107 deletions(-) > > diff --git a/config/common_base b/config/common_base > index e74febef4..57a346e30 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -163,6 +163,69 @@ CONFIG_RTE_LIBRTE_PCI_BUS=3Dy > CONFIG_RTE_LIBRTE_VDEV_BUS=3Dy > > # > +# Compile ARK PMD > +# > +CONFIG_RTE_LIBRTE_ARK_PMD=3Dy > +CONFIG_RTE_LIBRTE_ARK_PAD_TX=3Dy > +CONFIG_RTE_LIBRTE_ARK_DEBUG_RX=3Dn > +CONFIG_RTE_LIBRTE_ARK_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS=3Dn > +CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE=3Dn > + > +# > +# Compile burst-oriented Broadcom PMD driver > +# > +CONFIG_RTE_LIBRTE_BNX2X_PMD=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_DEBUG=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_MF_SUPPORT=3Dn > =E2=80=8BI would move=E2=80=8B this option up after the first one (PMD). +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=3Dn > + > +# > +# Compile burst-oriented Broadcom BNXT PMD driver > +# > +CONFIG_RTE_LIBRTE_BNXT_PMD=3Dy > + > +# > +# Compile burst-oriented Chelsio Terminator (CXGBE) PMD > +# > +CONFIG_RTE_LIBRTE_CXGBE_PMD=3Dy > +CONFIG_RTE_LIBRTE_CXGBE_DEBUG=3Dn > +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_REG=3Dn > +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_MBOX=3Dn > +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=3Dn > +CONFIG_RTE_LIBRTE_CXGBE_TPUT=3Dy > =E2=80=8B=E2=80=8BI would move=E2=80=8B this option up after the first one = (PMD). =E2=80=8B > + > +# NXP DPAA Bus > +CONFIG_RTE_LIBRTE_DPAA_BUS=3Dn > +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=3Dn > +CONFIG_RTE_LIBRTE_DPAA_PMD=3Dn > =E2=80=8B=E2=80=8BI would place this option first in this group, for the sa= ke of uniformity. Everywhere else a similar option comes first. =E2=80=8B > + > +# > +# Compile NXP DPAA2 FSL-MC Bus > +# > +CONFIG_RTE_LIBRTE_FSLMC_BUS=3Dn > + > +# > +# Compile Support Libraries for NXP DPAA2 > +# > +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=3Dn > +CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy > + > +# > +# Compile burst-oriented NXP DPAA2 PMD driver > +# > +CONFIG_RTE_LIBRTE_DPAA2_PMD=3Dn > +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=3Dn > +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=3Dn > +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=3Dn > +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=3Dn > + > +# > # Compile burst-oriented Amazon ENA PMD driver > # > CONFIG_RTE_LIBRTE_ENA_PMD=3Dy > @@ -173,6 +236,13 @@ CONFIG_RTE_LIBRTE_ENA_DEBUG_DRIVER=3Dn > CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=3Dn > > # > +# Compile burst-oriented Cisco ENIC PMD driver > +# > +CONFIG_RTE_LIBRTE_ENIC_PMD=3Dy > +CONFIG_RTE_LIBRTE_ENIC_DEBUG=3Dn > +CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW=3Dn > + > +# > # Compile burst-oriented IGB & EM PMD drivers > # > CONFIG_RTE_LIBRTE_EM_PMD=3Dy > @@ -241,49 +311,23 @@ CONFIG_RTE_LIBRTE_MLX5_DEBUG=3Dn > CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=3D8 > > # > -# Compile burst-oriented Broadcom PMD driver > -# > -CONFIG_RTE_LIBRTE_BNX2X_PMD=3Dn > -CONFIG_RTE_LIBRTE_BNX2X_DEBUG=3Dn > -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=3Dn > -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=3Dn > -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_TX=3Dn > -CONFIG_RTE_LIBRTE_BNX2X_MF_SUPPORT=3Dn > -CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=3Dn > - > -# > -# Compile burst-oriented Chelsio Terminator (CXGBE) PMD > -# > -CONFIG_RTE_LIBRTE_CXGBE_PMD=3Dy > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG=3Dn > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_REG=3Dn > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_MBOX=3Dn > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=3Dn > -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=3Dn > -CONFIG_RTE_LIBRTE_CXGBE_TPUT=3Dy > - > -# > -# Compile burst-oriented Cisco ENIC PMD driver > -# > -CONFIG_RTE_LIBRTE_ENIC_PMD=3Dy > -CONFIG_RTE_LIBRTE_ENIC_DEBUG=3Dn > -CONFIG_RTE_LIBRTE_ENIC_DEBUG_FLOW=3Dn > - > -# > # Compile burst-oriented Netronome NFP PMD driver > # > CONFIG_RTE_LIBRTE_NFP_PMD=3Dn > CONFIG_RTE_LIBRTE_NFP_DEBUG=3Dn > > +# QLogic 10G/25G/40G/50G/100G PMD > # > -# Compile Marvell PMD driver > -# > -CONFIG_RTE_LIBRTE_MRVL_PMD=3Dn > - > -# > -# Compile burst-oriented Broadcom BNXT PMD driver > -# > -CONFIG_RTE_LIBRTE_BNXT_PMD=3Dy > +CONFIG_RTE_LIBRTE_QEDE_PMD=3Dy > +CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=3Dn > +CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=3Dn > +CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=3Dn > +CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=3Dn > +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=3Dy > =E2=80=8B=E2=80=8B=E2=80=8BI would move=E2=80=8B this option up after the f= irst one (PMD). Not sure about the option below. Given a lengthy comment to it, perhaps it's best if it stays there. But then, perhaps not. =E2=80=8B > +#Provides abs path/name of the firmware file. > +#Empty string denotes driver will use default firmware > +CONFIG_RTE_LIBRTE_QEDE_FW=3D"" > > # > # Compile burst-oriented Solarflare libefx-based PMD > @@ -292,11 +336,6 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=3Dy > CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG=3Dn > > # > -# Compile SOFTNIC PMD > -# > -CONFIG_RTE_LIBRTE_PMD_SOFTNIC=3Dy > - > -# > # Compile software PMD backed by SZEDATA2 device > # > CONFIG_RTE_LIBRTE_PMD_SZEDATA2=3Dn > @@ -327,11 +366,6 @@ CONFIG_RTE_LIBRTE_LIO_DEBUG_TX=3Dn > CONFIG_RTE_LIBRTE_LIO_DEBUG_MBOX=3Dn > CONFIG_RTE_LIBRTE_LIO_DEBUG_REGS=3Dn > > -# NXP DPAA Bus > -CONFIG_RTE_LIBRTE_DPAA_BUS=3Dn > -CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=3Dn > -CONFIG_RTE_LIBRTE_DPAA_PMD=3Dn > - > # > # Compile burst-oriented Cavium OCTEONTX network PMD driver > # > @@ -343,25 +377,13 @@ CONFIG_RTE_LIBRTE_OCTEONTX_DEBUG_DRIVER=3Dn > CONFIG_RTE_LIBRTE_OCTEONTX_DEBUG_MBOX=3Dn > > # > -# Compile NXP DPAA2 FSL-MC Bus > -# > -CONFIG_RTE_LIBRTE_FSLMC_BUS=3Dn > - > -# > -# Compile Support Libraries for NXP DPAA2 > -# > -CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=3Dn > -CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy > - > -# > -# Compile burst-oriented NXP DPAA2 PMD driver > +# Compile WRS accelerated virtual port (AVP) guest PMD driver > # > -CONFIG_RTE_LIBRTE_DPAA2_PMD=3Dn > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=3Dn > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=3Dn > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=3Dn > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=3Dn > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=3Dn > +CONFIG_RTE_LIBRTE_AVP_PMD=3Dn > +CONFIG_RTE_LIBRTE_AVP_DEBUG_RX=3Dn > +CONFIG_RTE_LIBRTE_AVP_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=3Dy > +CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=3Dn > > # > # Compile burst-oriented VIRTIO PMD driver > @@ -389,16 +411,9 @@ CONFIG_RTE_LIBRTE_VMXNET3_DEBUG_TX_FREE=3Dn > CONFIG_RTE_LIBRTE_VMXNET3_DEBUG_DRIVER=3Dn > > # > -# Compile example software rings based PMD > -# > -CONFIG_RTE_LIBRTE_PMD_RING=3Dy > -CONFIG_RTE_PMD_RING_MAX_RX_RINGS=3D16 > -CONFIG_RTE_PMD_RING_MAX_TX_RINGS=3D16 > - > -# > -# Compile software PMD backed by PCAP files > +# Compile software PMD backed by AF_PACKET sockets (Linux only) > # > -CONFIG_RTE_LIBRTE_PMD_PCAP=3Dn > +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=3Dn > > # > # Compile link bonding PMD library > @@ -407,58 +422,43 @@ CONFIG_RTE_LIBRTE_PMD_BOND=3Dy > CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB=3Dn > CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=3Dn > > -# QLogic 10G/25G/40G/50G/100G PMD > # > -CONFIG_RTE_LIBRTE_QEDE_PMD=3Dy > -CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=3Dn > -CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=3Dn > -CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=3Dn > -CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=3Dn > -CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=3Dn > -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=3Dy > -#Provides abs path/name of the firmware file. > -#Empty string denotes driver will use default firmware > -CONFIG_RTE_LIBRTE_QEDE_FW=3D"" > +# Compile fail-safe PMD > +# > +CONFIG_RTE_LIBRTE_PMD_FAILSAFE=3Dy > > # > -# Compile software PMD backed by AF_PACKET sockets (Linux only) > +# Compile Marvell PMD driver > # > -CONFIG_RTE_LIBRTE_PMD_AF_PACKET=3Dn > +CONFIG_RTE_LIBRTE_MRVL_PMD=3Dn > > # > -# Compile ARK PMD > +# Compile null PMD > # > -CONFIG_RTE_LIBRTE_ARK_PMD=3Dy > -CONFIG_RTE_LIBRTE_ARK_PAD_TX=3Dy > -CONFIG_RTE_LIBRTE_ARK_DEBUG_RX=3Dn > -CONFIG_RTE_LIBRTE_ARK_DEBUG_TX=3Dn > -CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS=3Dn > -CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE=3Dn > +CONFIG_RTE_LIBRTE_PMD_NULL=3Dy > > # > -# Compile WRS accelerated virtual port (AVP) guest PMD driver > +# Compile software PMD backed by PCAP files > # > -CONFIG_RTE_LIBRTE_AVP_PMD=3Dn > -CONFIG_RTE_LIBRTE_AVP_DEBUG_RX=3Dn > -CONFIG_RTE_LIBRTE_AVP_DEBUG_TX=3Dn > -CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=3Dy > -CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=3Dn > +CONFIG_RTE_LIBRTE_PMD_PCAP=3Dn > > # > -# Compile the TAP PMD > -# It is enabled by default for Linux only. > +# Compile example software rings based PMD > # > -CONFIG_RTE_LIBRTE_PMD_TAP=3Dn > +CONFIG_RTE_LIBRTE_PMD_RING=3Dy > +CONFIG_RTE_PMD_RING_MAX_RX_RINGS=3D16 > +CONFIG_RTE_PMD_RING_MAX_TX_RINGS=3D16 > > # > -# Compile null PMD > +# Compile SOFTNIC PMD > # > -CONFIG_RTE_LIBRTE_PMD_NULL=3Dy > +CONFIG_RTE_LIBRTE_PMD_SOFTNIC=3Dy > > # > -# Compile fail-safe PMD > +# Compile the TAP PMD > +# It is enabled by default for Linux only. > # > -CONFIG_RTE_LIBRTE_PMD_FAILSAFE=3Dy > +CONFIG_RTE_LIBRTE_PMD_TAP=3Dn > > # > # Do prefetch of packet data within PMD driver receive function > -- > 2.13.6 > > --=20 Aleksey Baulin