Re: [dpdk-dev] Intel X710, DPDK with SFP - FTLX8574D3BCV-IT link down

[amit shukla <amitshukla19@gmail.com>]

Hello,

The below patch works for me. With the below patch on 1st retry attempt
i40e_aq_get_phy_capabilities returns success.

diff --git a/dpdk-17.05/drivers/net/i40e/i40e_ethdev.c
b/dpdk-17.05/drivers/net/i40e/i40e_ethdev.c
index e9185c44bc..e79fa80854 100644
--- a/dpdk-17.05/drivers/net/i40e/i40e_ethdev.c
+++ b/dpdk-17.05/drivers/net/i40e/i40e_ethdev.c
@@ -1822,12 +1822,27 @@ i40e_phy_conf_link(struct i40e_hw *hw,
                        I40E_LINK_SPEED_1GB |
                        I40E_LINK_SPEED_100MB;
        int ret = -ENOTSUP;
-
+       int retries = 0;

        status = i40e_aq_get_phy_capabilities(hw, false, false, &phy_ab,
                                              NULL);
-       if (status)
-               return ret;
+
+       while (status) {
+               retries++;
+               rte_delay_us(5000);
+               if (retries < 4) {
+                       status = i40e_aq_get_phy_capabilities(hw, false,
+                                       false, &phy_ab, NULL);
+               }
+               else {
+                       return ret;
+               }
+       }


Please suggest.

If the patch is okay, will start the process of submitting it.

Thanks and Regards,
Amit


On Tue, Nov 19, 2019 at 2:03 PM amit shukla <amitshukla19@gmail.com> wrote:

> Adding Beilei Xing and Qi Zhang
>
> Thanks and Regards,
> Amit
>
> On Mon, Nov 18, 2019 at 2:39 PM amit shukla <amitshukla19@gmail.com>
> wrote:
>
>> Hello,
>>
>> Using a X710 based NIC with Intel SFP - FTLX8574D3BCV-IT on a bare-metal
>> setup, I came across the following issue on the i40e PMD:
>>
>> When Intel SFP - FTLX8574D3BCV-IT is used, link does not come up on
>> executing link down and up commands in quick succession. It shows
>> "NO-CARRIER" in ip link show.
>>
>> #ip link set dev eth0 down; ip link set dev eth0 up
>> #
>> # ip link show dev eth0
>> 304: eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast
>> state DOWN mode DEFAULT group default qlen 1000
>> link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
>>
>> On the 1st command, ip link set dev eth0 down,
>> i40e_aq_get_phy_capabilities returns success but for next command (ip link
>> set dev eth0 up) it returns I40E_ERR_UNKNOWN_PHY (-7).
>>
>> If  link down and up commands are executed with a sleep of 1 second
>> in-between them, then issue is not observed.
>>
>> Intel(R) Xeon(R) CPU E5-2637 v3 @ 3.50GHz
>> DPDK - 17.05
>> NIC firmware-version: 4.53 0x80001e5b 17.0.12
>> 05:00.0 Ethernet controller: Intel Corporation Ethernet Controller X710
>> for 10GbE SFP+ (rev 02)
>>         Subsystem: Intel Corporation Ethernet 10G 2P X710 Adapter
>>
>> Thanks and Regards,
>> Amit Shukla
>>
>