From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20040.outbound.protection.outlook.com [40.107.2.40]) by dpdk.org (Postfix) with ESMTP id DD194AAEA for ; Fri, 23 Mar 2018 08:20:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BaeTi88VaRK6RysJ5EmAEjoy0me9xRqzGllZAJrseyk=; b=Ip7Y/4FVeR/mHEalsDxXBKwcTMNQKBN2+c5CDdUK4n/EmWHeYVSk3GoDPJam8EZdo4AkjHhwDGHMrYILY1AjtCP+r1o+1/m9L+3yfImZFeS1QlRi5S47m8C7OcExKbKZ33+mrjmVYDXzuiqexHJki8Nn0KNFhSFkdNmH7EZ4Mmw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from mail-wm0-f49.google.com (74.125.82.49) by HE1PR0402MB2780.eurprd04.prod.outlook.com (2603:10a6:3:d4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Fri, 23 Mar 2018 07:20:31 +0000 Received: by mail-wm0-f49.google.com with SMTP id e194so1701871wmd.3 for ; Fri, 23 Mar 2018 00:20:31 -0700 (PDT) X-Gm-Message-State: AElRT7F7UMRy1l1MaEszRP+WUfqeDxXcOrtrX0Sli2Rnw07XilbV49v2 uBde/brF8kH1Z1iMfCVb5bYqnGVua1FE1hhbRqQ= X-Google-Smtp-Source: AG47ELvKeOM4EnEl/po6B7YQGL5OAS3oHhkZD4c2ASh46toFYhvnDxEzw1rhti/DcKK+Ac3rHvWXT0f/Gc98IRM+k/A= X-Received: by 10.28.13.142 with SMTP id 136mr8237204wmn.95.1521789627198; Fri, 23 Mar 2018 00:20:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.50.67 with HTTP; Fri, 23 Mar 2018 00:19:56 -0700 (PDT) In-Reply-To: <3c88da66-fb3b-e41c-471a-812f115c792f@codeaurora.org> References: <20180312092547.18472-1-shreyansh.jain@nxp.com> <20180313054431.19556-1-shreyansh.jain@nxp.com> <20180313054431.19556-4-shreyansh.jain@nxp.com> <3c88da66-fb3b-e41c-471a-812f115c792f@codeaurora.org> From: Shreyansh Jain Date: Fri, 23 Mar 2018 12:49:56 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Hemant Agrawal Cc: Ferruh Yigit , dev@dpdk.org, Hemant Agrawal , nipun.gupta@nxp.com, akhil.goyal@nxp.com Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [74.125.82.49] X-ClientProxiedBy: VI1P195CA0004.EURP195.PROD.OUTLOOK.COM (2603:10a6:800:d0::14) To HE1PR0402MB2780.eurprd04.prod.outlook.com (2603:10a6:3:d4::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7488b115-848c-4688-05e9-08d5908e8fc5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2780; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 3:bb5G/riU3dmAH95PeL8GaA9P56OFsQLZia9mdROdpXlKOZN2AYPRh66jpG2Xx63RS/52D0y+rQ0HMCMJqdR6zBJi+ET5y8L8d3fouKxACY+qIYbDpY+HwPHPlmf52oLfOS5PtnOV05I5bNB2akypDO9F+KNQMqTdfeqzsyiasjXvFK86aShk/H/Lao0EVX41GkK6IbR3kO7v7+wFp6bU+qHJmUui8BMNlDNTp0BvImTqdwwzxJJXg/ZSWwFVJBZ6; 25:MB5u02E/U3mm+clNHRMM5FWk/EJKaHeJee1YsuBsj+GlTQdSKIw3ITJCVnjiZ73smPBOn0v2XZAeH32CHAIfFad6igj7eNbFnAzgt69j1nzdPQwHb+hm+Hu9JN64v5bSRRoPlaLT++laBIfyQ/MBK3Xo7P5Uki3Gj1g/opXWloVBev3s1V1Yxadv4cY6N+CxUjqjSYnR3GA/S5nWvh1sPihcFyNwr+727yRB2zjdlrGkcT+7H7z2fN59DBSuBmSNxSGtaEuvECVkgx3am8lCOZXrZhCw2Oi3p0I34wG6enNiIlyNzUbO/iGry6PHdpu8WYveUvmCMUqlG/Cp/fMrnQ==; 31:ieorno+cBGBELaa8fux78yTa1TgJmiOgnK/m39TJo5vOs3BPAk0Q6DcY455p1eDpzVlLb7+M6Lb12D80+0GTgm5aZoWaF84ticz+EV4ekMbVG06w3ANZHMcTIM8mEr2kYVr18fIweaq0APV+QnLj0FVn9WOaLxIpQvrgM/yWhHCFUxzUotUkZ8YEi5EYjCT3CzCXrXoYqvbMIg7UGyqBWT8Px88xOzFya9qRnMvUiIc= X-MS-TrafficTypeDiagnostic: HE1PR0402MB2780: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 20:HYY9vfn9exqekZfjLvLKEemeVFpdeUC4M7wI85rr3b5bzcZBLDUi7BVxor5Al7IHwm19MjS4L3HlYlF82itqUVlkNG1ZMxvUQJWN2YRLa/CjWBYB3vP0+zZN3s8AAp4FBXBtUls1N0D4OzdRDCs9PHgeFQtfPsEexWSNgKOUAZjaT12/mCKHKUeZ+EWv90sjV0nGEu8TUR+pCYDFMHATmHaNQ3SP6Rd6fRN5alRh27BmaFU0Kgeov2bsGaS9KkOeGPhMYhw3kpIuKUGd/cGsSj0KLSDQZXhwyUmo0fgdNl9Nm2juXaUDhN+1N3cemUiffn5aExa5pEliftvwag4M2oJNNwvUTIrwt31fY9HWrhH/CUg8p+LlNSNVAdN0W/PMWxEtLaON5bKLMXtVmmMXMAE99qFoWwySJUcI55nJFSgYYPRcHdpq1zY0mBNfl/zSR360SLenhYBqc0P1r5X8yqyGXYkUU56lskAlDFfnpA2LgjfTABNCAH3uw0sRMWaR; 4:xgCBdDfCYmj5XoOh+w24DOVwnEqFXcOFXzink+z91DghyDcGfgIm3Zt0GoPLg5aE0CUeH7j+mZalLDT5J3w3uw6aKVHOsEzg2AMqIlhf2XSFV0b4XuXn18zxWWXFsNVd+k14OqmozTl7M8JRT730EBa4Szv9KsW34jB0PX7WuXYMcLowgf+RywogLfNBvu9LCK+9wH3DzAoGDq+2Xdg1XRG8ZB1nbGibOijuw0LiIjpiWl1CLXkej2P0f0cYpZqYqdvbq7FESgwCc7X8WJYl1O1vu/P9wmI86IjYRI4G9j8LdOrZ/qlyEAhIT0g+zmo7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0402MB2780; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2780; X-Forefront-PRVS: 0620CADDF3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(366004)(346002)(376002)(39380400002)(199004)(189003)(97736004)(47776003)(61266001)(69596002)(66066001)(5890100001)(5660300001)(5820100001)(478600001)(498394004)(26005)(52116002)(16586007)(76176011)(186003)(446003)(59450400001)(33896004)(2906002)(93516011)(23676004)(50466002)(3846002)(61726006)(386003)(53546011)(95326003)(6116002)(9896002)(8676002)(8936002)(42186006)(86362001)(316002)(7736002)(93886005)(9686003)(53936002)(81166006)(68736007)(4326008)(55446002)(98316002)(6246003)(106356001)(54906003)(122856001)(81156014)(229853002)(105586002)(55236004)(305945005)(6862004)(11346002)(55456009); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2780; H:mail-wm0-f49.google.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA0MDJNQjI3ODA7MjM6MXR1c1pUTnhWeHMyZnZHV0VQanUzYUtl?= =?utf-8?B?a3VILzBYRGFTeUxScFRhbHhjK2htcmI2R1FHUzI5T3dON2l3d1pQWnFYT2xz?= =?utf-8?B?c2xvK2tsR3dKZTBkZ0tHYk1SQjdkak9Wc3lQQUl5L21pK2kvbHNrMng2YWpy?= =?utf-8?B?amhVQzR2VGM0b1QvMTlJdU44dk96ODJqeklRdy9KbGl6VU9keXZUdEdKQVVq?= =?utf-8?B?S0QvNUNPam43U3JvNldDdzhtbUZuUzhxeGg3RlhMV0lSakhpTEZkd05LREhS?= =?utf-8?B?c0RGUHZ4YjVVVVFGWGdsNzlUV3BKSjViRXpodXNHL0RkTG9CdWx4RmU4dWhJ?= =?utf-8?B?a0VESlpmTUlmVXBJUkZRRHU4ZEtCc1dORFJIdkJnWGgxSHZ5c0I3enBmTmpy?= =?utf-8?B?WUJ0V3pTT3g2ZmFzOE1uZUgxR0FXK3lsMkVIenhGUWJUb3Z5T3AzdEVwcE5M?= =?utf-8?B?VFYzR2FNcVNkbjBwMzFqN0V3MHpicldILzJlNEZtQTBpcE94ZXlmMWpTTjVn?= =?utf-8?B?ZmxnVFJhVXNNMXRWbVJ0WDBpeWk3OEZDcVg5azRFdjFVdTVocVptTHB2Tllu?= =?utf-8?B?SlV4NWo0MzRoZm9HS25laFJrMWJkUUlhUXJ5UmhleE5CVnVJNFZkRUk4Q3Ur?= =?utf-8?B?cFJmeUprbldDVmhkSmNGZkNtYyt6VTlwYnBsRmlJSC9PMkpMSVh2YUJKVCtW?= =?utf-8?B?bVhCZzRTMmZQdzA0NlBSUyt6SkRxZWdhQlBPY2NueEdDdzVrOFNwNnpFQkR5?= =?utf-8?B?OHZxSEc0ZFdTaG5rdGsxci9paUM0V0J4VElFdkx4eUY2UnJNaG1RVm82V21z?= =?utf-8?B?MzdXUjZyNGFHL2NDZUczdUt5YW1wMkpuZ2dzK0t1cXZlVHdrcFRmUmJDQTFu?= =?utf-8?B?TUN1OUZVV0puRWtFVWZsdnRMcC9haEJibHIrd21LOWM1VFltYkFHTVlOVnZi?= =?utf-8?B?QXVtdzN0a25OUlNLTEVwZjF5bTR6RnRjZVJoOXFNYTdlSHVqM28xUE9rcSta?= =?utf-8?B?aDFnNnNxWHRRL1o5UCtuaHl6aHIzbEtibDdQdzhJRUNwSzNQYi8zdnJad1Zz?= =?utf-8?B?QkpuSTkxT0o2VFpYdC9weWJicXZOSWw3ZmlxeTFrMzlLZTlkbmlxV2ZTVHlh?= =?utf-8?B?MW9VZTN4NCt6QnRjODFLYkkvS3dIU3B0amVnZVdVaXFMT0xRS2FLMkxXbE5J?= =?utf-8?B?eWEzZU9HNW1kdjhJbG1Lc3ZFM2h4TGwyVXh3SFI4ZnhTUDQ3alpSTjE1Q29t?= =?utf-8?B?dmNqUWlzSlRvQ0xkMDRaUDAxS2tCa0gxOGxtZGdyWUMxRVdMaGVEd1BFa1da?= =?utf-8?B?TXpBVmY1UHFRZFgzVTlteit5L3lPdlRJbS8yVnJLeldGLzBTeGVPL3JWYjhu?= =?utf-8?B?WXVVTHZzc25qTHRCc1RTQXN2T2JWYjR0aHd5NnphdDgyRi9FK0pPOHFHQ3dy?= =?utf-8?B?VUZIZkI2UGNGakVTeEsyVkNwT1haMVFtK1JjbFRlWWFQMVVybjNjV1VKTXR1?= =?utf-8?B?RjdSZVR6bXlWOTJsT1M3QnNoY0w0ZUdOMXcwQzk5azA5UjZkZWgrWlhYYW9y?= =?utf-8?B?anlUVnBqam5mbUVMZm5NUTl6OFdsa3pQY1RhQmd5Rmc4a0JDc1NPRC9BYWIx?= =?utf-8?B?dnRmeENyZWxWTjhsYUZnb2Z2b1hkNkNjZmNYcmhPN0s4a1JhTDg2aFVOOUFR?= =?utf-8?B?L0RoMWJmYXdzUDhmcmlnTUx5OFFwM0RCa1haQkg4by9LU0Y5L3hvaWdwNWlm?= =?utf-8?B?anVsNDhiWjlEK1RNRjFuYm9tUGFMTTJ5ZmUxZmdQendYNzVydkdkOERaRllm?= =?utf-8?B?K21qTmVBRS90aXlIeEsyVldablEwUEtaeTRrYVZvbVMvWFNWR1Y5VDJYTHQx?= =?utf-8?B?TEdvdzhPWVJlOGhCWnpmMEZ2TzZGQi9KLzFiSXhqRkZOSVpSMEwvNGxVNmJ0?= =?utf-8?Q?JDucg6psgcekeZ7RWFlohO+qtjvVj91w=3D?= X-Microsoft-Antispam-Message-Info: cC9WR2KX1ATARocR649jjeBewzmmlvtebIUM4X5W79T7bgE7mQ74yLwzfogqwPADRl9yzc5wTx628q+SsHHyNRgTv8X9TKhT2Uu0sV9exn16D83GJ1Izv2qbJzXd4cgBVTB/m8cBFwlutQc2Zi+3Eh9z90JyTJ/Xp4dNfEbq0OrZVXBDm+5rhzVZpqr2Bcx1 X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 6:wcSRnLdwclNCBQ6K6WdOEa8w4qHjMp8V5QBghui7W49l0AjKLcCdx5DWaWR1t+n4qkvJL0u5+/bjT0Z+XeGS1LR05TAenxYDv1e/cNwgqmXrOzyk/3aU9R5SZ7nFUBiNsS2d/g5lLUdADMrLhsbqANBKTqTq8dEcDjnL+lZ8Z9paQcZ6n07A0NXGe8rDOPJdOzPK51r3JoY/6Upgcu1nfZMKax20bueqq30zoV9vbKVkunjAKsiCjjagYIxQ+CdS8CZJRbldR3yiW7taUEkx5eBASv5fuIpceziyl6sCWPAzqHEbgc+ZDyD1qg51vN19a1DvyMocJrpBRaSyQwpLU2ZHqfXU49h5yhfhieTPYs0=; 5:TJbgV0bNitMxW0sjyFqPF945dEw9grCags1aicH8vFPejtii4cMTX0odLm/t+UgHF9E2mm/kV2zQTzvyvpR9M5DHpmTY0nTQEprdNNubQxIctFLxqmsGf/1Fit88+panJ+sukuYOC9rhOW55o80r+/qitfuxszJYKuYSQLEK3Qk=; 24:UNlvTSDQSarTuxaY8/YZYJJdPs62wlajXAOwBvhqT1swvXg6VNlDKQi8YmlUdY/kGuK8A4GI4RY7zzeWpl2Clydm5j6eSVx0kNrNxWQA7aM=; 7:/kL1RDvwTou+M+POuWdEsA8Vfrpgkp38nfG4QFtnZ80onS8Rn/H0YsIZJ4Z9+nTlMQzjVutU4psujNgBUc9kvxcPYl4wcA638zwtVMXIpipjyyOHnLE1NhDlF9Zdhctm7H8vyVorzTMeI2cY5clp8FbBHbB8zh16Gdx4hWpTs/pjbNJiNuWMW4ne31dMWcHqRhGSwssNIlQI5klGbN6Pgfzei5sXsM54zr431qgY8KCwXEimATfYiPO4LuPIpsyR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2018 07:20:31.4602 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7488b115-848c-4688-05e9-08d5908e8fc5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2780 Subject: Re: [dpdk-dev] [RESEND v2 3/7] net/dpaa2: change into dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 07:20:33 -0000 On Wed, Mar 21, 2018 at 12:01 PM, Hemant Agrawal wrote: > Hi Shreyansh, > > On 3/13/2018 11:14 AM, Shreyansh Jain wrote: >> >> Signed-off-by: Shreyansh Jain >> --- >> config/common_base | 5 - >> config/defconfig_arm64-dpaa2-linuxapp-gcc | 9 - >> doc/guides/nics/dpaa2.rst | 44 ++--- >> drivers/net/dpaa2/Makefile | 6 - >> drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 30 ++-- >> drivers/net/dpaa2/dpaa2_ethdev.c | 290 >> +++++++++++++++--------------- >> drivers/net/dpaa2/dpaa2_pmd_logs.h | 41 +++++ >> drivers/net/dpaa2/dpaa2_rxtx.c | 59 +++--- >> 8 files changed, 258 insertions(+), 226 deletions(-) >> create mode 100644 drivers/net/dpaa2/dpaa2_pmd_logs.h >> >> diff --git a/config/common_base b/config/common_base >> index ad03cf433..64bdfbb73 100644 >> --- a/config/common_base >> +++ b/config/common_base >> @@ -188,11 +188,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y >> # Compile burst-oriented NXP DPAA2 PMD driver >> # >> CONFIG_RTE_LIBRTE_DPAA2_PMD=n >> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n >> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n > > See the comment in PATCH 2/7 w.r.t usages of DEBUG_DRIVER macro. >> >> @@ -322,9 +322,9 @@ dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv, >> retcode = dpni_set_pools(dpni, CMD_PRI_LOW, priv->token, >> &bpool_cfg); >> if (retcode != 0) { >> - PMD_INIT_LOG(ERR, "Error in attaching the buffer pool >> list" >> - " bpid = %d Error code = %d\n", >> - bpool_cfg.pools[0].dpbp_id, retcode); >> + DPAA2_PMD_ERR("Error configuring buffer pool on >> interface." >> + " bpid = %d error code = %d", >> + bpool_cfg.pools[0].dpbp_id, retcode); > > Can you try to convert this and others into a single line message? Actually, the main debug string is a single line itself. It is the variables which are being printed that have been shifted to new line. That way, a developer can easy search through the code using the error context (ignoring the values printed). Unfortunately, at this point the indentation is too much to have a long string with 80 character limit restriction. I will push a v3 with all other comments fixed. If you still have second thoughts about this, I will quickly spin-up a v4. - Shreyansh