From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30053.outbound.protection.outlook.com [40.107.3.53]) by dpdk.org (Postfix) with ESMTP id 41866DE3 for ; Tue, 6 Mar 2018 08:22:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rVyLG9MUknhd4kzvoCn2GNocqXRfXdICnSmNTtCJ6NQ=; b=CY5TrG8KgHGbOnVKRh1D6sgd+pFPrC48JBDdhLj0qMmhZAeruotrdTInbM+njlEM31SVgBoeYVsJnxffkN3K6HstpO+7PuOuQiRJYB4u2HtTPCGBT/nEQ1xeMoiyyOhqTcqkQKRhbq7qTbtBJDC4nAJqC24wqfoqoQy3f6rx6lE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from mail-wm0-f45.google.com (74.125.82.45) by VI1PR0402MB2784.eurprd04.prod.outlook.com (2603:10a6:800:ad::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Tue, 6 Mar 2018 07:22:13 +0000 Received: by mail-wm0-f45.google.com with SMTP id e194so1659410wmd.3 for ; Mon, 05 Mar 2018 23:22:12 -0800 (PST) X-Gm-Message-State: AElRT7HxKrdSltr9HKaDTVb16z0m9lzYjBNFwBQjtlcvEOnjOfxOpnwn miVG4PD4jFAO4+IAidH6qCIgz98XlCEfRDrYNfE= X-Google-Smtp-Source: AG47ELuhNehfHOmTPOYhUfguuTkyC2kX7q1U8PUbSFkz/1l4OJqQ40jJZJX/kbR4CmmVOKdBoCrsSJdbTBIQaUAUzoY= X-Received: by 10.28.26.202 with SMTP id a193mr10822321wma.138.1520320923531; Mon, 05 Mar 2018 23:22:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.135.130 with HTTP; Mon, 5 Mar 2018 23:21:33 -0800 (PST) In-Reply-To: References: <1520300638-134954-1-git-send-email-rosen.xu@intel.com> <1520300638-134954-5-git-send-email-rosen.xu@intel.com> From: Shreyansh Jain Date: Tue, 6 Mar 2018 12:51:33 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Rosen Xu Cc: dev@dpdk.org, declan.doherty@intel.com, tianfei.zhang@intel.com Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [74.125.82.45] X-ClientProxiedBy: VI1P194CA0016.EURP194.PROD.OUTLOOK.COM (2603:10a6:800:be::26) To VI1PR0402MB2784.eurprd04.prod.outlook.com (2603:10a6:800:ad::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 47a095a3-3e5c-4c48-50a0-08d58332fb55 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB2784; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2784; 3:4iRWLbNkXBSMmH1uwAFVBJuEw4ul4feHZVrfJCW9QTVcKUCo8v3ypJitsZL4mJf5YFU88xSzlL8h+ktkYNai6v8zTnXtyoElvA8vtXJVgpVrhE4aB1KoLUDttIdS/VNxsvXp+fsNOfYzl2SnQpe1wHWFJWozelrBAjJ3UV8D8I/be8XHtbLE1Hw4+A20xNT50kQHfjfyTViQauGIJdHr3w1D2BpJ7mkxewglx/B8rftqoO18ofXpyH2J2UZFmkBi; 25:PDNpHQ6XecGdoS9s8p2JAzOBjMTS+/S+71N7EsT77z6xFoMH1PJLVnZP/Y0nMxIDCoX6H/dr1YC0z6aKUbyhVdH8SC+ak91geTVJpYr8DrOEb7uunzodRTN9W68v+TgxHWT4V7o+qEGkNta0P/Hntpq+buPalaplS5YoYoPIuTM3oHKsA+97gc/vmACQT0dFCrC8XLARezuB9/sbVmJijSn+cv74sYwSY8vBYRgqsh9xV1jNZBmSclpTPjsEa5UTfYgZrDd2mxK99SOrQ+C9tt4JqV+gUog26joPlDSgzAuc6HuOabE0JBLuFcNGjTul/NEXgjL/ZlK+6DR/b07PVg==; 31:E8olI6+bymQIEgnpg1sa5drB3/6afyxGAQOzQcCTJMuwYh6ITlO+qqDB7GkMUyYPGH9hoTBuw6xHWjdROyutb9q3xrT/BQZad2QzkfBo2CfI4cbGRVlmuwR78Ojd/T2/MpYAEUpnCxsY7qNuMqCEzqPFT9NeERCFcr5Yxw2yMlXHg5wf6VxA5TRwGTAnKk8+GV/hPzemLpoY5HOvqVdARwb7gnOw6EqLKCdd8pPv6C8= X-MS-TrafficTypeDiagnostic: VI1PR0402MB2784: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2784; 20:/2T2vNO1GrA53E+8piu+BtM4zBzrD7uVa6s9uIXFFbTj2MQQWXPZyWCJoTGHrWdK8oeeSPzQ3eDFb+KATTK43exmPSXyNSlfzS3fuyL0eYvl+0zCJrc5rldASp8x3+OjhWYHfkGUglrqfHvMXEoV2kP8etAZBialDWyZiFSojFzBrWA0Z9oxXpdq10EGfrCUsB0rsJTOjp3eoM7hETwlKeHTvLxoPv4/5jGgYhEDFblXHt46e8/GOJuZsH2OfmYZiit/crJ5+Nqm94oNbX4DQoNQvVdCeJDBxke7AlwizKjz04M8e2GUfaIDnueQv9aicJGJ7Fsc5VJutl5KTW2KumPluVms6WM+Rk0EkrDNlL/TfwuHdg3oJ+b+na68XsTC7XlhlS9EvIvrFBxOB/Be1IK0LYym20a5BOPQPFkjd6lltNsiOWrxmaUFB3XWwZLMFxrO6POu9pwjwcLjQangYTvVXFkWrHxeFeO836K0moNHC+ug3lyC+qjT9KMzLcM5; 4:4LrZLgqFhpmWXTFo+CQ+HMHFzxPdVqOMaBuN6G4j4qO9aXjtbiip5cvkztmpgYizwAIV39lU0n2h4AtGQVrRV/wEAJ+s2NoI5pxeGUPBp2FZ7yBLTPKpkgsIXNLzElrtzGeJoEJbilWvYuuYoDNDSUm/rW08ZTyHwaBWA8a6qy12IaxFqM0Awx5Mgzush7YE1vZBPGimesybZ8NsaikbZj5ejELyTQ1GGSKol4Yv8RQhyr45gfz35r5/3hT03bdsuDOIeb0KI/Gyv6OkfBzpRV/q9NAlyjqOZDvTRbG4winapgo4AxPNVcoMNxjWuh3wtWZ8nT7dYC0HViF6PIHeNgUyaLNy9+TB+I01v5KrUB0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231220)(944501244)(52105095)(6055026)(6041288)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR0402MB2784; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB2784; X-Forefront-PRVS: 06036BD506 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(39380400002)(346002)(396003)(376002)(199004)(189003)(16586007)(26005)(52116002)(23676004)(81166006)(305945005)(122856001)(107886003)(76176011)(8676002)(81156014)(386003)(69596002)(8936002)(105586002)(86362001)(53546011)(42186006)(68736007)(478600001)(229853002)(66066001)(33896004)(7736002)(93516011)(50466002)(98316002)(47776003)(186003)(55236004)(4326008)(316002)(55446002)(2906002)(95326003)(61266001)(5820100001)(498394004)(6116002)(106356001)(3846002)(6862004)(6246003)(9686003)(97736004)(53936002)(9896002)(5660300001)(2950100002)(61726006)(55456009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB2784; H:mail-wm0-f45.google.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0MDJNQjI3ODQ7MjM6eUxjbDd0Y2xzQ1Z2TWlTbjdBVUczNk1I?= =?utf-8?B?TzVWNDBBUFlaSEJzTUltQjN2Q3FYWDkxNVB0RU81a25nTmhNbitOSlNXZmYx?= =?utf-8?B?OCttYVAvN3NETlFJblBOZkl5NVZnN2w2dTFDRy9jZHB6Z0F1dWpHaHBSYXpl?= =?utf-8?B?L2xiblllTWlVM1U5am5CNlV1b2pFb2hYTjkxQ05WaU1KNXQyRjZkQndYU0wy?= =?utf-8?B?QzN3ZVk3Y2s0TUxLeTdtNFVaOGJEUUREM1BIcXRPT2pwMThOUU1ZaVVhbWN5?= =?utf-8?B?QkRlZlZneWRyT1RucDJFbDFHZGpXSG5kOEwrQ2gyMkxUM0JUYkN6eGg1b0Qv?= =?utf-8?B?WFB6a1lLQktsZ05jOGhDdE85dHZoU2FWTDFYYmlvdjBpR29WNmhDaTduZGxk?= =?utf-8?B?SEIxV2lkTGt4QnAzbTEvS2JudEZjNnZ0VXdESEJoakgrRmduZERVekM0cWJn?= =?utf-8?B?c0hkUTc2UXdSNWgzK1FzeTFBSE9Mc3cxcTEwT0t5K25idGZITjYreTVUZHBG?= =?utf-8?B?L1krRGJ6Q0lVUkg1NkdvVjN0SnFpUmg4ZEdmK0RlZzdqYzg2dTFhM2lERVY4?= =?utf-8?B?azNaNTFtUTVpam9VTnRPRXJWZGJVTEV5SzB5RE9EeFptOE1aSWVyVklydlkw?= =?utf-8?B?RVk5UTh6aDdnYVhPWUowbVhpNnA5SGFoY1JCRS9RR0JaNEFVZ1pvcTUrcnFU?= =?utf-8?B?dWlNcldETE1Cd2pPK25uMXQxUlRqKzBRbnVkNHd1RVFUaTRjd3hadHJIRFN6?= =?utf-8?B?RHhBL1FMY2lTRXNtQmxSWmt4cmlVYmJpUERTcmpTdzVwcS9TYjRlVDZVZktu?= =?utf-8?B?ZkpaY2FTSHZMVHppaVZSNVV4U1poU3UxOGFQZm9hSGpqV2oxSFlVNkZOdXdy?= =?utf-8?B?RTFvc2hQNnB1UGJyTmFLbjZHckZDbGhaQ0d2M1JlczNRMzRmVi91QldoOFVD?= =?utf-8?B?azlPZHh6MjNWdjh1Y1N1TFZmZkJVWWdJVFg5U3Zzeis4MlZBdFdxd0pTVitB?= =?utf-8?B?M3BkbXA3UkhRSWtUVHdMdXVOZGp3bkZVMnZQTm5IV1pXemVydGEvdnRJNXhl?= =?utf-8?B?UVRrK2l3TkhtdGxVRDBZVkN2VEtkYUNnUmtzQ05YbzRGY2dKNGw1c3hhZkFW?= =?utf-8?B?cmVnWDhOQ0svMzhVbkZRaFRqRDdneVlsdGFTVHdxT0Jsc0dMV1RONCs4R3Br?= =?utf-8?B?WVlzaXNaOERRWFdSWVEzaU9MTFQ1SWhDc1ZtK2ZDcXJ0UEhUTWNwOWl1UnRp?= =?utf-8?B?SU1XZVhrZHBEZ0FHYTNodU5GVUg5RWFEQ25kam9mWlh6emhiMm84WGQ5TzNG?= =?utf-8?B?eWdoWjFHME1jTWFENUltNGdvMlRPK1lMODV1NTFYMGQzc3liczdaQXlhTFdt?= =?utf-8?B?UjdnNnd0eG94OG5uR0N6Y2p0RkxmSzVtaXdMZ3ZRc3RQRlA1SS9MSjE2UzhB?= =?utf-8?B?NUxOSmVKZ21DbGQ4WFVJYnY3WjM1TlU0aHBjTjQycFdXNVI1amV4eEl5aTd4?= =?utf-8?B?WWEzWEUzVlJuMTYzRkhJb0dFdXNVc1NJU3dObFBjMHpUMzkyWmJEUG83b1NW?= =?utf-8?B?SG9DWXZzWWpyRVMrQ1gvdnRTTzhqNnVEZEl6blE4VkpUc1hHL2E1NVpUMXVC?= =?utf-8?B?bDhaQUYvc1VBQklkSHFYazUxcWxXMEVsYVJhd3FvVUJYMWloREdjdkkvSEtJ?= =?utf-8?B?cEZ4N3lIRXdkaHhqYmpNU1ZNRStVbmRkaWhubjlpTWorTTJxeFhDdTdNRU9W?= =?utf-8?B?a09rYzdjWVJvMklwTUJFTUhIa0ZGeEwwUWxyazk5ZUhKcCs0bnE0S0NwYWkw?= =?utf-8?B?eS95MzdaVWk1WkcrdnFtTjhnczlzKzk2bDJiV1R3RXBjcjNBdz09?= X-Microsoft-Antispam-Message-Info: OLG1sO+jztk75Kx4Fnh1Y4SAoAX2zh/C+9bSYn4DBgD+y+0Ll6S7b/vgNETmOzvvSXOG6MnrGxsqaR2EwAoAK7B/U+BB+AAXXxneanNhg4jVi83ik8k7x4lQGwb7WC8lKEAD2E2Nf0zZUdtHM7sNc3ZXz0BLbDppwy05J547c4ANptAzHaSwOfEi4osGVSwA X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2784; 6:CHpRph1xZLwjXWhPPzmWZZmohZHjl+3ubg81Tyvje4i32qxa9/zazRXcAwRWr9bfLuo/JLul504NfbV6ZbvChHC/dlETwGs9K7y1jGSvSguFtFv/G3Q/nml3Uepc7PEfBbslKoTmJ9TklzOGWmI11IP25Lds644GaxU0rUWdz3hB6J4khbCsCGBUAamdxPlkCgyvz6jwHrW0/O6AU24b77AMUXAr/UvFMBnuTMEB/oZmORL20iehNruWGNoYokm/rNFbdnyyGUT7g79drjaouywX3HEhwOzkS5Ubx66H5lh8pKW9RFxggqXAa9RlW9JWxBFApsRah/E0+wn59rWfwDgU2/TokAoMfaxpQD95M1w=; 5:vSzFM1pRuFM3g6jK4L3w6FEV80eTvx2lI+VgDYs0hBfRKeYuSDAV7uisPxqzQUj4LCaDzfoB0VqmC3CMc4/Esad9Ds/Ph2x8jgIdO/tA6IMT0c1E4VJr80kqaVL0WDufdIDlEFGDd2JiFVzRYxfyj6w5Y5iI6jA7y/8YFAHAJ28=; 24:RWeTvVI8h/pgAgjKe5MSVsD68P5D3nKdoTvdiqkiSfsRNls2uyk++CCNY0h6zMP0QR6Ib4IfWU/vK2o/n/H0VqOm+QsPix392pzOY9N99WU=; 7:533vQCFM6PMRFWKyYT96vLtuvpfeT1u2Vvv6nJoUbAo1LXCLamOGdrPTyEz2IG8AFY0zr8uAhyyFespvrFpI6nx+oqEmKUbmpCVtcwJTotO9JnfPgYHY2Uqz5i0N5MCWBke48lvv6vITrj3xMh8Y971K+Y4jvjTFwQw6bzaa8oaBQUHqICstf/4xDFJLu/8k0V2xRXV+4ED5PF58FMznbRcNSgsL3QGkkynjdUyYHCUd2YtJJAL8LMaNZBP84Jl0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2018 07:22:13.1069 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 47a095a3-3e5c-4c48-50a0-08d58332fb55 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2784 Subject: Re: [dpdk-dev] [RFC 4/4] drivers/raw/ifpga_rawdev: Rawdev for Intel FPGA Device, it's a PCI Driver of FPGA Device Manager X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 07:22:14 -0000 Just wanted to rephrase my wordings as they seem to be presenting different meaning from what I was intending. On Tue, Mar 6, 2018 at 12:18 PM, Shreyansh Jain wrote: > On Tue, Mar 6, 2018 at 7:13 AM, Rosen Xu wrote: >> Signed-off-by: Rosen Xu >> --- >> drivers/raw/ifpga_rawdev/Makefile | 59 ++++ >> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 343 +++++++++++++++++++++ >> drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 109 +++++++ >> drivers/raw/ifpga_rawdev/ifpga_rawdev_example.c | 121 ++++++++ > > When rawdev skeleton driver was integrated, Thomas raised this point > of naming 'skeleton_rawdev' rather than just 'skeleton'. Thomas questioned why not 'skeleton' and I stuck to 'skeleton_rawdev'. Which, in hindsight, seems to me a bad decision on my part. > So, rather than 'ifpga_rawdev' rather than 'ifpga'. So, rather than 'ifpga_rawdev', why not use 'ifpga'. > At that time I thought we could use as > model. But, frankly, to me it seems a bad choice now. Extra '_rawdev' > doesn't serve any purpose here. > > So, feel free to change your naming to a more appropriate > "drivers/raw/ifpga/" or "drivers/raw/ifpga_sample" etc. > > Probably I too can change the skeleton_rawdev to skeleton. [snip]