From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30470A3160 for ; Thu, 10 Oct 2019 09:20:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0020D1D445; Thu, 10 Oct 2019 09:20:50 +0200 (CEST) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by dpdk.org (Postfix) with ESMTP id B9C041D444 for ; Thu, 10 Oct 2019 09:20:49 +0200 (CEST) Received: by mail-ed1-f65.google.com with SMTP id v8so4506620eds.2 for ; Thu, 10 Oct 2019 00:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wPFmmPvSrdVRQuEQ4dgX4obJRkNvC7tsbKfROKLRg9Y=; b=abtj+2PtOFi9H3WLFg/3t6GuzzvG/IwZPvqC0NUKz4Qdfl9KPGFbuzsLVrZUrxKBgi 4ZoRn5/GzlMusGF6wDQQyrYHvQ05zxEsy2jOBqWMKTUiFLbVVPUn8W3bQ45etYkWs2f3 bvrOr+iNLtuOWpotvpWWlGvajXzHnrMbVmpTAAWcgkxbh0QwEHPoX/kBhrAGBf6NOCE0 W9y3ZFL3qXt7OEP1B8VNCk+nsFYauckKpyLeCLrfA9HDYR8dV3vAzF4XX2yCzgn77ivA WbD2C26N7+h7O0BP2ymE/8Q7mh1hwcUsaT/Pj4k5YnyjWk509VB+YZOD+zE42oMtb9vZ uL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wPFmmPvSrdVRQuEQ4dgX4obJRkNvC7tsbKfROKLRg9Y=; b=nDgao4GfD6tEfV3AenynHxc5NBGBSOR5UdavQrB3TXLYNTjeIgBZm1K5jWp6nXEH7d D6Jw8APDxIuFfBjHmSkZKbj6LqQIXGo71am+sJ6whTCy3nJmnA5FkuF1BTOfdOHvwRym bdldklcrjsfUJilfgNRekMUWIh96lu1gGaboURoE3Rg3Hb4zDha/hJVeaBEDQe8snF8G 8IoRxUJQkbwBl/lACKohIPifThdw4I72QxWsk2ZCaKn5Z0dr4zl3XVAZ80rVQIGioX4O 2Hq0VN1LhdJw0C9F5hCNkUcgk+zNkJm/TdiWWHWtJBC7YMRbPtRtDfUgbeY+hO/bYqf+ 5K/g== X-Gm-Message-State: APjAAAV0Y8ba/7s82iMJp3cl0hpfPxDu6fIoyQ9Y46we0X68wKLP2fGQ 28Zjj2f3A69hm6bt+csYIjE1UrIIlhKSrJX7XRI= X-Google-Smtp-Source: APXvYqwAwMJejEN8ngZOMNgynIy0ULIt4O3vwwQrWFW4peYcSJwbvsnRPoQP/XEJDNZn+jT1nEiAQf3sEmK04Wpg/n4= X-Received: by 2002:aa7:da4a:: with SMTP id w10mr6577954eds.209.1570692049168; Thu, 10 Oct 2019 00:20:49 -0700 (PDT) MIME-Version: 1.0 References: <1568376912-9585-1-git-send-email-viveksharma@marvell.com> In-Reply-To: From: Vivek Sharma Date: Thu, 10 Oct 2019 12:50:12 +0530 Message-ID: To: Ferruh Yigit Cc: Vivek Kumar Sharma , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ offload in VLAN set command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 9, 2019 at 6:26 PM Ferruh Yigit wrote: > On 9/13/2019 1:15 PM, viveksharma@marvell.com wrote: > > From: Vivek Sharma > > > > Segregate QinQ from Extend Offload and support QinQ offload > > in vlan set command. Merge all port wise rx vlan offloads in > > command line help and documentation for a cleaner structure. > > > > Signed-off-by: Vivek Sharma > > <...> > > > @@ -3902,6 +3895,8 @@ cmd_vlan_offload_parsed(void *parsed_result, > > } > > else if (!strcmp(res->what, "filter")) > > rx_vlan_filter_set(port_id, on); > > + else if (!strcmp(res->what, "qinq")) > > Indeed this is enabling QinQ strip, what do you think calling it > 'qinq_strip'? > Agreed! > > > + rx_vlan_qinq_strip_set(port_id, on); > > else > > vlan_extend_set(port_id, on); > > > > @@ -3916,7 +3911,7 @@ cmdline_parse_token_string_t cmd_vlan_offload_set = > > set, "set"); > > cmdline_parse_token_string_t cmd_vlan_offload_what = > > TOKEN_STRING_INITIALIZER(struct cmd_vlan_offload_result, > > - what, "strip#filter#qinq#stripq"); > > + what, "strip#filter#qinq#extend#stripq"); > > cmdline_parse_token_string_t cmd_vlan_offload_on = > > TOKEN_STRING_INITIALIZER(struct cmd_vlan_offload_result, > > on, "on#off"); > > @@ -3927,9 +3922,9 @@ cmdline_parse_token_string_t > cmd_vlan_offload_portid = > > cmdline_parse_inst_t cmd_vlan_offload = { > > .f = cmd_vlan_offload_parsed, > > .data = NULL, > > - .help_str = "vlan set strip|filter|qinq|stripq on|off " > > + .help_str = "vlan set strip|filter|qinq|extend|stripq on|off " > > "show port info ..." command ('port_infos_display()') displays the vlan > offloads > too, can you please add displaying 'qinq' support too. > This is already implemented in another patch which introduces 'qinq offload'. > > btw, it displays line by line: > VLAN offload: > strip off > filter on > qinq(extend) off > > perhaps we can flatten it, to reduce the info length, what do you think? > Absolutely. In fact, I thought about doing so in the original patch. > VLAN offload: > strip off, filter on, qinq(extend) off, qinq off >