From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53572A3160 for ; Thu, 10 Oct 2019 12:32:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B812D1E972; Thu, 10 Oct 2019 12:32:12 +0200 (CEST) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 758621E969 for ; Thu, 10 Oct 2019 12:32:11 +0200 (CEST) Received: by mail-ed1-f66.google.com with SMTP id h2so4995124edn.3 for ; Thu, 10 Oct 2019 03:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=36+I/ZSLe5m1EOj+6Voihzh8Y1H5NL4bofdtDRpYtog=; b=hR3hgKBAaVk3ZEsI4no8ya+/vejhndnyMVRZxskxq3pkJrwueR1FIn/yRj4XfLCIzj XbWe1mQ4mjYb3/axCLTuF9NJ33gDtG1cm5hH5ND3HU1xoLIw8D06fC1UDrDgNgi31VNZ ZNY9DjDUeQdlH73O3fHboD36oQIlTboRf9dLGO4ubf5azeNYx/5H8R5ZDl9I4JKipm9C Xgv9ctaYQRrJfCUdgBMYCVFbeegPP9CIDYC4c9xym/NqZ2VWH3HlHHY18azX/YM037f1 WLCOOCjkOmN9cukWM3WpT9kKbN7nPdiSWqYuJ/r+kn2K12Pty6E3ukaNF9JA1Tm2RptM wp3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=36+I/ZSLe5m1EOj+6Voihzh8Y1H5NL4bofdtDRpYtog=; b=jUkZn8TLeREcieWTbg3Gt1t9IdVWZzvkCeFWqEiqR8sbAHEKiumS+ZNEf8me8bt5lI JKB+GNUwHPdbJ0mHx/nCnCnHiv0f1Ke+iqKQ9yuEdLf8t6pfHqUo/92KHzS0npkq6Fdh ylXp3v734mPPx9B1veBdFVc3SIldDupQGvWMk2IW42nbj3WJl3fu+9tMIBB8Pai69s0a jAPPoNxrWAZf/3XR3OO3v86D3VV5DE90W0137sh1SvIolWxIQF88r+isS06UHqOIeS6G EWj0+zTEMyTmJ1Bz6TafUfyPjZreIiNrfPOacSTSosG8BkJ+YMC7FYVmhkj8ZKA18aOM wzYQ== X-Gm-Message-State: APjAAAUV0AmzC5yZP4gcEaf+72jcjWX4qXJz1ddom4OHdcoM9z059yce PJT31FppwUyMsgWC678VhX+42dVhLDRXO8ANqtI= X-Google-Smtp-Source: APXvYqzyNeMrOIM/wuIFfSo/sjhnNFlSh76ATx+pZhOQVAg6Ay9Dt5N1PnLlOt9CgNzzdABgTUe+rGz31jCFnbvaZ8M= X-Received: by 2002:a17:906:2ccc:: with SMTP id r12mr6887701ejr.249.1570703530962; Thu, 10 Oct 2019 03:32:10 -0700 (PDT) MIME-Version: 1.0 References: <1568376912-9585-1-git-send-email-viveksharma@marvell.com> In-Reply-To: From: Vivek Sharma Date: Thu, 10 Oct 2019 16:01:34 +0530 Message-ID: To: Ferruh Yigit Cc: Vivek Kumar Sharma , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ offload in VLAN set command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 10, 2019 at 3:54 PM Ferruh Yigit wrote: > On 10/10/2019 8:20 AM, Vivek Sharma wrote: > > On Wed, Oct 9, 2019 at 6:26 PM Ferruh Yigit > > wrote: > > > > On 9/13/2019 1:15 PM, viveksharma@marvell.com > > wrote: > > > From: Vivek Sharma viveksharma@marvell.com>> > > > > > > Segregate QinQ from Extend Offload and support QinQ offload > > > in vlan set command. Merge all port wise rx vlan offloads in > > > command line help and documentation for a cleaner structure. > > > > > > Signed-off-by: Vivek Sharma > > > > > > <...> > > > > > @@ -3902,6 +3895,8 @@ cmd_vlan_offload_parsed(void *parsed_result, > > > } > > > else if (!strcmp(res->what, "filter")) > > > rx_vlan_filter_set(port_id, on); > > > + else if (!strcmp(res->what, "qinq")) > > > > Indeed this is enabling QinQ strip, what do you think calling it > 'qinq_strip'? > > > > > > Agreed! > > > > > > > > > + rx_vlan_qinq_strip_set(port_id, on); > > > else > > > vlan_extend_set(port_id, on); > > > > > > @@ -3916,7 +3911,7 @@ cmdline_parse_token_string_t > cmd_vlan_offload_set = > > > set, "set"); > > > cmdline_parse_token_string_t cmd_vlan_offload_what = > > > TOKEN_STRING_INITIALIZER(struct cmd_vlan_offload_result, > > > - what, "strip#filter#qinq#stripq"); > > > + what, > "strip#filter#qinq#extend#stripq"); > > > cmdline_parse_token_string_t cmd_vlan_offload_on = > > > TOKEN_STRING_INITIALIZER(struct cmd_vlan_offload_result, > > > on, "on#off"); > > > @@ -3927,9 +3922,9 @@ cmdline_parse_token_string_t > cmd_vlan_offload_portid = > > > cmdline_parse_inst_t cmd_vlan_offload = { > > > .f = cmd_vlan_offload_parsed, > > > .data = NULL, > > > - .help_str = "vlan set strip|filter|qinq|stripq on|off " > > > + .help_str = "vlan set strip|filter|qinq|extend|stripq on|off > " > > > > "show port info ..." command ('port_infos_display()') displays the > vlan offloads > > too, can you please add displaying 'qinq' support too. > > > > > > This is already implemented in another patch which introduces 'qinq > offload'. > > Right, I found it [1], but I believe that change suits better here. Since > you > are the author of both patch, would you mind I include that bit into this > patch > while merging? > > Sure, please go ahead! Anyways, I was planning to send v2 of both the patches, which would take care of all the valid points raised by you. > [1] > https://patches.dpdk.org/patch/60847/ > > > > > > > > > btw, it displays line by line: > > VLAN offload: > > strip off > > filter on > > qinq(extend) off > > > > perhaps we can flatten it, to reduce the info length, what do you > think? > > > > > > Absolutely. In fact, I thought about doing so in the original patch. > > I was hoping the change can be part of your patch, but since it is already > out > this can be done as separate patch later. > > > > > > > VLAN offload: > > strip off, filter on, qinq(extend) off, qinq off > > > >