From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5751A3168 for ; Thu, 17 Oct 2019 07:01:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3B9F1E569; Thu, 17 Oct 2019 07:01:49 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 3B2811E569 for ; Thu, 17 Oct 2019 07:01:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571288507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/3smnGK3ohI8gEUsLRHYf11xfNbPBnkj29IVEEP3fZg=; b=CeL10JIrGaNtZ+AOzvc/ZLJSznr7J8GmoK9I/MGGyMbFeV2RI1LeosrvgV+lIRMysl9gsm Sq6+TILWBXSUNlkY6VObxoFwxfSv/iMfp54tMW+MFoPjbAS2GDcVSXWnKRaAy6M+ncQQur rz49b1W1JaSRR7uuxmV0uoiTcE00c8o= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-D5aKKnagPNuX9lu4VSYQ4Q-1; Thu, 17 Oct 2019 01:01:45 -0400 Received: by mail-vk1-f198.google.com with SMTP id b204so485694vkb.11 for ; Wed, 16 Oct 2019 22:01:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/3smnGK3ohI8gEUsLRHYf11xfNbPBnkj29IVEEP3fZg=; b=cCi/GyGB762CmlzBqMiRCHJ0Q0Vi+/cun0jWBgc0sEBfpHbk0TWAyrrekEB0aYQu0K zOZdlAv09PlB/u00QeVvPivfd1/G0SzQykbayKEWUdqWEwcTHCMZTPQ65IOZS7zJQSAw 4Vy3OlhurfF9ImzPk5MTymvzkfjC3EpQsxbBUql/0YX6YBVFbZ8CvlivTduztL+5YDFu cW5C4gUMyUn4Yl87fzKjOEyDx3z0H3nATCh4cKLoUdLroQm2NYYIC9Rd1h0LyPbp6ETm 6XVCh3AkVn7dUJVphyUWNfo8zM7MI8Hv6frnXepJI6yomHzZ6B67ehLHKZ13PQ3yDekj ChCw== X-Gm-Message-State: APjAAAVA4i/dhjUpevSB4dwHP6pc7VyVlwH7nyMhRiCK3mdMpMSLE7J+ lobwVbo2oy01XvoWdIH/2PacboCa1QUhvyu7QEZJHs0mBZiHnHQn/ZvydBFBpQcC1QPamNKsEym 5iRFhqaTn3ZiYEeeTcxA= X-Received: by 2002:a67:fc49:: with SMTP id p9mr853514vsq.198.1571288504729; Wed, 16 Oct 2019 22:01:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtpCjKNG79SX+uxVtc2WXz/oROqYOhv26js/ZFBKmOXkzQxmCGiMOhe/Vg9osFxifAPFM4Q4UnYebHPC8vSaI= X-Received: by 2002:a67:fc49:: with SMTP id p9mr853502vsq.198.1571288504481; Wed, 16 Oct 2019 22:01:44 -0700 (PDT) MIME-Version: 1.0 References: <20191014230745.70489-1-drc@linux.vnet.ibm.com> <20191015211614.123379-1-drc@linux.vnet.ibm.com> In-Reply-To: From: David Marchand Date: Thu, 17 Oct 2019 07:01:33 +0200 Message-ID: To: David Christensen Cc: dev , Stephen Hemminger , dpdk stable X-MC-Unique: D5aKKnagPNuX9lu4VSYQ4Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/ppc: fix 64 bit atomic exchange operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 16, 2019 at 5:10 PM David Marchand wrote: > > On Tue, Oct 15, 2019 at 11:16 PM David Christensen > wrote: > > > > The rte_atomic64_exchange operation for ppc_64 incorrectly linked > > back to a 32 bit generic operation (__atomic_exchange_4) rather than > > the 64 bit generic operation (__atomic_exchange_8). As a result, > > applications that used rte_eth_link_get_nowait() would only receive > > the link speed, they would not receive the link state, link duplex, > > or link autoneg properties. > > > > Fixes: ff2863570f ("eal: introduce atomic exchange operation") > > Fixes sha1 is usually on 12 digits (from the contributing guide). > Will fix when applying. > > > Cc: stable@dpdk.org > > > > Signed-off-by: David Christensen > > Reviewed-by: David Marchand Applied, thanks. -- David Marchand