From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 033BFA0096 for ; Wed, 5 Jun 2019 11:35:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C630E1BA57; Wed, 5 Jun 2019 11:35:11 +0200 (CEST) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 96A271B9E1 for ; Wed, 5 Jun 2019 11:35:10 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id v129so6048540vsb.11 for ; Wed, 05 Jun 2019 02:35:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=apfZbWdcvK7YWdWP1lJ+yH+z0B4lY/Gzu0Wx9s7nDaQ=; b=O7m8zwvEXszkgB9Vy4SwMZBRn/gesthDSXGqTcVxqALB8zdhrXF5VpTV4aQ20hHurI +NpwkbWLO36bAhrMMaQ4wWY9qYpdQ8JoWrhIPi/MgZ4+Egio8pv03GcvEGehtUmo4POQ a42Wxt8TT3BljLtAyT4Xr4uhzTsos5GzEEQlEcrg+pw1ibyGzt/U/yHhCktF8C09xc9O mgvgXA8pGvPa2xtXiNLW/1opbCDpWWfSWmQvEer7VqQ7ZKnbOLuR2qcBzEwspe25nA1w bRmmSszOf/EHFW75KcmP+tmYedtfgvrwmfuJvEscEdLJBkorzufsrwLq3FM+w4JWK05x n7UQ== X-Gm-Message-State: APjAAAUvllM3fB34iaQBfHDBskTzNaGYHCtA0W4j1O+ok5gFzItOLJ1L jVyS/bHbIMuba5HCBJ/Njq2Yf3/Ca4bmSX4E/a6Eo3If X-Google-Smtp-Source: APXvYqxoUAYcfi8XenZWLdXdMg+8tB8lgk7fbXfcs0vwpCAloj85t0uWiNoaL3MpsW8pXRaROmOLXwROOtCPqGP+8go= X-Received: by 2002:a67:f998:: with SMTP id b24mr9337168vsq.180.1559727310054; Wed, 05 Jun 2019 02:35:10 -0700 (PDT) MIME-Version: 1.0 References: <20190605081005.15716-1-maxime.coquelin@redhat.com> <20190605081005.15716-4-maxime.coquelin@redhat.com> In-Reply-To: <20190605081005.15716-4-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 5 Jun 2019 11:34:59 +0200 Message-ID: To: Maxime Coquelin Cc: dev , ybrustin@cisco.com, Tiwei Bie , Jens Freimann , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/4] net/virtio: fix segment data len in mergeable packed Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 5, 2019 at 10:11 AM Maxime Coquelin wrote: > Head segment data_len field is wrongly summed with the length > of all the segments of the chain, whereas it should be the > length of of the first segment only. > > Fixes: a76290c8f1cf ("net/virtio: implement Rx path for packed queues") > Cc: stable@dpdk.org > > Reported-by: Yaroslav Brustinov > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_rxtx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 9469ecb743..33dbc78906 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -1914,7 +1914,6 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue, > prev->next = rxm; > prev = rxm; > rx_pkts[nb_rx]->pkt_len += len[extra_idx]; > - rx_pkts[nb_rx]->data_len += len[extra_idx]; > extra_idx += 1; > } > seg_res -= rcv_cnt; > -- > 2.21.0 > And another one, line 1880 :-) Reviewed-by: David Marchand -- David Marchand