From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3636BA0547; Wed, 19 May 2021 10:08:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB3EA40041; Wed, 19 May 2021 10:08:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 580D14003F for ; Wed, 19 May 2021 10:08:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621411731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98Vep8tHDT52dr5sKwU48eCUrX3wdsU+Kh3MhF5pt6Y=; b=BnOCCYwxKrStQRffCWgBCWi1syeK2J0VBT13Z1dJBs/sCETAxiqPjI7fhv+sxZTHVThzfU f9w7STQ6tCaa5JJbnpyqbSbvqjp3ubwaVhzXJfjP2l8cNP+iqoK8ZSuq0UelSAZeD/oSLN z8yH7TFKTxjpejnzA3JsJOMfdf1bGQI= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-Yhz73ZrENnWjzPGWzx0SPg-1; Wed, 19 May 2021 04:08:35 -0400 X-MC-Unique: Yhz73ZrENnWjzPGWzx0SPg-1 Received: by mail-vk1-f199.google.com with SMTP id w19-20020a1f94130000b02901e9c73307d5so1542037vkd.5 for ; Wed, 19 May 2021 01:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=98Vep8tHDT52dr5sKwU48eCUrX3wdsU+Kh3MhF5pt6Y=; b=FzKRhadpbRWcUUzJfQdeNwOPKz36HreHXEc7cqlYYKDLJkDrzc7CxShfc0BPj8VFjW GNM9OesMhYT9xo6+r3AQyFxIKQo+FTeOmzMDXyyWlN6RIaW4FUOOBdfmiU59a3x0krL3 YKXOT1NxdvNJ3dCH75qX1VLQG85M00KgAoc0bSSZkGiEcDQyN1bDzc2rvyIwWr2oVtCd dFStsGMSbELECqhfwVOdQxBvks7SMEtE6QgkGctqTPqyBtPRNhUdlX/w7iUicbURcvw4 rgSxOMXU0Aeg6yZVp9wp9Hp4ruI2DEFyb38184aeEUTxGPj1idikGS3kSr5sTweCpzLa a2IA== X-Gm-Message-State: AOAM531BcgSuN9w4YuR3S1HnvBLuC7K6qVJj+IM/RVJI4iuPJ041oGaA dgx3WzJAvPCTFykcCGD/RFWHwRcP88Yb5NVc1PFUA/8bZPfFa0dzazOMB8UZ5xbEAif7GGkbWtI GtDmofQt7gDGcz4oNOlY= X-Received: by 2002:a1f:d283:: with SMTP id j125mr11742471vkg.9.1621411713856; Wed, 19 May 2021 01:08:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJFOAVH9+bqMwsitS3oqj47i+8TTjHG4lud8qPTZrGQ1h0o7h/w4iI0lpi9Y7pEqXtt7SJjvX7ZSEe6ZajDus= X-Received: by 2002:a1f:d283:: with SMTP id j125mr11742406vkg.9.1621411713180; Wed, 19 May 2021 01:08:33 -0700 (PDT) MIME-Version: 1.0 References: <1620808126-18876-1-git-send-email-fengchengwen@huawei.com> <1620986039-29475-1-git-send-email-fengchengwen@huawei.com> <1620986039-29475-3-git-send-email-fengchengwen@huawei.com> <394de3ea-f0ba-a5a3-e751-be04f479281d@intel.com> In-Reply-To: <394de3ea-f0ba-a5a3-e751-be04f479281d@intel.com> From: David Marchand Date: Wed, 19 May 2021 10:08:21 +0200 Message-ID: To: Ferruh Yigit , Honnappa Nagarahalli , Chengwen Feng Cc: "thomas@monjalon.net" , "dev@dpdk.org" , "jerinj@marvell.com" , Ruifeng Wang , "viktorin@rehivetech.com" , "bruce.richardson@intel.com" , "jerinjacobk@gmail.com" , "juraj.linkes@pantheon.tech" , nd Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 18, 2021 at 6:28 PM Ferruh Yigit wrote= : > > On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: > > > > > >> > >> Currently, the SVE code is compiled only when -march supports SVE (e.g= . '- > >> march=3Darmv8.2a+sve'), there maybe some problem[1] with this approach= . > >> > >> The solution: > >> a. If the minimum instruction set support SVE then compiles it. > >> b. Else if the compiler support SVE then compiles it. > >> c. Otherwise don't compile it. > >> > >> [1] https://mails.dpdk.org/archives/dev/2021-April/208189.html > >> > >> Fixes: 8c25b02b082a ("net/hns3: fix enabling SVE Rx/Tx") > >> Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Chengwen Feng > > Looks good to me. > > Reviewed-by: Honnappa Nagarahalli > > > > Applied to dpdk-next-net/main, thanks. > > (Only this patch, 2/2, applied, not whole set) UNH caught a build regression on next-net and I think this is due to this p= atch: https://lab.dpdk.org/results/dashboard/tarballs/15259/ FAILED: drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o ccache cc -Idrivers/net/hns3/libhns3_sve_lib.a.p -Idrivers/net/hns3 -I../drivers/net/hns3 -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/arm/include -I../lib/eal/arm/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Darmv8.1-a+crc+crypto -mcpu=3Dthunderx2t99 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DCC_SVE_SUPPORT -march=3Darmv8.2-a+sve -MD -MQ drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o -MF drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o.d -o drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o -c ../drivers/net/hns3/hns3_rxtx_vec_sve.c cc1: error: switch =E2=80=98-mcpu=3Darmv8.1-a=E2=80=99 conflicts with =E2= =80=98-march=3Darmv8.2-a=E2=80=99 switch [-Werror] ../drivers/net/hns3/hns3_rxtx_vec_sve.c:5:10: fatal error: arm_sve.h: No such file or directory 5 | #include | ^~~~~~~~~~~ cc1: all warnings being treated as errors compilation terminated. I see a similar issue on my fc32, cross compiling with following gcc: $ aarch64-linux-gnu-gcc --version aarch64-linux-gnu-gcc (GNU Toolchain for the A-profile Architecture 8.3-2019.03 (arm-rel-8.36)) 8.3.0 Copyright (C) 2018 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [74/503] Compiling C object drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o FAILED: drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o aarch64-linux-gnu-gcc -Idrivers/net/hns3/libhns3_sve_lib.a.p -Idrivers/net/hns3 -I../../dpdk/drivers/net/hns3 -Ilib/ethdev -I../../dpdk/lib/ethdev -I. -I../../dpdk -Iconfig -I../../dpdk/config -Ilib/eal/include -I../../dpdk/lib/eal/include -Ilib/eal/linux/include -I../../dpdk/lib/eal/linux/include -Ilib/eal/arm/include -I../../dpdk/lib/eal/arm/include -Ilib/eal/common -I../../dpdk/lib/eal/common -Ilib/eal -I../../dpdk/lib/eal -Ilib/kvargs -I../../dpdk/lib/kvargs -Ilib/metrics -I../../dpdk/lib/metrics -Ilib/telemetry -I../../dpdk/lib/telemetry -Ilib/net -I../../dpdk/lib/net -Ilib/mbuf -I../../dpdk/lib/mbuf -Ilib/mempool -I../../dpdk/lib/mempool -Ilib/ring -I../../dpdk/lib/ring -Ilib/meter -I../../dpdk/lib/meter -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Darmv8-a+crc -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DCC_SVE_SUPPORT -march=3Darmv8.2-a+sve -MD -MQ drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o -MF drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o.d -o drivers/net/hns3/libhns3_sve_lib.a.p/hns3_rxtx_vec_sve.c.o -c ../../dpdk/drivers/net/hns3/hns3_rxtx_vec_sve.c ../../dpdk/drivers/net/hns3/hns3_rxtx_vec_sve.c:5:10: fatal error: arm_sve.h: No such file or directory #include ^~~~~~~~~~~ compilation terminated. --=20 David Marchand