From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E73645A7B; Tue, 1 Oct 2024 17:25:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E53E402A7; Tue, 1 Oct 2024 17:25:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EABC440299 for ; Tue, 1 Oct 2024 17:25:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727796312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=825Y8qo8e50GdDG9sL00SJ4H/AAdaWrraRo7MI39hqc=; b=gleL1yfMzoSnfFjneuU+teawVexebtBGFtgRQ4UceEsnfKoD0SVoSOYo7jsh4AuFEZLqUi bReBAv3nHWekRU4OyUQZ+TksqOLuaSAzHGXX945wE4ZOCg3xl6Xd6iRknMVnyEkcGAX8w+ VJdeK2bHre6t4h0DzHxrW3RVC+giWfE= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-qzFjt4I8NBeh56zkgO1DsQ-1; Tue, 01 Oct 2024 11:25:11 -0400 X-MC-Unique: qzFjt4I8NBeh56zkgO1DsQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5398ee9fcb4so2849881e87.2 for ; Tue, 01 Oct 2024 08:25:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727796310; x=1728401110; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=825Y8qo8e50GdDG9sL00SJ4H/AAdaWrraRo7MI39hqc=; b=lJzy0asVO5OKA2gUK2NQwv6v60cSRz4AMzt73mXRjqHF4L266Fxew0WffXCWdPYntI yumQGvoBCGDIOBUj6eaMVfDxxF+PyUEkCs6GiCoKxfWh0Cxz/lrbq5XbE0Bd/gXkIzSO lTAaAHqY70gwUwwygzf7hQ21jB0+0jZSIJsb5hZrnJsmbp2ivi3OQ/OhXTir8TLNmJV3 9dQ0mDmHEf39oNXM1UpNnRIHrI8WlFpkisYML2leHH5bRVJg9Q+ibvMV0cXLPsc1/E37 8/R73eMsIg1l3VStFByqH3TRwX6QkPahks2zmhE77ugsXhOvVJMCB/OXcptzw1Ro6/9L FZZw== X-Gm-Message-State: AOJu0YxGqviLBwBSLPfRgzny09JvqBnakMKQf/LWiUdPQuq5w2zf0o0Z cqvRI2fetZnbnkjWcVCfAnmm5ihat1TMqZDwdC4pOLlTV7yO18SqFzvo/XvBkxE8XxFkZgzMAug t6sjGeW5QUziIjgG0PDi8OkxhMAAXaKm7Tv1b+5DPxaFWpe9uD+3l+ZIICEcHyuMAgtb/T//wyB Si8UnLWWEvdlSPRQc= X-Received: by 2002:a05:6512:33d6:b0:539:958f:1b84 with SMTP id 2adb3069b0e04-539958f1c7dmr4170503e87.17.1727796309900; Tue, 01 Oct 2024 08:25:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGO9FjZq9iueccBGgAWtsq84Gdx22KIUbtKtH+sMizm3zxBToiySuMLSmhURhxpMV/NoPgEe9IBQCpNgtR3HuU= X-Received: by 2002:a05:6512:33d6:b0:539:958f:1b84 with SMTP id 2adb3069b0e04-539958f1c7dmr4170486e87.17.1727796309447; Tue, 01 Oct 2024 08:25:09 -0700 (PDT) MIME-Version: 1.0 References: <20240809202539.590510-1-mattias.ronnblom@ericsson.com> <20240909191103.697554-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20240909191103.697554-1-mattias.ronnblom@ericsson.com> From: David Marchand Date: Tue, 1 Oct 2024 17:24:58 +0200 Message-ID: Subject: Re: [PATCH v2] service: extend service function call statistics To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, hofors@lysator.liu.se, harry.van.haaren@intel.com, Stefan Sundkvist , Chengwen Feng X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 9, 2024 at 9:28=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > Add two new per-service counters. > > RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function > invocations where no work was performed. > > RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations > resulting in an error. > > The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (i.e., > counting all invocations, regardless of return value). > > The new statistics may be useful for both debugging and profiling > (e.g., calculate the average per-call processing latency for non-idle > service calls). > > Service core tests are extended to cover the new counters, and > coverage for RTE_SERVICE_ATTR_CALL_COUNT is improved. > > The documentation for the CYCLES attributes are updated to reflect > their actual semantics. > > Signed-off-by: Mattias R=C3=B6nnblom Acked-by: Chengwen Feng Acked-by: Harry van Haaren Applied, thanks. --=20 David Marchand