From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DB55A0503; Wed, 18 May 2022 19:24:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE8CC40156; Wed, 18 May 2022 19:24:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B3993400D6 for ; Wed, 18 May 2022 19:24:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652894688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gwEK/0nD9CgKQQYezlBdiPekk/zhDdDu2tY16QG6oTU=; b=Ww0ARePtVvm2tfuwbALLtI6yJNbY6cO8TpiIunOMLqfVqHYcXyXzvFRuWVgWdDxnCqaFyo lfMupGkE/Z/QiTXPrWrm8PkJdcQAa8IkWNCJIiS/LGFlkdecaQHN1kVzSZqFodphcCrAKI GaMm9F3b5VQv9hBGidzFS4C9pZ7dlGo= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-369-TN42UGDBO56WIrLbf9Y5YA-1; Wed, 18 May 2022 13:24:46 -0400 X-MC-Unique: TN42UGDBO56WIrLbf9Y5YA-1 Received: by mail-lj1-f200.google.com with SMTP id g3-20020a2e9cc3000000b00253cc2b5ab5so570093ljj.19 for ; Wed, 18 May 2022 10:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gwEK/0nD9CgKQQYezlBdiPekk/zhDdDu2tY16QG6oTU=; b=oDKj3A4Iwa5F9as/ry2/AQtG5nEdcEVTYNQd/fivtCo12Clvt0bbo/5OElvWpsphiP SU276dv4WF1mQuCjgeV0oN9FjCau0Ctb0qpOhMVaEkzswT1s41jDEmufXslTGQw3U+AJ Dy179d7bUpHBTBTLmg/mD1VXOFebYfKSRAo0AgZ6aKtwS0InE+KZ9o0dBAM1SHkyqUH8 X2lVOJos2v8IwZnj7puuvdZuTMIOfkAl02IvqNKf1nUYi5YC9ePISdjoUdTqkjj4bfAy PFsU6u2i3vzohfwvjNGFukmyPDmfD4Rgsgo16UwSTiBOFWolpPrW0G5UNhgZBYDaPa27 VDHA== X-Gm-Message-State: AOAM5310Xj+rx4mJAJY0/k+19ssP0jOZDCT/sQtIFsCtHL48qXEs6lRx l8gvpJyd6baZXInjY3kx3TUnR/rTUk9yRScFaJuOfHD4EgQiPeZzctpJJncMgSDgcHExOrCtd57 puJaT90ULNt+LZEInbBI= X-Received: by 2002:a2e:9b9a:0:b0:253:bae9:f26b with SMTP id z26-20020a2e9b9a000000b00253bae9f26bmr237628lji.159.1652894685156; Wed, 18 May 2022 10:24:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIehc4O8F0DGoe6pXRvpWqn4vXn21y64t4GUZ5LgoWAAlRITq6LryGL7TFEwubhmNBkfQ75eLRn4Zxewc7OJ0= X-Received: by 2002:a2e:9b9a:0:b0:253:bae9:f26b with SMTP id z26-20020a2e9b9a000000b00253bae9f26bmr237613lji.159.1652894684938; Wed, 18 May 2022 10:24:44 -0700 (PDT) MIME-Version: 1.0 References: <20220513075718.18674-1-david.marchand@redhat.com> <20220513075718.18674-3-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 18 May 2022 19:24:33 +0200 Message-ID: Subject: Re: [RFC PATCH 2/4] net/bonding: move testpmd commands To: "Min Hu (Connor)" Cc: dev , Thomas Monjalon , Xiaoyun Li , Aman Singh , Yuying Zhang , Chas Williams Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) wrote: > > I think net/bonding offer 'API' for APP to use the bonding. > and use the specific PMD as slave device. > The software framwork is like: > APP > ethdev > bonding PMD > PMD > hardware > > so, I think cmdlines for testpmd should not put in net/bonding. Sorry, but the distinction is vague. Those commands are specific to this driver/library. I don't see the problem with hosting the commands in the bonding driver/library. This is still a RFC, I don't mind dropping this patch (in the end) if others think it does not make sense. For now I'll keep it in a v2 series fixing the registering issue in patch 1. -- David Marchand