From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D1F143B5E; Tue, 5 Mar 2024 16:47:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FE39402A8; Tue, 5 Mar 2024 16:47:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8422F40271 for ; Tue, 5 Mar 2024 16:47:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709653643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q3RmPsykaisA59HGh1I/rE+KlX8ndTDPLiwfBc7vwy4=; b=PcBQywhI8JJ1/sxezhpaWkUMCnUT7K8ZaZ+Q0cCT2jGoxaVcbU+LOBVpubR7ReJvV3MPXN jrAhhhthDw1+RzcRMFWvb+afAFApYmF7c8+5SPY522m1AsdHee6/eTvXpcJQIONTKCTrPB YgVSit/dLTMlLLXzyAKxTQAUV5XFrug= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-0I2XEolkP4-tpux1EBUSFQ-1; Tue, 05 Mar 2024 10:47:19 -0500 X-MC-Unique: 0I2XEolkP4-tpux1EBUSFQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-51337da375dso3414571e87.3 for ; Tue, 05 Mar 2024 07:47:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709653638; x=1710258438; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q3RmPsykaisA59HGh1I/rE+KlX8ndTDPLiwfBc7vwy4=; b=Er/90TkqVz6px2DOvLnRsb7NfMCFE36OVuxrXJH9mHf3G8nHSatDUXHPP0lOn58XRq BBTPnv4fv++KsBdsbtdAeBZYVluYNYj0OkwplIo32gWBIjSUi5V2dgEDO4i9jDRSWuar 7clSp1K8HP8Xd1PfUGjpoW/RqIy/pI+GrrHIyN775juMcEkIsLiGfhQ0w/+1guW5ZM7P aLcC98H5xpkMtKqT3qcF7nD5pMPZ0GuQK9Ew61XSQft0/PD5+dtkObXfa7j7yJJHCpLU BuAHqPOCseodkNOlxPPFtHWL0CfN+hEdjvB22vKcBGLMMTU/0ORv96N3/4lL5lC76MLi XUVw== X-Gm-Message-State: AOJu0YwHbYAiCtxj+Gvfzdi7SYbKQCKUOlw+DJfYQ79seWOfCKYIaQai N0Dms8JmiXni3vDjwR47lkcm0zyWLllGlIZ0ZSXYv8mb1m7iL/8jgtguwfuAKUV+vLcZVuy8uII fZimzJcyRi3/RaMZXsFee6wYSwTVKJevuM2kXi3/3YZHzIBZy3UfHK/Umx/8gnf3l64PyGy6Xmb CF55+Ey0psQ0sIQGc= X-Received: by 2002:a05:6512:601:b0:513:1f2b:35f6 with SMTP id b1-20020a056512060100b005131f2b35f6mr1575504lfe.35.1709653638185; Tue, 05 Mar 2024 07:47:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IH421pk9O5C8rVfZF/utq1F4tpgDwV6/J6QJJ9ay+DZOR7WOyR/d+RczAHbkvIiHUOlSxTxuTY/FA75ZSqlU6M= X-Received: by 2002:a05:6512:601:b0:513:1f2b:35f6 with SMTP id b1-20020a056512060100b005131f2b35f6mr1575492lfe.35.1709653637853; Tue, 05 Mar 2024 07:47:17 -0800 (PST) MIME-Version: 1.0 References: <1707873986-29352-1-git-send-email-roretzla@linux.microsoft.com> <1709574764-9041-1-git-send-email-roretzla@linux.microsoft.com> <1709574764-9041-11-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1709574764-9041-11-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 5 Mar 2024 16:47:05 +0100 Message-ID: Subject: Re: [PATCH v7 10/39] eventdev: use C11 alignas To: Tyler Retzlaff , Jerin Jacob Cc: dev@dpdk.org, Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Cristian Dumitrescu , David Christensen , David Hunt , Ferruh Yigit , Honnappa Nagarahalli , Jasvinder Singh , Kevin Laatz , Konstantin Ananyev , Min Zhou , Ruifeng Wang , Sameh Gobriel , Stanislaw Kardach , Thomas Monjalon , Vladimir Medvedkin , Yipeng Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 4, 2024 at 6:54=E2=80=AFPM Tyler Retzlaff wrote: > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index 3af4686..08e5f93 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -1338,7 +1338,7 @@ int rte_event_dev_stop_flush_callback_register(uint= 8_t dev_id, > /** > * Event vector structure. > */ > -struct rte_event_vector { > +struct __rte_aligned(16) rte_event_vector { > uint16_t nb_elem; > /**< Number of elements valid in this event vector. */ > uint16_t elem_offset : 12; > @@ -1376,23 +1376,19 @@ struct rte_event_vector { > * value to share between dequeue and enqueue operation. > * The application should not modify this field. > */ > - union { > + union __rte_aligned(16) { > #endif > struct rte_mbuf *mbufs[0]; > void *ptrs[0]; > uint64_t u64s[0]; > #ifndef __cplusplus > - } __rte_aligned(16); > + }; > #endif > /**< Start of the vector array union. Depending upon the event ty= pe the > * vector array can be an array of mbufs or pointers or opaque u6= 4 > * values. > */ > -#ifndef __DOXYGEN__ > -} __rte_aligned(16); > -#else > }; > -#endif This part was a strange construct. I see nothing wrong with the change (doxygen passes fine), but just a heads up to Jerin. --=20 David Marchand