DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Ibtisam Tariq <ibtisam.tariq@emumba.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	dev <dev@dpdk.org>,
	 "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix typing error in example/l3_forward_access_ctrl
Date: Thu, 5 Nov 2020 09:54:33 +0100
Message-ID: <CAJFAV8w-=AR8BBGRMKf3eDohVNq+vFmrJqUmPtyc1EZT=jhodA@mail.gmail.com> (raw)
In-Reply-To: <20201102111915.5279-1-ibtisam.tariq@emumba.com>

On Mon, Nov 2, 2020 at 12:20 PM Ibtisam Tariq <ibtisam.tariq@emumba.com> wrote:
>
> Add "--" and remove extra spaces in l3fwd-acl commands.
>
> Fixes: d0dff9ba4 ("doc: sample application user guide")
> Cc: bernard.iremonger@intel.com
>
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
>  doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
> index 4a96800ec..3cdfbfb17 100644
> --- a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
> +++ b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
> @@ -236,7 +236,7 @@ The application has a number of command line options:
>
>  ..  code-block:: console
>
> -    ./<build_dir>/examples/dpdk-l3fwd-acl [EAL options] -- -p PORTMASK [-P] --config(port,queue,lcore)[,(port,queue,lcore)] --rule_ipv4 FILENAME rule_ipv6 FILENAME [--alg=<val>] [--enable-jumbo [--max-pkt-len PKTLEN]] [--no-numa] [--eth-dest=X,MM:MM:MM:MM:MM:MM]
> +    ./<build_dir>/examples/dpdk-l3fwd-acl [EAL options] -- -p PORTMASK [-P] --config(port,queue,lcore)[,(port,queue,lcore)] --rule_ipv4 FILENAME --rule_ipv6 FILENAME [--alg=<val>] [--enable-jumbo [--max-pkt-len PKTLEN]] [--no-numa] [--eth-dest=X,MM:MM:MM:MM:MM:MM]
>
>
>  where,
> @@ -271,7 +271,7 @@ To enable L3 forwarding between two ports, assuming that both ports are in the s
>
>  ..  code-block:: console
>
> -    ./<build_dir>/examples/dpdk-l3fwd-acl -l 1,2 -n 4 -- -p 0x3 --config="(0,0,1),(1,0,2)" --rule_ipv4="./rule_ipv4.db" -- rule_ipv6="./rule_ipv6.db" --alg=scalar
> +    ./<build_dir>/examples/dpdk-l3fwd-acl -l 1,2 -n 4 -- -p 0x3 --config="(0,0,1),(1,0,2)" --rule_ipv4="./rule_ipv4.db" --rule_ipv6="./rule_ipv6.db" --alg=scalar
>
>  In this command:
>
> @@ -293,9 +293,9 @@ In this command:
>      |          |            |           |                                     |
>      +----------+------------+-----------+-------------------------------------+
>
> -*   The --rule_ipv4 option specifies the reading of IPv4 rules sets from the ./ rule_ipv4.db file.
> +*   The --rule_ipv4 option specifies the reading of IPv4 rules sets from the ./rule_ipv4.db file.

No point in keeping the ./ and I would remove it in the cmdline
example above too.


> -*   The --rule_ipv6 option specifies the reading of IPv6 rules sets from the ./ rule_ipv6.db file.
> +*   The --rule_ipv6 option specifies the reading of IPv6 rules sets from the ./rule_ipv6.db file.
>
>  *   The --alg=scalar option specifies the performing of rule lookup with a scalar function.
>
> --
> 2.17.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>

Thanks.

-- 
David Marchand


  reply	other threads:[~2020-11-05  8:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 11:19 Ibtisam Tariq
2020-11-05  8:54 ` David Marchand [this message]
2020-11-20 12:04   ` David Marchand
2020-11-24 12:40     ` Ibtisam Tariq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8w-=AR8BBGRMKf3eDohVNq+vFmrJqUmPtyc1EZT=jhodA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ibtisam.tariq@emumba.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git