From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2237BA0503; Thu, 19 May 2022 17:06:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EA39427ED; Thu, 19 May 2022 17:06:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2458540156 for ; Thu, 19 May 2022 17:06:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652972770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VynupEXDi6lkG9HcGPPaRtrdeEJ226zIYHFJdFrc3Cw=; b=BUOf+hB161nxweDt9hf9Xc98QZ/z83veOS6CWQDOWoRrCzRW9GWPB2sT/ZiL7TFVU9sa+H /bKAUag4w9wt9VRsCTJRkhdSg+9xwSOYcgDOjcHLGCnhrwCiaGCYRRXZQQqVnZ138NiOmr g1zFFqTbhpC+WNl0JHJATGiBSKZkRow= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-64-fDaaX59KOciVYSJ9ReeMTA-1; Thu, 19 May 2022 11:06:09 -0400 X-MC-Unique: fDaaX59KOciVYSJ9ReeMTA-1 Received: by mail-lf1-f69.google.com with SMTP id k3-20020a05651239c300b00477b22d54c3so2761608lfu.20 for ; Thu, 19 May 2022 08:06:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VynupEXDi6lkG9HcGPPaRtrdeEJ226zIYHFJdFrc3Cw=; b=ikND+rn/vbOxV+0YfxiOVPaTXveVWiwudYLK2unIp0PexfEHP2e8X1NLx9+1fBbkRR Ok+Fyykl2RTxIuQrj9QLY30b3yocGBFZ4iXBmlvhwGgM41cgzFFUfsfgxmBMTgb/eu/v NR4kRiW393S+8KpJcz86GV+4YkJ2urRAHJX+ThjtYHcGXfLXmufjHEh2cvBcikiXMA4Z h9kcABqZ/37T20+w77JMOHOe/D/LVp6X6VA1groqX/HTAeAlW2v8TYPv8zg3ntbEwrZU +G2seLvZM+9WoSvrx+x+DQmulJv+eo8dtRad2RE9IjXFkq43r25pV3nF+Ty/Fj5UUE25 l8PA== X-Gm-Message-State: AOAM533tFc4uKCAsNiZ0Sa19GoZQ0+hnF79fErddsmbfcz/uSLt6zUSD 8LlhijGVk2B1Qv/9l56R0UeBc20z0fh8k6up3SB3MJaaEL3fs+bcNr1M/AAKvhXG/ika84s4NnJ D7LMKPxsIpIpEyMCWtgg= X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr3744547lfa.499.1652972768040; Thu, 19 May 2022 08:06:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsmdUgmGm4JaXgC612YLuNKrf68h80Hi8yrsVXX694miW8luey/+Q7NELgb7gmoUAuSt2bVJaHifJ2EfuhsUc= X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr3744532lfa.499.1652972767829; Thu, 19 May 2022 08:06:07 -0700 (PDT) MIME-Version: 1.0 References: <1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com> <1652361270-27116-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1652361270-27116-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 19 May 2022 17:05:56 +0200 Message-ID: Subject: Re: [PATCH v6 0/3] add eal functions for thread affinity and self To: Tyler Retzlaff Cc: dev , Thomas Monjalon , Dmitry Kozlyuk , "Burakov, Anatoly" , Narcisa Ana Maria Vasile , "Ananyev, Konstantin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, On Thu, May 12, 2022 at 3:14 PM Tyler Retzlaff wrote: > > this series provides basic dependencies for additional eal thread api > additions. series includes > > * basic platform error number conversion. > * function to get current thread identifier. > * functions to get and set affinity with platform agnostic thread > identifier. > * minimal unit test of get and set affinity demonstrating usage. > > note: previous series introducing these functions is now superseded by > this series. > http://patches.dpdk.org/project/dpdk/list/?series=20472&state=* > > v6: > * rebase for asan flag addition to app/test/meson.build > * RTE_BUILD_BUG_ON(sizeof(pthread_t) > sizeof(uintptr_t)) to raise > attention if pthread_t implementation exceeds storage available > from uintptr_t. > note: > the macro is placed in rte_thread_self() body because it not > valid syntax at file scope of the translation unit. ordinarily > the macro would be used in headers but that would leak the > pthread_t implementation detail into the public header. There was a missing update of MAINTAINERS in patch 3 that I fixed. Series lgtm, applied, thanks. Looking at the generated documentation, rte_thread.h is not exposed, but this was already the case before the series. Could you look into it? -- David Marchand