From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAFAEA2EFC for ; Mon, 14 Oct 2019 16:33:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DCB21C1E3; Mon, 14 Oct 2019 16:33:11 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 2E81B1C1D4 for ; Mon, 14 Oct 2019 16:33:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571063588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xZjBz9qUG3TUvekAAoTR7DggNepGEWvKxxPQalYRZ5Q=; b=IyADPIytBkdzKPwM/+I4oSdWmtRECTp1RHM2r9QKKTI8bMlX7vhSWLZLRbd80GmlzlGDjS wwYPuz1S4zlLBLQe/XIaJ0PappPFigweljDAjt99Zs5zANaC6kDIVPaY6zWk/7gF/54tLl VqkypQRRdHGHcW7mChTS6e8eHWlm0Xs= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-vQTV934mMlSm7ifKtHWyYg-1; Mon, 14 Oct 2019 10:33:06 -0400 Received: by mail-ua1-f71.google.com with SMTP id 66so4104871uao.0 for ; Mon, 14 Oct 2019 07:33:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xZjBz9qUG3TUvekAAoTR7DggNepGEWvKxxPQalYRZ5Q=; b=Xqu9Pol9GoV3x48lYI8ESxIBTuRfbLTrQ3cc4eY42lzS5fJdA/EYHZ0mn+Jlt81oGg 5Dv0BIO4g4xbzwKAFMeBruk/cOICGrvfOiIhS5ESYZARej4QZ75FBtE2+yu1qojHZafR X+LvHWiu/N7a5HIatmAVO1t5wkvAYNLBJWcl96mCHA58ED38oub1LIlavWe5IN3NM687 4bVqiRwUui+hVAxBDduyw/+gjrV0f9pRpZdtsw8FvvGbE4dh9+N0Ijmt73+8fGAPk/w+ ZW4hNPX/5S6Daml/ZInjLrWYRCJGbh8ecV+av6dVPI0GK0RGStHetBf9gracgA8ztu+u Yhiw== X-Gm-Message-State: APjAAAWFYX71zqgEaPYnGw5i6i1SMSA7BEUnB8zQkuf6MP/s9r6+ym+P 9SKxK1D/i+CBncv1eaKwC9ntCA7pvjS28uzR6O4LGECaus2cYrfnmw4J/JgKicRwgRBrHs2rQtb qAq80lSxeh+DOxZytMnY= X-Received: by 2002:a67:f98c:: with SMTP id b12mr17668098vsq.39.1571063585761; Mon, 14 Oct 2019 07:33:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqyTVxkVbNMiJ+T5Z4fdFVW/7lUR/+0y/4DripTonOeEc9M/sF3f+0wEYh8wtfZFBQV6TWMXSb2ML0OgNwQRfHU= X-Received: by 2002:a67:f98c:: with SMTP id b12mr17668075vsq.39.1571063585463; Mon, 14 Oct 2019 07:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20191011205607.1743460-1-seth.howell@intel.com> In-Reply-To: <20191011205607.1743460-1-seth.howell@intel.com> From: David Marchand Date: Mon, 14 Oct 2019 16:32:54 +0200 Message-ID: To: Gaetan Rivet Cc: dev , dariusz.stojaszyk@intel.com, Seth Howell X-MC-Unique: vQTV934mMlSm7ifKtHWyYg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] rte_bus_pci: remove unneeded library dependency. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 11, 2019 at 10:56 PM Seth Howell wrote: > > The makefile in drivers/bus/pci specified rte_ethdev as a dependency for > the library. However there are no actual symbols from librte_ethdev used > in librte_bus_pci. > > Including librte_ethdev as a dependency only becomes a problem in some > niche cases like when attempting to build the rte_bus_pci library as a > shared object without building the rte_ethdev library. > > I specifically ran into this when trying to build the DPDK included as > an SPDK submodule on a FreeBSD machine. I figure that since there are no > real dependencies between the two, we should enable building > librte_bus_pci without librte_ethdev. > > Signed-off-by: Seth Howell > --- > drivers/bus/pci/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile > index 68c1f3fde..45d12427a 100644 > --- a/drivers/bus/pci/Makefile > +++ b/drivers/bus/pci/Makefile > @@ -25,7 +25,7 @@ CFLAGS +=3D -I$(RTE_SDK)/lib/librte_eal/common > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > > LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > -LDLIBS +=3D -lrte_ethdev -lrte_pci -lrte_kvargs > +LDLIBS +=3D -lrte_pci -lrte_kvargs > > include $(RTE_SDK)/drivers/bus/pci/$(SYSTEM)/Makefile > SRCS-$(CONFIG_RTE_LIBRTE_PCI_BUS) :=3D $(addprefix $(SYSTEM)/,$(SRCS)) > -- > 2.17.2 > At a first glance, this patch seems valid, Ga=C3=ABtan, could you have a lo= ok ? Could be worth a Fixes:. Thanks. -- David Marchand