From: David Marchand <david.marchand@redhat.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com,
nicolas.chautru@intel.com, roretzla@linux.microsoft.com
Subject: Re: [PATCH v3] test_bbdev: enable to be compiled on Windows
Date: Fri, 29 Aug 2025 15:07:38 +0200 [thread overview]
Message-ID: <CAJFAV8w-q58mxjir9a8-CiWFyOwjSRBB=Gsg9-BygqAdbAumZA@mail.gmail.com> (raw)
In-Reply-To: <1753122671-2645-1-git-send-email-andremue@linux.microsoft.com>
On Mon, 21 Jul 2025 at 20:31, Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> This patch fixes a few issues which were preventing this test from
> getting compiled on Windows:
>
> 1) VLAs were removed: Variable Length Arrays are not supported by MSVC.
> Where possible constant C arrays were used. Where that approach was not
> possible alloca() was called instead.
>
> 2) rte_os_shim is included because this test relies on getline()
> function, which is not provided by Windows APIs.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2025-08-29 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 15:24 [PATCH] " Andre Muezerie
2025-06-13 18:55 ` Chautru, Nicolas
2025-07-09 15:13 ` [PATCH v2] " Andre Muezerie
2025-07-21 18:31 ` [PATCH v3] " Andre Muezerie
2025-08-29 13:07 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8w-q58mxjir9a8-CiWFyOwjSRBB=Gsg9-BygqAdbAumZA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=nicolas.chautru@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).