From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/ioat: fix possible null dereference
Date: Tue, 26 Nov 2019 17:27:50 +0100 [thread overview]
Message-ID: <CAJFAV8w-qG_H=1G1hO=Ur4w5+WdaJ3kFOSFJMKvJRva8Mb3gFQ@mail.gmail.com> (raw)
In-Reply-To: <20191125164741.70488-1-bruce.richardson@intel.com>
On Mon, Nov 25, 2019 at 5:48 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> When searching for raw devices with the correct type, we check the driver
> name using strcmp, without first checking that the call to info get
> succeeded and assigned a value to that pointer.
>
> If the call to get the device info fails, we can treat it as if the device
> didn't match, and continue the loop, so the easiest fix is just to skip the
> strcmp if the driver_name is null. [A non-null value from a previous failed
> match is ok as it too causes the same behaviour of another loop iteration].
>
> Coverity issue: 350353
> Fixes: 2328542ed84e ("examples/ioat: add rawdev copy mode")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-11-26 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:47 Bruce Richardson
2019-11-26 16:27 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8w-qG_H=1G1hO=Ur4w5+WdaJ3kFOSFJMKvJRva8Mb3gFQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).