From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C2C9A04C9; Mon, 14 Sep 2020 10:37:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6EE241C0DA; Mon, 14 Sep 2020 10:37:27 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id E54551BE95 for ; Mon, 14 Sep 2020 10:37:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600072645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=br77VShOOakSPkX1uzfymTwd5V3V8+m4lykIMOnNaCQ=; b=LI9KSvDmdrcaCWPyPC9rqXflYOwJYM5xPpe7bD0LsCzLvSCE7s1p4A+XkFHT05QluGXs7F 2c+G54WAdyO7fish4USyAhaFGnG7O5Kmd5jW8pupNwntYGdzNzNxzHeqbTjkIfE8SmcWjj CHoK1QCrbHkJDQJ9eLm+v/p9+HtdF08= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-wlxq2B3KPE6jgZSWklI21g-1; Mon, 14 Sep 2020 04:37:22 -0400 X-MC-Unique: wlxq2B3KPE6jgZSWklI21g-1 Received: by mail-vk1-f198.google.com with SMTP id 186so4327538vku.4 for ; Mon, 14 Sep 2020 01:37:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=br77VShOOakSPkX1uzfymTwd5V3V8+m4lykIMOnNaCQ=; b=A4nepZUDflS5w8/q/1T20IHhi2g3iwm2EuwxWs5fXW+EQ9iPQp3Hg/YumO+i1C+st8 zg8NoupNWNyxjJhbOwTFAa4InskAm5h3PzWfYCLG+wl3ZYrHZ2KxNBfcdgox+SVx6v+4 +W11Dqcq28aCVkztfAlTaecIAywnG4O/CH4H+ch0EosMfexoN0qeHviZRhaVVJYuLx6y AL88cFicz/uo6cCTMIlX2bfDpzJdtvDg8QgG0aIGEJ5v2P12d8pTKkDUDDy+bWxXl1f5 CufzqCJ0Ju44914TBlcQhx20wwWttBr3FoOIzenv2l9CaGo3939j7fZIq56qw90vxCKZ p5Aw== X-Gm-Message-State: AOAM531inxueAmaWoiqGZFLCGt2frbUF17j6wVAzoomWvKJU14zqS01o If6mVJ3flTPPk5nEuxJsqAjJJjOwI8I43BlJWC0uLuVPmRh8bJYi0flKDI8pBqzotK9NKWom0Vs zDwRpkZkB2VMVT84Yvrs= X-Received: by 2002:a1f:4507:: with SMTP id s7mr6640187vka.9.1600072641802; Mon, 14 Sep 2020 01:37:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywK9L6LOfJ/jlzfGbUXyelYQtHlUQQFmx3/5n8P/EghUwO9NLRyYN8IflwmAzbkWz7YT+1QQEM1G2m65kFzLU= X-Received: by 2002:a1f:4507:: with SMTP id s7mr6640183vka.9.1600072641594; Mon, 14 Sep 2020 01:37:21 -0700 (PDT) MIME-Version: 1.0 References: <20200907162149.31454-1-harry.van.haaren@intel.com> In-Reply-To: <20200907162149.31454-1-harry.van.haaren@intel.com> From: David Marchand Date: Mon, 14 Sep 2020 10:37:10 +0200 Message-ID: To: Harry van Haaren Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] service: add component useful work attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 7, 2020 at 6:20 PM Harry van Haaren wrote: > diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h > index 9e66ee7e29..2caa7981b5 100644 > --- a/lib/librte_eal/include/rte_service_component.h > +++ b/lib/librte_eal/include/rte_service_component.h > @@ -87,6 +87,18 @@ int32_t rte_service_component_register(const struct rte_service_spec *spec, > */ > int32_t rte_service_component_unregister(uint32_t id); > > +/** > + * Set an attribute for this service. > + * > + * Note this API is to be called by the service implementation, to make the > + * statistic available via the usual attr_get() service APIs. > + * > + * @retval 0 Success > + * @retval -EINVAL Invalid service id or attribute provided > + */ > +int32_t rte_service_component_attr_set(uint32_t id, uint32_t attr, > + uint64_t value); > + The experimental tag is missing for this declaration. https://travis-ci.com/ovsrobot/dpdk/builds/183185060 http://mails.dpdk.org/archives/test-report/2020-September/150152.html > /** > * Private function to allow EAL to initialized default mappings. > * > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 0b18e2ef85..bb5e19ae9e 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -397,6 +397,9 @@ EXPERIMENTAL { > rte_mp_disable; > rte_thread_register; > rte_thread_unregister; > + > + # added in 20.11 > + rte_service_component_attr_set; > }; > > INTERNAL { > -- > 2.17.1 > -- David Marchand