From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D30E41E65; Fri, 10 Mar 2023 15:39:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC32740ED9; Fri, 10 Mar 2023 15:39:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8250140DD8 for ; Fri, 10 Mar 2023 15:39:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678459179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iq/cynw4aVJh+7cLjsE3XRPk6Zsw5EgKKxNibDDSQkQ=; b=AmktbJgYKC3YJbh0qRp4rEQIfEqvzqU3k9w1f/BQRXIZysZjCSANvBKYqdiLs4sIBZctvp 6iFq1ovOe0tNShdci5/Gau+OqRKOkwRFGapxn946eQ7rrdJFVDdvVF6MAMpNkeBW685iVY VdorwXZmTg6ure8FgUF+Vqj3TNObvFE= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-ZLyRrp0XPbSsNgE90Sb_Jg-1; Fri, 10 Mar 2023 09:39:38 -0500 X-MC-Unique: ZLyRrp0XPbSsNgE90Sb_Jg-1 Received: by mail-pf1-f197.google.com with SMTP id z19-20020a056a001d9300b005d8fe305d8bso2998804pfw.22 for ; Fri, 10 Mar 2023 06:39:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678459177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iq/cynw4aVJh+7cLjsE3XRPk6Zsw5EgKKxNibDDSQkQ=; b=wAb1cSM6hw1oSBbNLamQFQ4ZPqb7qoitvBAQLORMx+YKjio+AvsJimy+isw6zqfZAq 2eRLIDECoES8F4/LRapLPzGFnApcNh+jj3jINKf3Nodz9klR0EZkdY/jumUUyQvhaIRo 5lFI82dZQLQrXmIF93J6RqXvoFw9amdL1l129WAfa4DkjJG118m++qXIhc25nB28jVfl 71m5mulGyVtecBSsK00S4d9JT3q3BgL5a+yCRJqe8HA24uMiDRbyzZo4hnYLhnqMRGnt DZc/vWl59k71NL/PPquDWmH53u3HIMdVc3AzaWI55NVIEKgOBQbBfjC9shFuka1Oglwm umMw== X-Gm-Message-State: AO0yUKUuurrkR6lJCeqAfuMZo5yV2fZVeIxVM51Ww6TeR+fFxw2o9dsV sq3HHChYavq8CBBekRdcbFGcFT6PBvoHNANcXseHGJwv6zwjpmQYNW6YG4EJvoydARCHmg6X4Pw 80EVO3RZtdmhcL/Zdgsg= X-Received: by 2002:a63:b95b:0:b0:4fc:2058:fa29 with SMTP id v27-20020a63b95b000000b004fc2058fa29mr8522781pgo.1.1678459177690; Fri, 10 Mar 2023 06:39:37 -0800 (PST) X-Google-Smtp-Source: AK7set89n2hkvs8UeLXvVtHKtjER+54uYU0xnQLJvMFfXtRGjMppYhCcYsAMpFXJ6eEQm4evtuXuBWIJb9+X0Zidcto= X-Received: by 2002:a63:b95b:0:b0:4fc:2058:fa29 with SMTP id v27-20020a63b95b000000b004fc2058fa29mr8522765pgo.1.1678459177393; Fri, 10 Mar 2023 06:39:37 -0800 (PST) MIME-Version: 1.0 References: <20230309144249.1199517-1-yogesh.jangra@intel.com> <20230309083109.01baaebb@hermes.local> <10c16ee4-1c6c-8686-00a6-b5628f415267@amd.com> In-Reply-To: From: David Marchand Date: Fri, 10 Mar 2023 15:39:26 +0100 Message-ID: Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports To: "Dumitrescu, Cristian" Cc: Ferruh Yigit , Stephen Hemminger , "Jangra, Yogesh" , "Singh, Aman Deep" , "Zhang, Yuying" , "dev@dpdk.org" , "R, Kamalakannan" , "Suresh Narayane, Harshad" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 10, 2023 at 3:37=E2=80=AFPM Dumitrescu, Cristian wrote: > > > > > -----Original Message----- > > From: David Marchand > > Sent: Friday, March 10, 2023 1:49 PM > > To: Dumitrescu, Cristian > > Cc: Ferruh Yigit ; Stephen Hemminger > > ; Jangra, Yogesh ; > > Singh, Aman Deep ; Zhang, Yuying > > ; dev@dpdk.org; R, Kamalakannan > > ; Suresh Narayane, Harshad > > > > Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethde= v ports > > > > On Fri, Mar 10, 2023 at 2:48=E2=80=AFPM Dumitrescu, Cristian > > wrote: > > > > Why not fix the misbehaving drivers, instead of working around for > > > > softnic, as Stephen suggested? > > > > > > > > Is there a list of problematic drivers? > > > > > > > > > > Ferruh, I think this is not a reasonable request. We don't have the e= xpertise to > > fix all drivers, not the hardware to test all drivers. > > > > Then, please report the issues. > > I am also NAKing this horror. > > > > > > -- > > David Marchand > > Hi David, > > Your ideas on how to fix this issue would be way more helpful than your N= AK=F0=9F=98=89 Well sorry, but Ferruh request was reasonable to me. Trying to drop the ball made me a bit angry. > > Can you please explain why this fix is a problem? We have device X that s= its on top of devices A, B, C, ... who are created and started before devic= e X, to me it makes sense to stop device X first before stopping A, B, C, .= .. There are other drivers like the failsafe driver that sit on top of other devices. I'd recommend looking at what it does. --=20 David Marchand