From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45FFEA0543; Wed, 14 Dec 2022 11:35:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E37FB400D6; Wed, 14 Dec 2022 11:35:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 60B5C4003F for ; Wed, 14 Dec 2022 11:35:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671014111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UBCd1VkN4JEp0EPciC8RBSO20QoIxTbqj5+ke9zRpXM=; b=AVBUH3hjkDfaNDADLrdIHMk1EnuvJ78VtE4yyCYooAytUplxTMdk+81b+5Z+W6uQVbyBoj Xa6qzKlpP6BPCAOx+HHLohhhrbySew27N5+gQ6nQNtT8COYVx2nQ6N0FSLH4AzYEZs5qq5 K3USTC+ysl+Un8hBBQXl4Newi6aYI4U= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-437-r9w4tdntO7WCtGM-IADqOw-1; Wed, 14 Dec 2022 05:35:10 -0500 X-MC-Unique: r9w4tdntO7WCtGM-IADqOw-1 Received: by mail-pl1-f197.google.com with SMTP id jc4-20020a17090325c400b00189ceee4049so2286044plb.3 for ; Wed, 14 Dec 2022 02:35:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UBCd1VkN4JEp0EPciC8RBSO20QoIxTbqj5+ke9zRpXM=; b=n0SErkp39Deib1t7j9uTpjwYTibMJD2V1uqO+TNZF4hvPN0O7DpgQJU5UcK4tIVBZ5 8GCByP7lNlNXJq01b7JvZ7/IRbaJPDv9Mmor0dGrmNitWTPXYhpHVjkrB2w3PWjXcavB ItfR5JQGpRlEptPSLIFp28l+MGXop19Y7tWtPM9sWDuZ2FlcbJfBveW11fV7YMuIsHwl ICfh8fjzY0xiwiYM0JrVYgTn2cQBeRnQZFNqq03FH172hCWTtjIm2wNvSctfv9XOTqw3 Y355jAg1qxwPFR4spRtTsaFNdG8m2kdSMqRs1TF+V2fdYZMj+PPYHIR+M6XuHfnW6Vny BFPQ== X-Gm-Message-State: ANoB5pksaUOFtxduqG9YXjjddvWWtZGtyWt7We/7f1w0ekUjuF2pa1mn hfd9RbzIOyviBMkRhs8P/7HEr39vYiIikgYqpqGqkCwByJCw+ccW9e8WKwLvCSytXol35QVyScw +vJim8NYC+TVYF8jRdlg= X-Received: by 2002:a17:902:7688:b0:186:971b:b7e5 with SMTP id m8-20020a170902768800b00186971bb7e5mr95934028pll.54.1671014109323; Wed, 14 Dec 2022 02:35:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf7/DcJJUIvhpFBKFINIxio1PriEuoJZqhhJbM3E4WtaKGzKV5jgMqm1GdRNyGVAHlc3Rbk+WsEQ0t5+VHxTQcc= X-Received: by 2002:a17:902:7688:b0:186:971b:b7e5 with SMTP id m8-20020a170902768800b00186971bb7e5mr95933970pll.54.1671014109018; Wed, 14 Dec 2022 02:35:09 -0800 (PST) MIME-Version: 1.0 References: <20220929102936.5490-1-adwivedi@marvell.com> <20221006151844.23483-1-adwivedi@marvell.com> <20221006151844.23483-2-adwivedi@marvell.com> In-Reply-To: From: David Marchand Date: Wed, 14 Dec 2022 11:34:57 +0100 Message-ID: Subject: Re: [PATCH v3 1/4] ethdev: add trace points To: Ferruh Yigit Cc: Ankur Dwivedi , dev@dpdk.org, thomas@monjalon.net, mdr@ashroe.eu, orika@nvidia.com, ferruh.yigit@xilinx.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, andrew.rybchenko@oktetlabs.ru, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 12, 2022 at 7:38 PM Ferruh Yigit wrote: > > On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: > > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > > index 3651ceb234..79d0b2ee1f 100644 > > --- a/lib/ethdev/version.map > > +++ b/lib/ethdev/version.map > > @@ -319,4 +319,148 @@ INTERNAL { > > rte_eth_representor_id_get; > > rte_eth_switch_domain_alloc; > > rte_eth_switch_domain_free; > > + __rte_eth_trace_add_first_rx_callback; > > + __rte_eth_trace_add_rx_callback; > > + __rte_eth_trace_add_tx_callback; > > + __rte_eth_trace_allmulticast_disable; > > > These are not trace functions, but trace point objects, I see this is > common usage in other libraries too, but can you please explain why we > need to export the trace point objects from the .so file? > > For some datapath functions, which are static inline functions, trace > point objects are need to be accessible by application, it is OK to > export them, but they are very limited, but I am not clear why exporting > all of them is required. There should be no need to export them. The only usage I can think of is when calling a tracepoint from a public inline helper. -- David Marchand