From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C33DA04DC; Mon, 19 Oct 2020 16:54:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 638FCE310; Mon, 19 Oct 2020 16:54:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 126F9E271 for ; Mon, 19 Oct 2020 16:54:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603119249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dkKgW1BEwCRmuZzODEi3LFoRFnNt2fhVV1KF8dDy948=; b=SisdyfqxlLWD1vU+1ZCTyAzpE/bXxJoavWgzLR+cZ4PzEwEsvatjkHVJKxdYx5F3NJsJqo t2Mj1LN9AgUnG6K3byaDjMsp4UR6b78mj4KpTfor4z7/Q6i0klAo244qX//D9Ml3RheGYC LLFoE5ZoBz1qWQUsp2LC8d8G4OuV+is= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-S1QVO1eKN2CPRqEUfz-B4w-1; Mon, 19 Oct 2020 10:54:07 -0400 X-MC-Unique: S1QVO1eKN2CPRqEUfz-B4w-1 Received: by mail-vk1-f199.google.com with SMTP id w131so34662vkd.7 for ; Mon, 19 Oct 2020 07:54:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dkKgW1BEwCRmuZzODEi3LFoRFnNt2fhVV1KF8dDy948=; b=tlqMNzl4qJrfkbV63nMNw4WhWbdWEgbmcuYIcMPpDgcDhgtzQZHUWTnLSJ/Wp1wV6Y 3wymlmI/+KQMuq/Ab5MG8uYexze0wvzIkNfeUm7bMy+w/BuRUZQWqBRpUpe4RrtU0oI8 Eah5fL9XbBhieDQHl5UyoCHkknsGu/0iju043KRycnT2R56OrkMCcNmN4L3h296Dl3jI fFkhyu85cWlXv2k2pjotm6GPMNHJo1q7iDUn8zU3A7KGiltnGXkr3zXI+zvGAY0aAy2R pK4HxTV2dvOkKO/WRVDYXuosNlBBrCv5NJLDzLOkKbjLM8kb2tQyn5mHEmvs9h/AHc63 29SQ== X-Gm-Message-State: AOAM532pHQ5I5Idp4wLc2dEPJCY5/nOxUj1DRemvlnxXsqD1+4NcXSlp vJYW2Bgqky5ra0Zc2VUgCq+dVgMaUwtQH53ZmdXa5kMApnTs0FQjx4EUqS+725lBoe9IenKspJ5 ajQrmOyFZx6fVupe4W04= X-Received: by 2002:a67:e2d5:: with SMTP id i21mr110101vsm.18.1603119247168; Mon, 19 Oct 2020 07:54:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgnqewTU+6ExpEgsHVrS39fB/crqRR1S/UU6YfjaCtGEVg/vJ6WbvdzK5a6PBJbTS6cb702C+78oLruemBD/4= X-Received: by 2002:a67:e2d5:: with SMTP id i21mr110090vsm.18.1603119246995; Mon, 19 Oct 2020 07:54:06 -0700 (PDT) MIME-Version: 1.0 References: <20200907081518.46350-1-ruifeng.wang@arm.com> <20200915160224.GA825@bricha3-MOBL.ger.corp.intel.com> <81eb8fde-cd4f-1df9-0ebb-05c902b30fe3@intel.com> <48834549-00e9-b762-4915-9a2dd0e5fe1d@redhat.com> <6497770e-9d1c-97c3-3834-84bd96186836@digirati.com.br> <18c44f31-abc0-c0b5-c2fb-76d6166d5237@digirati.com.br> <9197371c-5e03-4852-d62a-6456f0b762f0@intel.com> <9647f80d-53c3-33aa-b6d0-301aef34ca0a@intel.com> <781ddbaf-cfed-bc90-cf6c-2b88bfda1202@digirati.com.br> <505d3e00-717b-25f8-ffea-d6108165a12a@intel.com> In-Reply-To: From: David Marchand Date: Mon, 19 Oct 2020 16:53:56 +0200 Message-ID: To: "techboard@dpdk.org" Cc: "Medvedkin, Vladimir" , Michel Machado , Kevin Traynor , Ruifeng Wang , Bruce Richardson , Cody Doucette , Andre Nathan , Qiaobin Fu , "thomas@monjalon.net" , "dev@dpdk.org" , nd , Honnappa Nagarahalli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli wrote: > > > IMO, this is not a performance critical path and it is not a difficult solution to > > store these values in the application. My suggestion is to skip adding the API > > and store the values in the application. > > > Vladimir, what's your opinion? > > > > Agree. Global vars or part of a global configuration could be used here. > Thank you. I think we are fine to go ahead with merging this patch. I saw Honnappa and Kevin acks, are other techboard members aware and okay with this change? Thanks. -- David Marchand