From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2243441C30; Tue, 7 Feb 2023 14:48:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE27C40E6E; Tue, 7 Feb 2023 14:48:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id ECA7B4021F for ; Tue, 7 Feb 2023 14:48:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675777700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dYx0U+As2aFiEFVJQ42qY2iz2NMhFkxQEeRfcmtobuU=; b=eGqIAnD32WTxnrtDK3WK5dEhJZ6PBKsCNSh25G1bTIHXOAftoaITULw9XL7LKjwC8rdAqJ 1XQ19eGIp2ZLmzZx0x8m/f+DgUreinImTsLZtKICpiM8P3ZBbL7j6HCb14lvRr0mgaiJnA yz8yJrV6mFlrXaucN3HkfPz2cb1Tc70= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-550-uWrduWTDNa6WMZx3or6tPQ-1; Tue, 07 Feb 2023 08:48:19 -0500 X-MC-Unique: uWrduWTDNa6WMZx3or6tPQ-1 Received: by mail-pl1-f197.google.com with SMTP id i3-20020a170902cf0300b00198bc9ba4edso8225967plg.21 for ; Tue, 07 Feb 2023 05:48:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dYx0U+As2aFiEFVJQ42qY2iz2NMhFkxQEeRfcmtobuU=; b=PWLNL9IQjKwQuXwUtvXDnSdXRYc7TdX9c165eMI8SNsQlhroifTqYyPtXbbPR4yezR PpPEs1wYAKWaJaIDBpYDjXNL9sDemQR2on8NT8NXqFgyT+dBdkFJQM0jm19kCr8tPKLF XrMAiPo6P9tZGz30FskrdiDa2sBcs/nZgPR0gak9HlZUXQt0n1yw6uLQxE50eMYXgPSd vXcpB6RUHKXiKh/VNYmEcGvtKooRJzP//GQ67iHGYuYPdp6XY7WVvCIGk3zfbWp4Ymrx uoj5mjOkJBE8zp1TSg9VvzPTtDH7H46D1OuZBhrqor83R9ZMgO/ImpSB8mUAfcEr825X vYbg== X-Gm-Message-State: AO0yUKVA00Ws9+3WGnf5XXVZcZHhI/4C0T6wdC+iCM4r3Gb8lhpTVNbj QtXBnOedTtG1m0SZGgoVmQHzGG59Rii2ZhaN4rDp4vlRq7WN+Oqu2fof0F/tPMHG40N9mkQPj4v LEHhSn6FzJigeeIqlGzA= X-Received: by 2002:a17:903:2796:b0:199:1faa:1b75 with SMTP id jw22-20020a170903279600b001991faa1b75mr713428plb.32.1675777698073; Tue, 07 Feb 2023 05:48:18 -0800 (PST) X-Google-Smtp-Source: AK7set+EbUDXPqo+sDTXpVO4xESrXHn35PuwcOvOvaWte9+Ulzec3Mpvky48n/QM/0AMkPnIsOJnXTi1hIqa1cszQco= X-Received: by 2002:a17:903:2796:b0:199:1faa:1b75 with SMTP id jw22-20020a170903279600b001991faa1b75mr713422plb.32.1675777697826; Tue, 07 Feb 2023 05:48:17 -0800 (PST) MIME-Version: 1.0 References: <20230107151230.2539470-1-vfialko@marvell.com> In-Reply-To: <20230107151230.2539470-1-vfialko@marvell.com> From: David Marchand Date: Tue, 7 Feb 2023 14:48:06 +0100 Message-ID: Subject: Re: [PATCH] bus: fix leak for devices without driver To: Volodymyr Fialko , Kevin Laatz Cc: dev@dpdk.org, Bruce Richardson , =?UTF-8?Q?Morten_Br=C3=B8rup?= , jerinj@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jan 7, 2023 at 4:12 PM Volodymyr Fialko wrote: > > For devices not assigned to any driver, we leak a pci device object since > it is never freed from the PCI bus device list, reported by ASAN. > > Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Worth copying stable. > > Signed-off-by: Volodymyr Fialko At a quick glance, the fix lgtm. Kevin, can you double check this fix thoroughly? Thanks. -- David Marchand