From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9551FA2EFC
	for <public@inbox.dpdk.org>; Tue, 15 Oct 2019 10:46:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D26761EA5A;
	Tue, 15 Oct 2019 10:46:11 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id CEC5C1EA3A
 for <dev@dpdk.org>; Tue, 15 Oct 2019 10:46:10 +0200 (CEST)
Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com
 [209.85.221.198])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 1992AC057F20
 for <dev@dpdk.org>; Tue, 15 Oct 2019 08:46:10 +0000 (UTC)
Received: by mail-vk1-f198.google.com with SMTP id 70so7994015vkc.7
 for <dev@dpdk.org>; Tue, 15 Oct 2019 01:46:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=+zQY7y0/bGnPxE/47G0AHlkUcGW+a5hC//uD5kHnRzM=;
 b=uRXv1NH8uivlCI7r4OeJJUWVhdhQQsdN3PbIWBjmnxtlDkNXwZZ/72gWWCq9S6XAPc
 h/EFlkS4bOluI6Gft6pLJbyXfKTHMmaIl4hw6bvUQdfhLsbb3oo9oJ23A3BpcKfKWPF/
 dDq/4B8bvw/yugpjI6nC05pG+wKVVSe7bPWj6SHLevsdoBdiiNzYrJ2hZWJ9JFLFy52p
 K00IinABVe5flGV7sR/hqrM6B/gkpC0iPb7dcx3jlDmHLEnhFk426CEjMOGuIfhrMT3a
 x3B4BUqAZYZd9yNlzD7pskEOARAZ5kal+/RynrEunNqQu5Qb4IHCpU8zuL2EJzQraTqb
 l26w==
X-Gm-Message-State: APjAAAWnJbWZ3zezT/CNMwTb8y3B2PXkT6XlISonEg4+V5il/R3iNq3O
 xMXjDYnFnYtb+cnHMsY3FJNZLuLR9e6cJfipxrqAx5BBf05yZOMXACa9inryT66p4yT31/22z80
 XBUh7YV6u2BsEpBmFn6w=
X-Received: by 2002:a1f:a748:: with SMTP id q69mr18451154vke.80.1571129169292; 
 Tue, 15 Oct 2019 01:46:09 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwpSeE9jCEvm+3WzEtVaDs6pwM3V/kAb/SnDhoD9ZynHWZrv+swfY1TM0Be0upw/yaxVVOH0/aV5h6MX9u1+1k=
X-Received: by 2002:a1f:a748:: with SMTP id q69mr18451141vke.80.1571129169032; 
 Tue, 15 Oct 2019 01:46:09 -0700 (PDT)
MIME-Version: 1.0
References: <20190903191645.1700-1-pbhagavatula@marvell.com>
In-Reply-To: <20190903191645.1700-1-pbhagavatula@marvell.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 15 Oct 2019 10:45:58 +0200
Message-ID: <CAJFAV8w1-TwKV5HoOhpG7BzUP_ZEa_nMUYCrN6JDw-eB-_h7tg@mail.gmail.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>, 
 dpdk stable <stable@dpdk.org>, Aaron Conole <aconole@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor
	is 32bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Sep 3, 2019 at 9:17 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix off by one error in 64bit reciprocal division when divisor is 32bit.
>
> Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Any review?

Are we missing an update in the unit test to catch this issue?
Thanks.

-- 
David Marchand