From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFD204235C; Wed, 11 Oct 2023 09:30:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47C8B402F1; Wed, 11 Oct 2023 09:30:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CCF17402A2 for ; Wed, 11 Oct 2023 09:30:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697009444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6L4tZAeysSCe9gGi2jA6huomBCFNxcsl5t6NA8qRUw=; b=YJhkEp8EOxiCUiNSWatVqH6zEdgNqJiqLPS66HB0isoBxer8vjUhXTnRsyCIg+utHIbp7b lowNfJsoxVFA5SPHsGK7uW0bACLRVFJG8u05xtabdmhiZ++8gQq6if/UMmPp9XpwejTHWT OtdoGLNUYhT7QNQsXRvU9xBUcMkqXKY= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-SxnChz4cPzakQlXlNzhdrw-1; Wed, 11 Oct 2023 03:30:42 -0400 X-MC-Unique: SxnChz4cPzakQlXlNzhdrw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c296e65035so56932361fa.3 for ; Wed, 11 Oct 2023 00:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697009441; x=1697614241; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l6L4tZAeysSCe9gGi2jA6huomBCFNxcsl5t6NA8qRUw=; b=iiFX0KbdbfqOX+dTpUf/LBQkFUKePnyxLxz7zuaVOmxt+nddc6E4kxA9bP+N/uqkYl Hds8xholliWXjmyxmpdBhpze1mHsuN2qqzouzumAkW7EPkCDyYcNCcdA9RqcgsfymYTo GCgJuu9xuvXguHlefWAD5TVOvrqk8JB6EKtWYnmHTQcPNXEy2TpUbZJhGGvGBgIq6OvQ 8SPNcjAfObRYZtSLNV1WeKdil9Mzh82mTewBTB5IIcjnKoo8mATRSzD3gJO3obTBF0rG o4qC7JP0K3Hoyxibh1dlvywmhUlB7rYSOOc4SKCzdR2+hbsKkP+Y+8D99bNQvJ+1m1ps TUtQ== X-Gm-Message-State: AOJu0YypLJXVp/JJYGKkwgQ9OhF2IDKz0rOkqIfjWyGJ0///IIVqbb88 6JNuLs8u5u5cpBHPTs8UcWxN+hueAzeNmafToaiELuRR9ODU5IiVH+vy0cHPmidMNFPWc66LSmo 0XMQT41eL3GjeMg6EsSG2+CV3RiSh7Q== X-Received: by 2002:a2e:90cc:0:b0:2bc:da3e:3bda with SMTP id o12-20020a2e90cc000000b002bcda3e3bdamr19319200ljg.2.1697009441450; Wed, 11 Oct 2023 00:30:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/6EBO+N+DifK7HloZ8KXUpQORfW/6yXqKrdnSttjYk4uZwbUp+eLu0EXrUj8jjdavvYRbdF1R7qXtkGDC/cg= X-Received: by 2002:a2e:90cc:0:b0:2bc:da3e:3bda with SMTP id o12-20020a2e90cc000000b002bcda3e3bdamr19319188ljg.2.1697009441097; Wed, 11 Oct 2023 00:30:41 -0700 (PDT) MIME-Version: 1.0 References: <20231010162635.755975-1-thomas@monjalon.net> In-Reply-To: <20231010162635.755975-1-thomas@monjalon.net> From: David Marchand Date: Wed, 11 Oct 2023 09:30:29 +0200 Message-ID: Subject: Re: [PATCH] doc: remove confusing command to send patch To: Thomas Monjalon Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 10, 2023 at 6:26=E2=80=AFPM Thomas Monjalon wrote: > > In the contributor guide, it was said that no need to Cc maintainers > for new additions, probably for new directories not having a maintainer. > There is no harm, and it is a good habit, to always Cc maintainers. > > Remove this case as it can mislead to not Cc maintainers when needed. > > Signed-off-by: Thomas Monjalon I agree Cc: maintainers should be the default / recommended way of sending patches. Just to convince myself, adding some meson skeleton for a "plop" library, adding an entry in the release notes and hooking in lib/meson.build: $ git show --stat doc/guides/rel_notes/release_23_11.rst | 4 ++++ lib/meson.build | 1 + lib/plop/meson.build | 2 ++ $ ./devtools/get-maintainer.sh 0001-new-awesome-library.patch In this case, it translates to an empty To: list if you follow the example command line: git send-email --to-cmd ./devtools/get-maintainer.sh --cc dev@dpdk.org 000*.patch We could add a default list of recipients if no maintainer is found by the script. And the next question is who should be in that list.. --=20 David Marchand