From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48BD4A0487 for ; Fri, 5 Jul 2019 10:03:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 360E31B99B; Fri, 5 Jul 2019 10:03:47 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id D78951B995 for ; Fri, 5 Jul 2019 10:03:45 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id v6so3302331vsq.4 for ; Fri, 05 Jul 2019 01:03:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ug3ylSSU5jTrDD3vALYEIBeivyhoXjFuE/4HJCu6rCQ=; b=sNN8hOfZ05jswyXHm7wCfEZ/h2yKRaWcZjNxlxGCotJgLga0E+AdVgciT4CcrP/gt9 5OrXtXkU2mg2iH1VIMUvuBC1WcrnK258lD1uSR2svrb6+4GgMqtqJZMCc+LPdpluA+pr yk+w6Jgnq3K3A8q8uNSzjjfpqXpN6Yjn58kgCcIYvP44kv9RGbOrwMbLLcqHoKABHsfR dPAfLxL2K2kfHDQCwRDgq96zXhIc9fLyJda0XwX2XV70DbhM+n39Z0XcolqIbMdBMoX5 vrSXuXpw/gmcokfRZ8MyD9tuAD0ZIgFzy3UCpuR+myqIeoWIdXsj6v9D/0cMwKKYMgDA h+rw== X-Gm-Message-State: APjAAAVArk1PniK1wBURLJrDctthiEyMMYWMowkcm3l5kdj6wq2LWquW V2V89yW0ztolm+cr/3iv8SZlhgxGYBZ98suqTam4Rw== X-Google-Smtp-Source: APXvYqyXfdaItFrH3WnCYIy7vsY9cZuuyjbqFfAMlz707C1Jy/HcTyEmkFAa129V/f44uHLoOFfIaQI4VJLjl6wQDGc= X-Received: by 2002:a67:da99:: with SMTP id w25mr1364376vsj.141.1562313825266; Fri, 05 Jul 2019 01:03:45 -0700 (PDT) MIME-Version: 1.0 References: <20190313170657.16688-1-ncopa@alpinelinux.org> <18966392.1bK43UoomU@xps> In-Reply-To: <18966392.1bK43UoomU@xps> From: David Marchand Date: Fri, 5 Jul 2019 10:03:34 +0200 Message-ID: To: Natanael Copa Cc: dev , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 00/15] Build fixes for musl libc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Mar 31, 2019 at 12:57 AM Thomas Monjalon wrote: > 13/03/2019 18:06, Natanael Copa: > > A set of patches to fix build with musl libc. I also did a few cleanups > wrt > > macros and fixed a few scary compiler warnings while at it. > > > > Please note that those are only compile tested on x86_64 with musl libc. > > > > v2 has some code style fixes reported by checkpatch > > v3 is a full reroll of the entire patch set to enable automatted tests > > and logic for patchwork patchset. > > > > Natanael Copa (15): > > app/testpmd: replace uint with unsigned int > > net/cxgbe: replace uint with unsigned int > > bus/pci: add fallback for out[lwb]_p for non GNU libc > > bus/pci: factor out various ifdefs in pci_uio_ioport_{read,write} > > bus/fslmc: fix compile error with musl libc > > bus/fslmc: remove unused include of error.h > > net/nfp: build fix for musl libc > > app/test: include fcntl.h due to use of O_RDONLY > > app/test: fix setting of -D_GNU_SOURCE with meson > > bus/dpaa: use warn(3) instead of error(3) to improve portability > > bus/dpaa: fix warning: "__WORDSIZE" is not defined, evaluates to 0 > > crypto/dpaa2_sec: build fix for musl libc > > crypto/dpaa2_sec: simplify pr_{debug,err,warn} macros > > net/netvsc: fix compile warning for fcntl.h include > > eal/linux: simplify debug message in sigbus_handler > > Thanks for the cleanup. > > Some patches may deserve more reviews. > If you send a new version, please use --to-cmd devtools/get-maintainer.sh > so the maintainers will be Cc'ed. > > All these patches are fixes and may be interesting to backport them > in the latest LTS or other stable releases. > In order to help with backporting, please fill "Fixes:" tag > and add Cc: stable when relevant. > The exact recommendation is described in this doc chapter: > http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body > > In order to help, I already fixed 7 commit messages and merged them. > The remaining patches, requiring a v4, are: > app/testpmd: replace uint with unsigned int > net/cxgbe: replace uint with unsigned int > bus/pci: add fallback for out[lwb]_p for non GNU libc > bus/pci: factor out various ifdefs in pci_uio_ioport_{read,write} > bus/dpaa: use warn(3) instead of error(3) to improve portability > bus/dpaa: fix warning: "__WORDSIZE" is not defined, evaluates to 0 > crypto/dpaa2_sec: build fix for musl libc > crypto/dpaa2_sec: simplify pr_{debug,err,warn} macros > If you intend to send a v4, I noticed a few more "uint" in the tree, I suppose this is worth fixing them: $ git grep -w uint app/test-pmd/config.c: uint hash_key_len) examples/tep_termination/vxlan.c: uint vport_id; -- David Marchand