From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06B2942BF4; Wed, 31 May 2023 13:49:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F32340ED7; Wed, 31 May 2023 13:49:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D10D040A82 for ; Wed, 31 May 2023 13:49:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685533757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C40epopsflMlbF7BmqmKkc+uvTSIWnojmf0rPLDbPkA=; b=B/SBTtBN5VMnSayRLHVcxZvk+0ZgXPh7xDRdcGiy0eKMwkwKJ8j6YKKK3q9e5+hWFyUa8N 1nMdOhEElWDZA9X1PmmgWlUs8fAvWDzOvRBwBb6YArRRI+RtIemM3z6gCSFCkbRz6e9fJD D8C0WvMvxmnYBbiIwLF9tAQi4K3XnYU= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-95VAtKRSNc-SOoLYqPXDtg-1; Wed, 31 May 2023 07:49:16 -0400 X-MC-Unique: 95VAtKRSNc-SOoLYqPXDtg-1 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-64d5cc4e53eso6444170b3a.2 for ; Wed, 31 May 2023 04:49:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685533755; x=1688125755; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C40epopsflMlbF7BmqmKkc+uvTSIWnojmf0rPLDbPkA=; b=a/w5RaBp80/qc8dfD1WP5R6QbqAr6SvTOhwCI1Cxy38EVfZ1DXoqIohBAb5TWRm5Tf 4EsM3GFGJ9SJ0T2EGtwEJCbY5tTPqjxCI2th+i21WnGP7bmpyAR5hO79q+QWzPlxoCTy dBNplyOCM+owpNuz3icfVPfqnb6Zzg6IS2xWBCZ7+ddc61dKIedJKChpa3D4OdeKVsjJ KCoBJVxzSoiOqq0CEGAUDumOIoWOyAQaa+G1yCax+ZUxLmWEjETnQMxBxkPgaRR2argM aH4smYiGZmauM5YU2yqRF0f/rG5pCHST+NG+E/nOM1VL0zCRangbfCAPtbLAxwuXMKPl l0PQ== X-Gm-Message-State: AC+VfDxrg7+F5JiPJgsVhJf2N/Ypen5+9FWwKze+Y38VvAg8kEV4RE1O 66dGk4g1ruD5D0UIRTeRI2kFxnlgF6qzZ9FxJRxpUaWbwRFsEdrAy4KAWgi6nXKkhPlJ44rCAhA KOFoMuso6OK9QqRZ6EE0= X-Received: by 2002:a05:6a20:4284:b0:110:9b0b:71b6 with SMTP id o4-20020a056a20428400b001109b0b71b6mr6789044pzj.37.1685533755310; Wed, 31 May 2023 04:49:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ61yKyT73i6pQsB8nbQwu6dE6CoxMGyze1Bdq4cLEpNVNo96ilVIXNYUVjAtSijlsmk4lri9fHnnNuwDG0XozA= X-Received: by 2002:a05:6a20:4284:b0:110:9b0b:71b6 with SMTP id o4-20020a056a20428400b001109b0b71b6mr6789028pzj.37.1685533755008; Wed, 31 May 2023 04:49:15 -0700 (PDT) MIME-Version: 1.0 References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431455219.558450.14986601389394385835.stgit@ebuild.local> <49ec9930-66b8-fc95-72ad-5cb012ed8635@redhat.com> In-Reply-To: <49ec9930-66b8-fc95-72ad-5cb012ed8635@redhat.com> From: David Marchand Date: Wed, 31 May 2023 13:49:03 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick To: Maxime Coquelin Cc: Eelco Chaudron , chenbo.xia@intel.com, Thomas Monjalon , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 30, 2023 at 3:02=E2=80=AFPM Maxime Coquelin wrote: > On 5/17/23 11:09, Eelco Chaudron wrote: > > This patch adds an operation callback which gets called every time the > > library wants to call eventfd_write(). This eventfd_write() call could > > result in a system call, which could potentially block the PMD thread. > > > > The callback function can decide whether it's ok to handle the > > eventfd_write() now or have the newly introduced function, > > rte_vhost_notify_guest(), called at a later time. > > > > This can be used by 3rd party applications, like OVS, to avoid system > > calls being called as part of the PMD threads. > > > > Signed-off-by: Eelco Chaudron > > --- > > lib/vhost/meson.build | 2 ++ > > lib/vhost/rte_vhost.h | 23 +++++++++++++++++- > > lib/vhost/socket.c | 63 ++++++++++++++++++++++++++++++++++++++++= ++++++--- > > lib/vhost/version.map | 9 +++++++ > > lib/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++ > > lib/vhost/vhost.h | 58 ++++++++++++++++++++++++++++++++--------= ----- > > 6 files changed, 171 insertions(+), 22 deletions(-) > > > > > The patch looks good to me, but that's the first time we use function > versioning in Vhost library, so I'd like another pair of eyes to be sure > I don't miss anything. > > Reviewed-by: Maxime Coquelin There may be some enhancement to do in the symbol check (wrt to the warning http://mails.dpdk.org/archives/test-report/2023-May/394865.html) but otherwise the versioning part lgtm. --=20 David Marchand