From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E688C45E8E; Fri, 13 Dec 2024 14:46:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE8D5409FA; Fri, 13 Dec 2024 14:46:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E98F6402BB for ; Fri, 13 Dec 2024 14:46:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734097591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vaO3hnpyghgxjtlWd3NJfASrEKiMNAlYBvnWiLQ0BH0=; b=NL5XnAFqHt1DrkZWe3cEFMSpeMhQhawnc/RTOEE9JhrFGf7WAUZj7CXLwAp2HJAmrH+X9z ZpCsqYQPgYiYE3txy/KdtyLeajAEpRmPbrhn7jKBac9aEMsbn5+8F667WUXtVarnexrqmb 3ldAOzs4YLD+h0jQBz3SXM2jtQQkpAg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-kWqMwHPQNROKkcfLsfFo_g-1; Fri, 13 Dec 2024 08:46:30 -0500 X-MC-Unique: kWqMwHPQNROKkcfLsfFo_g-1 X-Mimecast-MFC-AGG-ID: kWqMwHPQNROKkcfLsfFo_g Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ffadb24affso15494251fa.0 for ; Fri, 13 Dec 2024 05:46:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734097589; x=1734702389; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vaO3hnpyghgxjtlWd3NJfASrEKiMNAlYBvnWiLQ0BH0=; b=gF91+1DL4ks9Mu0TEhKKHrVPrqn7ncpc8WxakqbyoSyrAGLOTIddrNVdGhBTabZ8PN 4rpM9knSsF6L8m+a3KAi9UDlYh1okoaceoVO9HOoOwHeeCetpNtOeutb4DwStBiIZ3r7 BsPAyTI6UnmxywrM7fSUP1bgDZNyIBzoslGFpB+PKvwgUYl0TpH0tXzH8iKmaCKvHGnb MniYua2ZVYjpmbQIJ3tNe5rSg+ebnhiK03ZdsCttNRRd5Rh5MtCQFqWHVsFJZcAgVaDv IpRayTwFmCOUKrx8L4cjHzuMrLZpuydYMyo21w9Z5znnCkWThN19kkQAPAk9lbw5f8Lm 0rIA== X-Gm-Message-State: AOJu0YyIhxiEyB2rp6XvuVuP7mIjbHmqk96LuK8CjvL8Ro+pstP5iWg2 7Zg1Fgg/PqyM7DeJ1ye0NG89Xex16rw5ng+Dsd3T3eHjhyPvx8kypl6adcSj3crxCuz+ZX91v4z 18sNVRefpZgPaV3KjryUCKzUoYwK8dSlhiqPxkMVU2UiFpe3V/2hyL5P0ZXcH5obUcht4UNgYwA s2i4j3w1Zogc+SnLQ= X-Gm-Gg: ASbGncu/cll1BbdM/PVz5H49mV7vqAnWqyqnPjY7xL2P52sVXh3uYuNwh7eaTCehKXs L7ZN7J5l18w/CWa/Liu6q/m1axqQMfDNdkveTduZL X-Received: by 2002:a05:651c:1503:b0:302:1d85:1045 with SMTP id 38308e7fff4ca-30251cde519mr13116941fa.20.1734097587253; Fri, 13 Dec 2024 05:46:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IEHQIdYi5MbtMyUrvjC0nV9Mhg+l3248HQHFSBIyCeQPqCHm17LiNko4wY+224tTyf3b9audh3+dIvQSryZ7Zs= X-Received: by 2002:a05:651c:1503:b0:302:1d85:1045 with SMTP id 38308e7fff4ca-30251cde519mr13116751fa.20.1734097586802; Fri, 13 Dec 2024 05:46:26 -0800 (PST) MIME-Version: 1.0 References: <20241127112617.1331125-1-david.marchand@redhat.com> <20241213105010.1527683-1-david.marchand@redhat.com> <20241213105010.1527683-5-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 13 Dec 2024 14:46:15 +0100 Message-ID: Subject: Re: [PATCH v2 4/6] drivers: fix exported headers To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, Long Li , Wei Hu , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Hemant Agrawal , Sachin Saxena , Vladimir Medvedkin , Ian Stokes , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Jakub Palider , Tomasz Duszynski , Gagandeep Singh , Jingjing Wu , Stephen Hemminger , Akhil Goyal , Haiyue Wang , Jeff Guo , Michael Baum , Jerin Jacob , Shreyansh Jain , Nipun Gupta , Xiaoyun Li X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kCCyjAkkIphqjlzm9itYrNf7HSs2O7d2agclCgszGy4_1734097589 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 13, 2024 at 12:15=E2=80=AFPM Bruce Richardson wrote: > > On Fri, Dec 13, 2024 at 11:50:08AM +0100, David Marchand wrote: > > Those headers could not be included individually as they were not > > including their dependencies, or were subject to some build warnings. > > > > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > > Fixes: 5b2a1a02dcaf ("crypto/cnxk: fix experimental version for PMD API= ") > > Fixes: e5abbeeeefa5 ("crypto/cnxk: add PMD API for getting CPTR") > > Fixes: 3ca607402c4d ("crypto/cnxk: add PMD API to flush CTX") > > Fixes: 8c3495f5d2dd ("net/dpaa: support loopback API") > > Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction") > > Fixes: 23f627e0ed28 ("net/mlx5: add flow sync API") > > Fixes: f5177bdc8b76 ("net/mlx5: add GENEVE TLV options parser API") > > Fixes: 7cf197684589 ("raw/cnxk_bphy: support interrupt init and cleanup= ") > > Fixes: 633dae698070 ("raw/cnxk_gpio: add standard GPIO operations") > > Fixes: 53c71586c789 ("raw/dpaa2_cmdif: support enqueue/dequeue operatio= ns") > > Fixes: c39d1e082a4b ("raw/ntb: setup queues") > > > > Signed-off-by: David Marchand > > Generally LGTM, some queries inline below. > > /Bruce > > > --- > > drivers/bus/vmbus/rte_vmbus_reg.h | 6 ++++++ > > drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 4 ++++ > > drivers/net/dpaa/rte_pmd_dpaa.h | 2 ++ > > drivers/net/iavf/rte_pmd_iavf.h | 6 ++++++ > > drivers/net/mlx5/rte_pmd_mlx5.h | 3 +++ > > drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 16 ++++++++++++++++ > > drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 3 +++ > > drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h | 2 ++ > > drivers/raw/ntb/rte_pmd_ntb.h | 2 ++ > > 9 files changed, 44 insertions(+) > > > > diff --git a/drivers/bus/vmbus/rte_vmbus_reg.h b/drivers/bus/vmbus/rte_= vmbus_reg.h > > index e3299aa871..95c8eb29b4 100644 > > --- a/drivers/bus/vmbus/rte_vmbus_reg.h > > +++ b/drivers/bus/vmbus/rte_vmbus_reg.h > > @@ -6,6 +6,12 @@ > > #ifndef _VMBUS_REG_H_ > > #define _VMBUS_REG_H_ > > > > +#include > > + > > +#include > > +#include > > +#include > > + > > /* > > * Hyper-V SynIC message format. > > */ > > diff --git a/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h b/drivers/crypto= /cnxk/rte_pmd_cnxk_crypto.h > > index 02278605a2..2bb0ff9e95 100644 > > --- a/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h > > +++ b/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h > > @@ -11,8 +11,12 @@ > > #ifndef _PMD_CNXK_CRYPTO_H_ > > #define _PMD_CNXK_CRYPTO_H_ > > > > +#include > > #include > > > > +#include > > +#include > > + > > /* Forward declarations */ > > > > /** > > diff --git a/drivers/net/dpaa/rte_pmd_dpaa.h b/drivers/net/dpaa/rte_pmd= _dpaa.h > > index ec45633ba2..0a57e2097a 100644 > > --- a/drivers/net/dpaa/rte_pmd_dpaa.h > > +++ b/drivers/net/dpaa/rte_pmd_dpaa.h > > @@ -5,6 +5,8 @@ > > #ifndef _PMD_DPAA_H_ > > #define _PMD_DPAA_H_ > > > > +#include > > + > > /** > > * @file rte_pmd_dpaa.h > > * > > diff --git a/drivers/net/iavf/rte_pmd_iavf.h b/drivers/net/iavf/rte_pmd= _iavf.h > > index 56d453fc4c..04b86a5dd7 100644 > > --- a/drivers/net/iavf/rte_pmd_iavf.h > > +++ b/drivers/net/iavf/rte_pmd_iavf.h > > @@ -15,6 +15,7 @@ > > */ > > > > #include > > + > > #include > > #include > > #include > > @@ -184,6 +185,7 @@ __rte_experimental > > static inline void > > rte_pmd_ifd_dump_proto_xtr_metadata(struct rte_mbuf *m) > > { > > +#ifdef ALLOW_EXPERIMENTAL_API > > union rte_pmd_ifd_proto_xtr_metadata data; > > > > if (!rte_pmd_ifd_dynf_proto_xtr_metadata_avail()) > > @@ -243,6 +245,10 @@ rte_pmd_ifd_dump_proto_xtr_metadata(struct rte_mbu= f *m) > > else if (m->ol_flags & RTE_IAVF_PKT_RX_DYNF_PROTO_XTR_IP_OFFSET) > > printf(" - Flexible descriptor's Extraction: ip_offset=3D= %u", > > data.ip_ofs); > > +#else > > + RTE_SET_USED(m); > > + RTE_VERIFY(false); > > Is panicking the behaviour we want here? Seems rather severe, no? You are not supposed to call this symbol without building with ALLOW_EXPERIMENTAL_API. Another option would be to mark those symbols as stable (they have been untouched for years). 12b435bf8f2 (Jeff Guo 2020-10-30 16:40:30 +0800 186) rte_pmd_ifd_dump_proto_xtr_metadata(struct rte_mbuf *m) > > > +#endif > > } > > > > #ifdef __cplusplus > > diff --git a/drivers/net/mlx5/rte_pmd_mlx5.h b/drivers/net/mlx5/rte_pmd= _mlx5.h > > index fdd2f65888..f2c6aebe0b 100644 > > --- a/drivers/net/mlx5/rte_pmd_mlx5.h > > +++ b/drivers/net/mlx5/rte_pmd_mlx5.h > > @@ -5,6 +5,9 @@ > > #ifndef RTE_PMD_PRIVATE_MLX5_H_ > > #define RTE_PMD_PRIVATE_MLX5_H_ > > > > +#include > > + > > +#include > > #include > > > > /** > > diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_bp= hy/rte_pmd_bphy.h > > index f668e6ea82..c200c935ff 100644 > > --- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > > +++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > > @@ -391,6 +391,7 @@ rte_pmd_bphy_intr_init(uint16_t dev_id) > > { > > struct cnxk_bphy_irq_msg msg =3D { > > .type =3D CNXK_BPHY_IRQ_MSG_TYPE_INIT, > > + .data =3D NULL, > > }; > > > > Why is this addition necessary? Is it for C++ compile? IIRC, this is because DPDK meson passes -Wno-missing-field-initializers globally, and the Makefile I wrote does not. I'll double check. --=20 David Marchand