From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B517A0C55; Wed, 13 Oct 2021 13:08:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3B86410EB; Wed, 13 Oct 2021 13:08:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 24A1B410DA for ; Wed, 13 Oct 2021 13:08:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634123287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3YmskC+wwG1Ppa1TIdd/Q7oC9QAFSGQ8c9szFAacQeQ=; b=IG62kVmOevSpEFiUzkUNC50plHcizpPbSzN7bcOgW2ysT9zofHyD1erxGf+VOI/8dDDtn8 ykArjsiHWLYrxt2vILDDM0jDzu9YqmLKF6CO0TpAy+QP6PWG107X7Cw2IwzJEorVjdNs0G Ny+25+kFX/vLsk6vn5TP5YBozVZ+2Rk= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-1TMfPXyMMeyKVPn30ziRPw-1; Wed, 13 Oct 2021 07:08:04 -0400 X-MC-Unique: 1TMfPXyMMeyKVPn30ziRPw-1 Received: by mail-lf1-f70.google.com with SMTP id z29-20020a195e5d000000b003fd437f0e07so1655796lfi.20 for ; Wed, 13 Oct 2021 04:08:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3YmskC+wwG1Ppa1TIdd/Q7oC9QAFSGQ8c9szFAacQeQ=; b=4GF2wZ6yOv1uUAjlgqHCe0RqUYzGfzNgBG7Ku2+X53wEKlHFCHjRTnmdL/P8inBXaq VgUO1FqvJw4LLDdlrlLMzk5CLWT5kz4mg10G7C/oevXmW0fyE4u4va3lfjM6f5P6VGdQ lZ3rzgmwZNZbsHUW+AHDgk6GhGkDwB7jqQxEiiBgaLiF8xy70O4BpVTUz0JoMuwhMII3 qKND/Iyuqp7/4x0usPNPJ0xT+SHdyDIH0aZS9SdA5R89wpb8/PYPvImqzz74RabTxkqL pjyGb9LD9laFGczqIL2J1GDkH0pfcZbfoYZaMTTccM8cb+4ub+yvifD2S+C3Nm6NnWNt 7rqw== X-Gm-Message-State: AOAM531AuNLXKQzSlytMGYTlI48NtuxwFvS3WtprS+GQj3Vb+0CUGcEv R8GfuA/+WnLDxCpmu0o10Q+hIRXi7Dhc0o1mT9Pc2QoNqmEXOi7dKb1YXOSJ4dSX2HjBhgboqiZ HeRXGOEjAr27TNxfQrcw= X-Received: by 2002:a2e:a54d:: with SMTP id e13mr33409435ljn.159.1634123283110; Wed, 13 Oct 2021 04:08:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHlgYLOBvf5uftwC1r2yGVBJM3PmR8f0R8t1Jr3wSgTHibE3SKn9RUoSj1OZSK3OcheDdAks7z4TOUuwD7Qzg= X-Received: by 2002:a2e:a54d:: with SMTP id e13mr33409417ljn.159.1634123282913; Wed, 13 Oct 2021 04:08:02 -0700 (PDT) MIME-Version: 1.0 References: <20211013085723.1206789-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211013085723.1206789-1-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Wed, 13 Oct 2021 13:07:51 +0200 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , Zoltan Kiss , dev , Ray Kinsella , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko wrote: > > Use correct define as a name array size. > > The change breaks ABI and therefore cannot be backported to > stable branches. > > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") > > Signed-off-by: Andrew Rybchenko Reviewed-by: David Marchand Good catch, I guess we can clean ring too, quick grep: lib/ring/rte_ring_core.h-struct rte_ring { lib/ring/rte_ring_core.h- /* lib/ring/rte_ring_core.h: * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI lib/ring/rte_ring_core.h- * compatibility requirements, it could be changed to RTE_RING_NAMESIZE lib/ring/rte_ring_core.h: * next time the ABI changes lib/ring/rte_ring_core.h- */ lib/ring/rte_ring_core.h- char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned; -- David Marchand