From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 894AFA0353; Tue, 19 Nov 2019 21:59:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A89CBA69; Tue, 19 Nov 2019 21:59:09 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 0BBED2AB for ; Tue, 19 Nov 2019 21:59:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574197147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=93R56dEJUZEQNyFUVT3HJMQrpCpJrWno3vLr8oXxhFI=; b=Yi7x9CXHltuWZSae0NNR/SLoOYnGBQCzZaHB7eKzfJssbscVu3DBsfZmH8BFG9DiY4b3JD Q1qLWFvNFoxDH6xXPCWAwAvWi7QXHDwqMkKl+UCes5pBayJBfto4E6/t6G8sPFixQbMACB Ew9ntN76r11rFRCZoDyGH5+DzwA8BYg= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-186-OZxlGyciMJCgBXj5aQE8TQ-1; Tue, 19 Nov 2019 15:59:04 -0500 Received: by mail-ua1-f70.google.com with SMTP id o17so4493314uar.8 for ; Tue, 19 Nov 2019 12:59:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EI4DS7Hn3/+w/CI1jNNRlUdNpRHSBNdIIk1NNIbqObA=; b=X0JRGH6+fL6FTYjgkL6BgfUXJaNppx5i+C9KV41NMrDbZinftNN3Yd+caYNcvdJhcS AbFvn8jkZBcekFY1POwSd0oEjICsmx+vr6EtnUbmifo5zNHfvEbjwSzxLLwWpxj61vZ6 acKHcmGQasXbNGe9aW3wHK0PMS1LAJEDI/9QExBBgu15h/EUx1qJHEcsf54PaXd+a+d8 5C/zOOkLZpJEbArIMBMlhTgrgA8BNt5kJ1ws94VNskJ+ueYtLhGWS0v6Mrk6/NgYdW25 6d6yFcZSTyKDM4NFeLJbYp1N38+Df0WsWwkH7X3xkJDX7N0YP7caEC5ZDw6oo9QDJzv3 ZvJw== X-Gm-Message-State: APjAAAX9dKGpdFd3KOqyzH+UsPFnvZ3Zdsc7XUfNF7gu86WeqXagm0EM D6rVl6Ef6Yb3wnsiYr/e3/P2/74A/JP/SZCln12UnWB+5MPJuo4rks+GYBIbWkNlkqUqy2ra3o1 a+hsYRPpINFpiHIeLBU0= X-Received: by 2002:a9f:318b:: with SMTP id v11mr22428327uad.41.1574197143308; Tue, 19 Nov 2019 12:59:03 -0800 (PST) X-Google-Smtp-Source: APXvYqzp17H+1zk2Wip9qBFs6U8+nMGdtvH7Qw58kniGdc5twxaPI/6GucBUa4KODCmwBZgKUeztHdqbpwdP3dHB+PQ= X-Received: by 2002:a9f:318b:: with SMTP id v11mr22428304uad.41.1574197142921; Tue, 19 Nov 2019 12:59:02 -0800 (PST) MIME-Version: 1.0 References: <20191115114107.30737-1-michael.pfeiffer@tu-ilmenau.de> <20191115082328.71782fa3@hermes.lan> In-Reply-To: From: David Marchand Date: Tue, 19 Nov 2019 21:58:51 +0100 Message-ID: To: Ferruh Yigit Cc: Stephen Hemminger , Michael Pfeiffer , dev X-MC-Unique: OZxlGyciMJCgBXj5aQE8TQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] kni: reduce interface name size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 19, 2019 at 1:13 PM Ferruh Yigit wrote= : > > On 11/15/2019 4:23 PM, Stephen Hemminger wrote: > > On Fri, 15 Nov 2019 12:41:07 +0100 > > Michael Pfeiffer wrote: > > > >> The name in rte_kni_device_info is passed to the kernel, which allows > >> interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a > >> longer name currently trigger a kernel BUG in alloc_netdev_mqs in > >> net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation. > >> > >> Signed-off-by: Michael Pfeiffer > > > > Why not kill the NAMESIZE define in KNI and use the kernel one. > > > > > As mentioned in the thread, userspace doesn't know NAMESIZE, only kernel = module > does, because "linux/if.h" is only included by kernel module. > > I don't know if will there be any side affect of including relevant heade= r and > creating this dependency to the userspace, but I am not for taking that c= hance > for this benefit, the comment already clarifies the value and it is not > something that will change. We can still revisit this later. I will go and apply the acked v2 https://patchwork.dpdk.org/patch/63042/ --=20 David Marchand