From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 173B2A046B for ; Fri, 26 Jul 2019 09:24:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D66C1C3C3; Fri, 26 Jul 2019 09:24:32 +0200 (CEST) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 44F661C3C3 for ; Fri, 26 Jul 2019 09:24:30 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id u124so35482905vsu.2 for ; Fri, 26 Jul 2019 00:24:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wxx8TI0QJLkfHvehK/UHsQp2FkFT4U0ocW851HRpu80=; b=ONqglZHQ9xhCECEXV8NL9XYjT67yvVSFcfeSyD6xZP6coHe2AK+O1MoyH4orIjB1Eg UX5C8YLj6M7xxn2EhyosVVbrT7axZML1CavoQsAlbKqm2dgIlAKVxYPU2f8Q8Q0ygy9r 6trdECNzF9VOeliApZpVARXmt/0P5BXkmIQj0biU3337dvo1CbHnBZIj0zxa6OmYtXVN gYc19EaWqhA/4d4UROlX37g8tZYoL+M1/V/nL5Aa1fZkp4vZcS09prXYHxWcDkVzCsV9 HPNIwgniD/pRquTW56mGNvTeX7Bi3Gw5ATEJPcVPdSct5eg7aZviyfMVvq/iawVjdhnm AYjA== X-Gm-Message-State: APjAAAXtWj5IVJYnvrNdj760CuoRgTnIo76tENH6l//kmO11HRKGvvc8 prgCg5+ukDBqEnphslS5ESmoLVcqNJ4vGfvhnBWeCQ== X-Google-Smtp-Source: APXvYqz2qZPVp0oSU3BqbWnuQRDfBjMXEPKfHRHeD8D9G0uEQsOaYwOCChXvl+FFjyeWY3qSm7aT3813gxhJUUD9d9g= X-Received: by 2002:a67:f998:: with SMTP id b24mr9813393vsq.180.1564125868738; Fri, 26 Jul 2019 00:24:28 -0700 (PDT) MIME-Version: 1.0 References: <1564046068-21905-1-git-send-email-david.marchand@redhat.com> <1564046068-21905-6-git-send-email-david.marchand@redhat.com> <2cab227c-5e9d-00e1-a6c7-e8f02eb0f6e4@intel.com> In-Reply-To: From: David Marchand Date: Fri, 26 Jul 2019 09:24:17 +0200 Message-ID: To: Ferruh Yigit Cc: dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 25, 2019 at 9:07 PM David Marchand wrote: > > On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit wrote: > > > > On 7/25/2019 10:14 AM, David Marchand wrote: > > > err_pkts reflects the number of packets that the driver did not manage to > > > send. > > > This is a temporary situation, those packets are not freed and the > > > application can still retry to send them later. > > > Hence, we can't count them as transmit failed. > > > > 'err_pkts' seems calculated wrong both in Rx & Tx and KNI PMD, looks like we can > > remove it completely, what do you think? > > On the rx side, I agree that err_pkts makes little sense. > On the tx side, it can be seen as a "tx full" counter. > > So not sure about the tx side, but I sure can remove the rx part (in a > separate patch?). On second thought, we have nothing to report "tx full" for now (unless adding xstats support but it is too late for 19.08). I will go with dropping those bits if you are still okay with this (and idem with the others drivers for which you commented in the same way). -- David Marchand