From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 965BEA0524; Sat, 1 Feb 2020 16:30:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E15101C0C1; Sat, 1 Feb 2020 16:30:30 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 926091C0BF for ; Sat, 1 Feb 2020 16:30:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580571028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IzQD9BMOKPrmxWGE4oV6HdPwMIs8nQQ99/aNbNWvtdg=; b=F0JaQ+5YmpjeohJW4+AjGIVtOzvttu+uqRkeIg9Zb38iYNETXfisFYMPL7TdiIFbhkmPNb 13urMAeTT/A8xlvWKxWUQxBIlJ35GZ+6WRlBubXqQfIEGCYJ70k6sLTFeeU9ok/qESqYTT 2xDOIhVqy+te3Cgl7ypFGNjIUF4pu4o= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-117-Tj7LO5yaNZCdqfa7WhZUMw-1; Sat, 01 Feb 2020 10:30:26 -0500 Received: by mail-vs1-f69.google.com with SMTP id x15so986334vsq.22 for ; Sat, 01 Feb 2020 07:30:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zy2puKXOfj64dZHrZl+lSRiHOK4n40zBo/0lrqFfF74=; b=RcBHxy8X7Tg3Yf+qgdF0N/BX683jzMKcjyMgKv4nilf1gYAgDCR+vQ78aNEHgGyNqc aP31JV60yNjMjvL4z1mG2Z0OLbq9rGIpWYCIYIviVF8tmvjCuvhvC+I4r/MFFdqzkDg/ 8FukArLtq+8SwKQ9BNoAwDbQZfarBWKc9pCYXGRMMFn8Ea66FqEMNY2KM2kO/AWPjkzB i7oyzlU31QtHesa07yiytUaWGsvE1G8M0Tje3PbdV5IcXljO/0k2DRnzU1/TX7mSOldo RvdhN6v79Rn365NdD+S7RNqiPrrzay70XJZIb/qnyNElRBLLk0xJr4KLSeGkz3ovd7Ho zy2A== X-Gm-Message-State: APjAAAX1GAHkmkzP4uq2scwORRIEK+A1AxTUafee0lAso2+TwZyrebPy DCp5hOYZKRaabzlgN9HL3+/9maJQlqJLyzGsLDRG8bCqQUO1Z1IkbGwC5cb2qON8Kd9cBZgwNp2 roGvWGz89oIH+xo0Ne4U= X-Received: by 2002:ab0:2408:: with SMTP id f8mr9053508uan.126.1580571025965; Sat, 01 Feb 2020 07:30:25 -0800 (PST) X-Google-Smtp-Source: APXvYqyVC+L53f7cTGwp/QJwAWvqRy+rqeWGGzolY1xcmz4xPaJ8dVPHtDxhuE0qikQi0oYKH5OM3y3765rgsDmi9x4= X-Received: by 2002:ab0:2408:: with SMTP id f8mr9053495uan.126.1580571025743; Sat, 01 Feb 2020 07:30:25 -0800 (PST) MIME-Version: 1.0 References: <20191220152058.10739-1-david.marchand@redhat.com> <20200130160009.6549-1-david.marchand@redhat.com> <20200130160009.6549-5-david.marchand@redhat.com> <1698714.yIU609i1g2@xps> In-Reply-To: <1698714.yIU609i1g2@xps> From: David Marchand Date: Sat, 1 Feb 2020 16:29:32 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Kevin Laatz , Aaron Conole , Neil Horman , Akhil Goyal , Anoob Joseph , Luca Boccassi , "Trahe, Fiona" , "Yigit, Ferruh" , Michael Santana , John McNamara , Marko Kovacevic X-MC-Unique: Tj7LO5yaNZCdqfa7WhZUMw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 30, 2020 at 11:33 PM Thomas Monjalon wrot= e: > > 30/01/2020 17:00, David Marchand: > > Enabling them requires a configuration that will trigger the ABI dumps > > generation as part of the existing devtools/test-build.sh and > > devtools/test-meson-builds.sh scripts. > [...] > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > if [ -f "$builddir/build.ninja" ] ; then > > + # for existing environments, force debugoptimized so that= ABI > > + # checks can run > > + $MESON configure --buildtype=3Ddebugoptimized $builddir > > This is forcing meson to re-run each time, even if the buildtype is > already "debugoptimized". > Please query meson configuration to avoid useless re-run: > > $MESON configure $builddir | awk '$1=3D=3D"buildtype" {print $2}' > > Good catch, will fix. --=20 David Marchand