From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99EC143B27; Wed, 14 Feb 2024 08:37:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C72442E51; Wed, 14 Feb 2024 08:37:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3722B40263 for ; Wed, 14 Feb 2024 08:37:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707896227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h+t6ndx6qw9JXaFERrKhqHuSAZIQCY4MNDsqskRfX3w=; b=ctCf/U8OFSe5A0DU5MJbeyEMbVOG1bv6NP9b0ZMe0V9LG7FBl9vlIzFA0ijJSZLumhmdg+ Y/8aTSgBaZ5aLDiuBLO5cxWqBgg4X+ScJ7hSi6p+M2s/+H5J0bI03uaDwj5L3AQ+zkafyH HUjHd4w/uPLouCxBSHDYxEcDRmqnAzw= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-potveibZPMevpO_dWi3_Hw-1; Wed, 14 Feb 2024 02:37:06 -0500 X-MC-Unique: potveibZPMevpO_dWi3_Hw-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50ec9529001so5299694e87.2 for ; Tue, 13 Feb 2024 23:37:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707896225; x=1708501025; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h+t6ndx6qw9JXaFERrKhqHuSAZIQCY4MNDsqskRfX3w=; b=EJX/mtg/7Bq5J21ebZVRmb6Chy4AaPYdxYIZBDRhIUF2YKw8Cts0dyvFpbBbyqU25o q1yuJj7zWMxyM1T1iTzD+FzDp9iJJgPdEFoqxhe38h48UUTpG1go+6zss4NIzrvMJVQg phpjpoL895gvuojcm8i21a2aeu7mY+EJ0f9GqumT9VCMolh9PDjA4/HYzHJlJEPpffFM jntkhGitD5fmIij/6hU6/AWMIfA8sIwFkvDgchR3MRmkgGTlAYBBYKhbTxYF7YCxutxp rWp/S1WD5MPTEJBrHLQOlTs6XAu841kDmM5PtDyshjccOukHUGK0jj4nusM0HaMymir8 xm+w== X-Gm-Message-State: AOJu0YzYi6kFZMuUAzePOWbSZteSmC3NtAppJi3iSbYAYx8OPZtKAdBK y8BWl7dBTLBXsZAfXQ0qIZavwcUDajb1VeyE4xDuHuqultKns5Odz1VJ5OyDgv4gNlIL6zXmO4r oPWbk7+NouhgbspDLtNEFIw4vZ2G86nlo6kPdBAgENrNJ0Xsq2R+hj3fddrbUJ0u3xB5bd4ApTV /z0Yd1rb54mAwsduU= X-Received: by 2002:ac2:530e:0:b0:511:53fa:b971 with SMTP id c14-20020ac2530e000000b0051153fab971mr1209534lfh.9.1707896225083; Tue, 13 Feb 2024 23:37:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1nuz3sS7rPCtdZjdpnNZi7o8lqj5vX76Xs8z8cNriiNNxNhlUAa8svQC04U8RReA/yXA4+Uulbo6C876e+6o= X-Received: by 2002:ac2:530e:0:b0:511:53fa:b971 with SMTP id c14-20020ac2530e000000b0051153fab971mr1209519lfh.9.1707896224767; Tue, 13 Feb 2024 23:37:04 -0800 (PST) MIME-Version: 1.0 References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com> <1707777366-26000-1-git-send-email-roretzla@linux.microsoft.com> <20240213192042.GA24086@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240213192042.GA24086@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Wed, 14 Feb 2024 08:36:52 +0100 Message-ID: Subject: Re: [PATCH v2 0/4] more replacement of zero length array To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Cristian Dumitrescu , Honnappa Nagarahalli , Sameh Gobriel , Vladimir Medvedkin , Yipeng Wang , mb@smartsharesystems.com, fengchengwen@huawei.com, Dodji Seketeli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 13, 2024 at 8:20=E2=80=AFPM Tyler Retzlaff wrote: > > On Tue, Feb 13, 2024 at 02:14:28PM +0100, David Marchand wrote: > > On Mon, Feb 12, 2024 at 11:36=E2=80=AFPM Tyler Retzlaff > > wrote: > > > > > > Replace some missed zero length arrays not captured in the > > > original series. > > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D30410&state=3D= * > > > > > > Zero length arrays are a GNU extension that has been > > > superseded by flex arrays. > > > > > > https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > > > > > > v2: > > > * added additional patches for fib & pipeline libs. > > > series-acks have been placed only against original > > > hash and rcu patches. > > > > There seems to be an issue with the ABI check on those changes. > > After a quick chat with Dodji, I opened a bug for libabigail. > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=3D31377 > > I double checked again and I don't see the struct in question being > embedded as a field of another struct/union. So I don't think there shou= ld > be an ABI change here. That was and is still my understanding too. The message we get when testing this series is: type size hasn't changed 1 data member change: 'uint8_t action_data[]' has *some* difference - please report as a bug which is why I reached out to Dodji (libabigail maintainer). Dodji explained me that zero length / flex arrays conversion is something he has been working on, and there are still some rough edges. This message is there so that libabigail community gets more input on real life cases to handle. > > I'm okay with the change being merged but if there is concern I can drop > this patch from the series. At least, we can't merge it in the current form. If libabigail gets a fix quickly, DPDK CI will still need a released versio= n. So for this patch to be merged now, we need a libabigail suppression rule. I don't see a way to precisely waive this issue, so my suggestion is to silence any change on the concerned structure here (which should be ok, as the pipeline library data struct have been super stable for a couple of years). Something like: $ git diff diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 21b8cd6113..d667157909 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -33,3 +33,5 @@ ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ; Temporary exceptions till next major ABI version ; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; +[suppress_type] + name =3D rte_pipeline_table_entry --=20 David Marchand