From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5669A0032; Wed, 6 Jul 2022 18:19:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C3CA40687; Wed, 6 Jul 2022 18:19:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3963140156 for ; Wed, 6 Jul 2022 18:19:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657124391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p9nlRmOVlXthkTUYBiq7Jm2lrO8/zdZhOklLMAQT+os=; b=a6BhduIwKds9SC+E7rAz4DPo6ioLWZCO+RMVmTRRqm8zdFTI4dqbzJ/3T3noR9kd8v+Ips xro/GPVJ7DzTODuxRjHtUuDOhDstcGxPbJUkS3V5qKB82oyX4i06nj1XjRjes0Ku+AgCHA RwfPSjF4nGd1vja47MeWNGr6CjO3Usg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-31--pp7HrsKNo-FYkn9G_WPqQ-1; Wed, 06 Jul 2022 12:19:50 -0400 X-MC-Unique: -pp7HrsKNo-FYkn9G_WPqQ-1 Received: by mail-lj1-f198.google.com with SMTP id k6-20020a2e9206000000b0025a8ce1a22eso4712947ljg.9 for ; Wed, 06 Jul 2022 09:19:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p9nlRmOVlXthkTUYBiq7Jm2lrO8/zdZhOklLMAQT+os=; b=6WUX5t1drmNezlD3Pufvvf2+rza+4QGN/XK/PZElyAHXc7mvKDT1pEk5sPBjZ74ZxT ecL5pt7lzsMeBI6pXXT2k0z46wRUWka9cZZqo6P0VI+k5AsjrqiIhcDGVg/q/RCZbpTk u3slknagzIeNvG2bPAkPsaWPJ5d5zuiNiZyIcwzzFHlwrUqcGp5T1dL/VJWZeskrN0z6 GgfktWnq8Jq106LEU70ruBEel4duRHd0Wr17z/J7hEPEEKR4C2ic0TwrUNVLRYtPkfv1 aT6k7/TnpwFRiOzpdh7h2DntZ1IaF0YnKji2oktujsYAUbUU7S/cS884vB4djIkn2YOL 0TTw== X-Gm-Message-State: AJIora8+qrWjH04jmLSJUUuT7KZRZOiRLczXXi8brTtZ5+ylA7OjDtHm USnvq0O8N5Ie1PJyYT/hGHIUnrQvzCJZBAYwIi8zt8/cxCWASj1mOMaWWqHTsfgGGZNGxIa/5ns 2H1cS9HWBDhmhcNhi/Hw= X-Received: by 2002:a05:6512:280c:b0:481:2fa:2816 with SMTP id cf12-20020a056512280c00b0048102fa2816mr28083220lfb.484.1657124388927; Wed, 06 Jul 2022 09:19:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tSimOUQhWw28sd6zCzHiywGtEZryi9XXEGs/QBrWtEBUTGwHtjN333B+KYU8elYYrwmbCJI/O1KACCZ0Cfy2Q= X-Received: by 2002:a05:6512:280c:b0:481:2fa:2816 with SMTP id cf12-20020a056512280c00b0048102fa2816mr28083202lfb.484.1657124388719; Wed, 06 Jul 2022 09:19:48 -0700 (PDT) MIME-Version: 1.0 References: <1657067328-18374-1-git-send-email-longli@linuxonhyperv.com> <1657067328-18374-2-git-send-email-longli@linuxonhyperv.com> <20220706080940.30299e2f@hermes.local> In-Reply-To: From: David Marchand Date: Wed, 6 Jul 2022 18:19:37 +0200 Message-ID: Subject: Re: [Patch v2 01/17] net/mana: add basic driver, build environment and doc To: Long Li Cc: Stephen Hemminger , "longli@linuxonhyperv.com" , Ferruh Yigit , "dev@dpdk.org" , Ajay Sharma , Stephen Hemminger , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 6, 2022 at 6:12 PM Long Li wrote: > > Is there a version dependency on rdma-core? Is that version dependency listed > > somewhere? > > The rdma-core and kernel drivers are being submitted. The expected version supporting MANA is with rdma-core v42 and Linux 5.19 (or 5.20). > > I'm not sure if there is a way to enforce meson to build on a certain rdma-core or kernel version. Is it okay to add the following information to doc/guides/nics/mana.rst for specifying the version requirement? You must check the headers are present (for example, by calling some cc.compile('include
'etc...). You might also need to check that the part of the API that this driver requires are available (common/mlx5/linux has some examples). If those requirements are not fulfilled, then skip this driver, setting build = false etc... -- David Marchand