From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7707943733; Mon, 18 Dec 2023 10:37:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39E1240E09; Mon, 18 Dec 2023 10:37:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B66A240276 for ; Mon, 18 Dec 2023 10:37:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702892247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=prXdP7cTXwrMvT1GkmMG8cHEWLcLNWkGw7iBCJjCCNw=; b=UljbQx/706D/GC0cJoSoEQsGiKz+bayAR/I6U1+JmR88EfkKsxmujZqZU0ElGiB0wR9vwx HpIitpCA0HGIRfapoEd6jIkI56ees/dUKfmqvQAd0q8kxMHCOjiUycIXh0tdqPxmyCwA/V pr7b/OXdtlSy77W8bnMvaDRNUpjTdZk= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-a_WfnnSXM963Ek5ezImuIw-1; Mon, 18 Dec 2023 04:37:25 -0500 X-MC-Unique: a_WfnnSXM963Ek5ezImuIw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ca29454857so22548951fa.0 for ; Mon, 18 Dec 2023 01:37:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702892244; x=1703497044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=prXdP7cTXwrMvT1GkmMG8cHEWLcLNWkGw7iBCJjCCNw=; b=TKrzhx8SoZexOinF/fWLlOTL8YRxriNfZdbxeBs86MoPQviIe88J0uRfOP+COLhDM+ srczQ8seFYCNliHw8c6rDTgCGEII/7x63Ekd4xNGPhU6wJgZXwz6Kx6uPjvt/A0EN5r+ gc0u0nsbYkkRZA+m5ywACX39WobtJpPi4IhgnKXZ8vLzsRRq5D5hGRYWssvGgA2kE4sR LaUybT5USNJhKqbFrMYGtlLDd6iWVfvO7nnXwYks3inuiuAYpDYJ9tvF3JJWq9YOV5q4 /xuyCf6X1A6j3toxQ0vBYySvVNfuel8tiXd6Tvf6UxGPznvHME3DlfaM9uc7/18pvKMo 7NuA== X-Gm-Message-State: AOJu0YyPbM1wUQ/0V8khuP96coZD0B27yhsbzEE18wVhGR0/ktcueJUN eS9QtmujdZsH0GAi+smKkrBDCxW9Y317KdCfSd4JyfE3aNQM0YI4sd+KndUmb2PrhYIftFItH1s +R8DGdLkKtijDOOj+Q+k= X-Received: by 2002:a2e:3a15:0:b0:2cc:7125:fa86 with SMTP id h21-20020a2e3a15000000b002cc7125fa86mr514681lja.54.1702892244004; Mon, 18 Dec 2023 01:37:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IF25rQA13elQcWo0P9ALb4FoCRHooXaEWHOV5Tmtm1j/CaGLFt+yJ9OXO3YoaJSWJNJfsrR3LWEcG8ThgtTocU= X-Received: by 2002:a2e:3a15:0:b0:2cc:7125:fa86 with SMTP id h21-20020a2e3a15000000b002cc7125fa86mr514677lja.54.1702892243716; Mon, 18 Dec 2023 01:37:23 -0800 (PST) MIME-Version: 1.0 References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-10-david.marchand@redhat.com> <20231208212749.GH5699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20231212191117.GA1160@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20231212191117.GA1160@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Mon, 18 Dec 2023 10:37:12 +0100 Message-ID: Subject: Re: [RFC v2 09/14] rcu: introduce a logging helper To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Honnappa Nagarahalli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 12, 2023 at 8:11=E2=80=AFPM Tyler Retzlaff wrote: > On Tue, Dec 12, 2023 at 04:00:35PM +0100, David Marchand wrote: > > On Fri, Dec 8, 2023 at 10:27=E2=80=AFPM Tyler Retzlaff > > wrote: > > > > > > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote: > > > > Signed-off-by: David Marchand > > > > --- > > > > > > Reviewed-by: Tyler Retzlaff > > > > > > > lib/rcu/rte_rcu_qsbr.c | 62 ++++++++++++++++----------------------= ---- > > > > lib/rcu/rte_rcu_qsbr.h | 1 + > > > > 2 files changed, 24 insertions(+), 39 deletions(-) > > > > > > > > diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c > > > > index 41a44be4b9..5b6530788a 100644 > > > > --- a/lib/rcu/rte_rcu_qsbr.c > > > > +++ b/lib/rcu/rte_rcu_qsbr.c > > > > @@ -19,6 +19,9 @@ > > > > #include "rte_rcu_qsbr.h" > > > > #include "rcu_qsbr_pvt.h" > > > > > > > > +#define RCU_LOG(level, fmt, args...) \ > > > > + RTE_LOG(level, RCU, "%s(): " fmt "\n", __func__, ## args) > > > > + > > > > > > Since you are looking in the area for all the versions of gcc/clang w= e > > > use able to support the non-standard __VA_ARGS__ that discard the com= ma? > > > > I suspect there is some typo (maybe s/for all/are all/ ?). > > Can you please clarify? > > > > > > > > > > I know that some versions of gcc do and if it does I would like to mo= ve > > > to using __VA_ARGS__ instead of args so we can use the same thing wit= h > > > msvc. > > > > If the request is to translate the ## args stuff to __VA_ARGS__, I > > would prefer this is done in a separate series and not to mix with > > this already huge series. > > Yes. > > I was asking if translation was possible from ## args to __VA_ARGS__. > > I was also asking if you could help do the translation. I didn't mean to > suggest it should be done in this series. Ok, I'll see if I can spend some cycles on this, but in January. --=20 David Marchand