From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 608E342C52; Wed, 7 Jun 2023 18:44:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4542C42C76; Wed, 7 Jun 2023 18:44:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 25B9242C4D for ; Wed, 7 Jun 2023 18:44:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686156261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QaUqNHm/HdIy7qZXI78mASdxd34lkQZiPjddlg5wQCY=; b=C3U8O5wFQlYjqqI1cDjEyhx065novpqDgGwS+XYibfK/cOXHAHu4BSCyEki7cwgJIQJ30H QBnf82EhlZS/NmDDczak5Gp03gNpAzUFaePn8KP0d3JYH+4CbfRXux/2GsgwRIM31oiwmu M/l/jVV7hmcZXhesoDrragdX+rWj5a8= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-Y5yNnK2VNnaqJGCYHRzhDg-1; Wed, 07 Jun 2023 12:44:20 -0400 X-MC-Unique: Y5yNnK2VNnaqJGCYHRzhDg-1 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-33b1e83e1d3so12041625ab.1 for ; Wed, 07 Jun 2023 09:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686156259; x=1688748259; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QaUqNHm/HdIy7qZXI78mASdxd34lkQZiPjddlg5wQCY=; b=gcqJarnYjBpxvVd/X17DdGTiSjGt25r08NzZDQe/SIoO0TVCsCslqp9/yR9+Iul+0f 5UaZk5n1ZkfIQ47xs2dADUjf22x1/h/jJv2xQPncCrfRvxupA+hAemfH+AxY/o61Qg5Y VgwlJ/tfTfv6u4LaNpT/0EmbDvO1USMcDXVQdFO0yOhAHN7+TjxZ36gaCIdnCU+78rZ5 iCRkd6S+pa5xIMQKy1NQefn0Uh5onN3cL9Nju4f2uryGgZM5RjbHC6ntjJOQFwdlcjU2 zO7MIenAcozAsBR2dJ4Kj8BkkLR+eKFpot1XqWTQg040eFtAp6RbTK2RQx4qQDgsa0y5 i4nA== X-Gm-Message-State: AC+VfDyv9wYsggYC9JBTsnks69jtgAz2U1wa0QQahhuijKOv7t7rfAXV zfpUjG8C4C1DdIkotbIM3ixZwXWuRW9yqiHaegfmeKylGBH9uWiGfyU1gL8dczdZdTLz0kuQCCy 3OoKnrHVTcwjuAIaT7kQ= X-Received: by 2002:a92:6e12:0:b0:335:9303:4345 with SMTP id j18-20020a926e12000000b0033593034345mr8718366ilc.25.1686156259415; Wed, 07 Jun 2023 09:44:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6NVMqoRHH3qKtGsZD2um/1eruTcjSf1AAyyUwXbkwQ7xd7jz+SkC6GNP6N59XSswf86hs9J/jlPTHpxveZK8E= X-Received: by 2002:a92:6e12:0:b0:335:9303:4345 with SMTP id j18-20020a926e12000000b0033593034345mr8718349ilc.25.1686156258854; Wed, 07 Jun 2023 09:44:18 -0700 (PDT) MIME-Version: 1.0 References: <20230329091658.1599349-1-leyi.rong@intel.com> In-Reply-To: From: David Marchand Date: Wed, 7 Jun 2023 18:44:07 +0200 Message-ID: Subject: Re: [PATCH] eal/x86: remove redundant round to improve performance To: Leyi Rong Cc: mb@smartsharesystems.com, bruce.richardson@intel.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 4, 2023 at 3:15=E2=80=AFPM David Marchand wrote: > On Wed, Mar 29, 2023 at 11:17=E2=80=AFAM Leyi Rong = wrote: > > > > In rte_memcpy_aligned(), one redundant round is taken in the 64 bytes > > block copy loops if the size is a multiple of 64. So, let the catch-up > > copy the last 64 bytes in this case. > > Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86") > > > > Suggested-by: Morten Br=C3=B8rup > > Signed-off-by: Leyi Rong > Reviewed-by: David Marchand Applied, thanks. --=20 David Marchand