From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0D7EA09FF; Wed, 6 Jan 2021 10:58:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAE45160933; Wed, 6 Jan 2021 10:58:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id BC037160930 for ; Wed, 6 Jan 2021 10:58:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609927127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCZQD634/6vf7oDMdrGQSC8A0voT8C21uNnweb0Oil8=; b=WbhzMTWfZtkYHgUu6niyzYU5oe3h+4mDhUAfkWCOXeXu4keb/tAIO5UWq7xSOS6ul5BvUj LfNgqVj/s608Tyk+O79Sy92K+Rj+B2BDOQn/L4MmNeu+D1fFE30hnsBq7QqC8S/0e/Kh7t /cRKGwFCl+HvuYijCYCGPHwAnIkdoos= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-535-3sFHsAS3PM2ijGpRAJu2oQ-1; Wed, 06 Jan 2021 04:58:45 -0500 X-MC-Unique: 3sFHsAS3PM2ijGpRAJu2oQ-1 Received: by mail-qv1-f70.google.com with SMTP id h1so1815659qvr.7 for ; Wed, 06 Jan 2021 01:58:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCZQD634/6vf7oDMdrGQSC8A0voT8C21uNnweb0Oil8=; b=KPuafKvIVJiA4BsRvA1brptqExqamy8RYSyRYekCzBcQOame582dFsjsxDKAVXqki6 nv//JamCLGdxuTMsRE8z3lphKvdPYQOjUCu+E8/5uiU86jrcfEuly8nT6LOY7HyauSDJ nEsLodvJ6sEd4OzD4N+43I+ZdiXWwfbsKwk/IFLKTLCeaEJDyAbGfOhcEw7BIYIRIT4/ ZbUPBk+quLD4sJabl979HfUnwrG2+dCLp4vKBCJR1b8Xf9TRLUSkLkDebzscH005zkeD qVm0HHeQw2RcHDdEpItY6EsaCDFLDBffegl/pdmIvEVsG0AFKw1RIt1CVuoU8DkjsLvV +GvA== X-Gm-Message-State: AOAM532nr0mWdGTRkILkb+B3GFOj+Mjbby0cnD3Ov86tsAqf+posA1uF EsOuwOeFUWrLnHA1z39x33u+XZoQSp6BN3lh7kTQwMTAfbmFvljsrjqRJI26o2lJZ6H/+RUhXAg WHzIYN6q3ZZIjmBxbhPg= X-Received: by 2002:a67:6781:: with SMTP id b123mr2630894vsc.10.1609927124290; Wed, 06 Jan 2021 01:58:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+TdCLBwiygNomC7yn3xTR4YV2e/wl3IUuPkXqnC6NqxdEjK/BnkmpFqWc/YFFyh6TQBFcrDX78pd9o2HwdzA= X-Received: by 2002:a67:6781:: with SMTP id b123mr2630862vsc.10.1609927124077; Wed, 06 Jan 2021 01:58:44 -0800 (PST) MIME-Version: 1.0 References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-15-maxime.coquelin@redhat.com> In-Reply-To: <20201220211405.313012-15-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 6 Jan 2021 10:58:33 +0100 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio HW struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin wrote: > > This patch improves the virtio_hw struct packing, > going from 88 down to 80 bytes with a 6 bytes hole in > the end of the first cacheline. Fields only used in the > slow path are placed in the end, so that hot path only > uses the first cacheline. This also changes some boolean fields to uint8_t but we still assign the true/false values to them (in some cases). This works, but I would align those fields' assignments to this type change. -- David Marchand