From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E3BBA04E7; Mon, 2 Nov 2020 16:50:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57E2AC92A; Mon, 2 Nov 2020 16:50:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 37DA3C92A for ; Mon, 2 Nov 2020 16:50:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604332252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GYjyXBEpLlQVG5EP0S06s2SN38KdNZExJAIrGvHlJQ4=; b=HE1bhroQA0IJYCYDsWG0xGjrhs9MUpSEKg/GkMS7mfeV0FMyJKnKpynL3lrNsl/k7qqpqb CbEcsO8koz29ozLOcVIDmjql6agLiBCxvGpJAPNOmOm9XvQ8rdWdccDyi/eXENBfIXwsen BNMktUjytlaBpJXb/tYFTkCDuKfsUug= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-_LcxJiqlPfGJYzd6mhkibw-1; Mon, 02 Nov 2020 10:50:49 -0500 X-MC-Unique: _LcxJiqlPfGJYzd6mhkibw-1 Received: by mail-vk1-f199.google.com with SMTP id l7so2417213vki.0 for ; Mon, 02 Nov 2020 07:50:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GYjyXBEpLlQVG5EP0S06s2SN38KdNZExJAIrGvHlJQ4=; b=p7/qkOHI5DJaYXfVOqRcMUL0dGWR1KsF3BKdL7DcXJ0uu99iWcGjUPzn9SRiCZI2j6 /H2lL8fuqjhNZYJGJ1bb0XGUCDASOnGd0uga+NzbrWyO64ToEyBrGd5zQBjA+zErmOQw i0IMHGlRC1Ky126v4eSlcapJlLUcX3MnoCTEI3JcGEYusfuSHzTjJv1xgf9glkcBdWFU iolcl3wAHVtfvUAW6HExsL584KsQn4P0QB3cewHYSeWn2mDXqwXKIFpGVr4Fgigp5uo3 qObIYDSBwPGv6usfykCnrEjYdoHr6dUN2FYGPV0Osb+5m3sRfk9LOE5Bjmly7aCgKJY5 r2Rw== X-Gm-Message-State: AOAM531s5cpHJD+qM4ay7xgIe+mha/b0DTjUNxvmT19buUvYSraaZ+B/ hssiDkUb4kkLlwRqlYMg1umkfUgBmMpIiY9dnieH5PoRS2w6ERY2snTlaP1MFva8IBazlN4lNdN Ha7W3qIUCjjMWeWBMu/Q= X-Received: by 2002:a67:fd46:: with SMTP id g6mr1419703vsr.27.1604332249208; Mon, 02 Nov 2020 07:50:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDUGS6N8BlVMy8Um49rqHbEHAUHyMSBaB0XD+HcBSHs8hsXLWAd+Zl8oo5F24GeVMLSFfLnCTM/ezRyxNEbdo= X-Received: by 2002:a67:fd46:: with SMTP id g6mr1419696vsr.27.1604332249027; Mon, 02 Nov 2020 07:50:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Mon, 2 Nov 2020 16:50:38 +0100 Message-ID: To: Jerin Jacob Kollanukkaran , Thomas Monjalon , "timothy.mcdaniel@intel.com" Cc: "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [pull-request] next-eventdev 20.11 RC2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 2, 2020 at 3:31 PM Jerin Jacob Kollanukkaran wrote: > > The following changes since commit 79d69c6dcf0debea38ac258d230e2f8c93e5ad12: > > mbuf: remove seqn field (2020-10-31 22:14:44 +0100) > > are available in the Git repository at: > > http://dpdk.org/git/next/dpdk-next-eventdev > > for you to fetch changes up to e06cd1ddfeac30b4926a52a69336b4f25a9cd209: > > eventdev: check input parameter for dump op (2020-11-02 19:16:51 +0530) > > ---------------------------------------------------------------- > David Marchand (1): > eventdev: check input parameter for dump op About this patch, could we squash some change in the dlb/dlb2 drivers? I guess Thomas could do it while pulling if nobody objects? diff --git a/drivers/event/dlb/dlb_xstats.c b/drivers/event/dlb/dlb_xstats.c index 89186d506e..5f4c590307 100644 --- a/drivers/event/dlb/dlb_xstats.c +++ b/drivers/event/dlb/dlb_xstats.c @@ -921,11 +921,6 @@ dlb_eventdev_dump(struct rte_eventdev *dev, FILE *f) struct dlb_hw_dev *handle; int i; - if (f == NULL) { - DLB_LOG_ERR("Invalid file pointer\n"); - return; - } - dlb = dlb_pmd_priv(dev); if (dlb == NULL) { diff --git a/drivers/event/dlb2/dlb2_xstats.c b/drivers/event/dlb2/dlb2_xstats.c index a274779fee..8c3c3cda94 100644 --- a/drivers/event/dlb2/dlb2_xstats.c +++ b/drivers/event/dlb2/dlb2_xstats.c @@ -972,11 +972,6 @@ dlb2_eventdev_dump(struct rte_eventdev *dev, FILE *f) struct dlb2_hw_dev *handle; int i; - if (f == NULL) { - DLB2_LOG_ERR("Invalid file pointer\n"); - return; - } - dlb2 = dlb2_pmd_priv(dev); if (dlb2 == NULL) { -- David Marchand